Escaping the plus (+) sign in an XBasic function

[RustyB]

I feel that I am missing something obvious. I have a small IIS server app whose only job is to convert signatures saved in the ink format to png. I have a javascript function that loops through a list to get all the signatures in the ink format. It then passes the info to an XBasic function, which calls the a5_ink_to_png function to save the ink as a png on our server. The problem is that whenever I pass the ink to the XBasic function, the plus (+) signs are missing from the data. There must be some obvious way to escape the + signs that I am missing. My XBasic function looks at follows

function convertInk as c (e as p)
	on error goto error_handler

	dim flagUseViewBox as L
	flagUseViewBox = .f.
	dim ink as C = e.ApprovedBySignature
	dim placepk as C = e.PlacePK
	dim salescallid as C = e.SalesCallID

	a5_ink_to_png(ink,300,750,"C:\inetpub\wwwroot\appPhotos\ink_"+placepk+"_"+salescallid+".png",flagUseViewBox)

	save_to_file("convertInk success:ink_"+placepk+"_"+salescallid+".png" + crlf() + "ink:" + ink + crlf() + "c.ApprovedBySignature:"+e.ApprovedBySignature + crlf(), "C:\Users\Public\Documents\ServerTasks.txt", .T.)
	convertInk = "console.log('covertInk XBasic funtion - success');"
	end
	error_handler:
	    err = error_code_get()
	    msg = error_text_get(err)
	    msg = STRTRAN(msg, crlf(), "")
	    save_to_file("Error in convertInk: " + msg+ crlf(), "C:\Users\Public\Documents\ServerTasks.txt", .T.)
	    convertInk = "console.log('covertInk XBasic funtion - error');"
	end
end function

My Alpha build is 6402. Using the XBasic debugger, I am able to do something like this

dim str as C
str = "hello+hello"

The variable str prints out with the + sign in it, so I am not sure why the + sign is missing when passed in to the XBasic function. Thanks in advance for any help.

[Sarah Mitchell]

Re: Escaping the plus (+) sign in an XBasic function

I feel that I am missing something obvious. I have a small IIS server app whose only job is to convert signatures saved in the ink format to png. I have a javascript function that loops through a list to get all the signatures in the ink format. It then passes the info to an XBasic function, which calls the a5_ink_to_png function to save the ink as a png on our server. The problem is that whenever I pass the ink to the XBasic function, the plus (+) signs are missing from the data. There must be some obvious way to escape the + signs that I am missing. My XBasic function looks at follows

function convertInk as c (e as p)
	on error goto error_handler

	dim flagUseViewBox as L
	flagUseViewBox = .f.
	dim ink as C = e.ApprovedBySignature
	dim placepk as C = e.PlacePK
	dim salescallid as C = e.SalesCallID

	a5_ink_to_png(ink,300,750,"C:\inetpub\wwwroot\appPhotos\ink_"+placepk+"_"+salescallid+".png",flagUseViewBox)

	save_to_file("convertInk success:ink_"+placepk+"_"+salescallid+".png" + crlf() + "ink:" + ink + crlf() + "c.ApprovedBySignature:"+e.ApprovedBySignature + crlf(), "C:\Users\Public\Documents\ServerTasks.txt", .T.)
	convertInk = "console.log('covertInk XBasic funtion - success');"
	end
	error_handler:
	    err = error_code_get()
	    msg = error_text_get(err)
	    msg = STRTRAN(msg, crlf(), "")
	    save_to_file("Error in convertInk: " + msg+ crlf(), "C:\Users\Public\Documents\ServerTasks.txt", .T.)
	    convertInk = "console.log('covertInk XBasic funtion - error');"
	end
end function

My Alpha build is 6402. Using the XBasic debugger, I am able to do something like this

dim str as C
str = "hello+hello"

The variable str prints out with the + sign in it, so I am not sure why the + sign is missing when passed in to the XBasic function. Thanks in advance for any help.

What is your JavaScript for passing the data to the Ajax callback?

[Davidk]

Re: Escaping the plus (+) sign in an XBasic function

Rusty, you may just need to encode the ink string before passing it to XBasic.

var encSigInk = encodeURI(sigInk);

I've tested this and the a5_ink_to_png works fine on an encoded string.

Are you getting an error with your code?

[RustyB]

Re: Escaping the plus (+) sign in an XBasic function

What is your JavaScript for passing the data to the Ajax callback?

Hi Sarah. This is my Javascript.

console.log('BTN_CONVERTALL - start'); 
var obj_list_LISTSALESCALLLIST = {dialog.object}.getControl("LISTSALESCALLLIST");
var SalesCallListObj = obj_list_LISTSALESCALLLIST._data.filter(index => (index.ApprovedBySignature != "" && index.ApprovedBySignature != null) && (index.ApprovedBySignatureFilename == "" || index.ApprovedBySignatureFilename == null));
if(typeof SalesCallListObj != "undefined"){
	console.log('BTN_CONVERTALL - length:'+SalesCallListObj.length);
	for (var i = 0; i < SalesCallListObj.length; i++) {
		var PlacePK = SalesCallListObj[i].PlacePK;
		var SalesCallID = SalesCallListObj[i].SalesCallID;
		var ApprovedBySignature = SalesCallListObj[i].ApprovedBySignature;
		//var ApprovedBySignature = ApprovedBySignature.replace(/+/g, "\+");
		var reportParameters = 'PlacePK=' + PlacePK + '&SalesCallID=' + SalesCallID + '&ApprovedBySignature=' + ApprovedBySignature;
		console.log('BTN_CONVERTALL - About to call convertInk XBasic funtion - reportParameters:'+reportParameters); 
		{dialog.object}.ajaxCallback('', '', 'convertInk', '', reportParameters, {
			errorFunction: function() {
										console.log('Ajax Callback Action - convertInk - errorFunction');  
									  },
			onComplete: function() { 
									    console.log('Ajax Callback Action - convertInk - onComplete');
									    var jsonData = {};
									    jsonData.ApprovedBySignatureFilename = "ink_"+PlacePK+"_"+SalesCallID+".png";
									    obj_list_LISTSALESCALLLIST.updateTableRow(SalesCallID,jsonData);
								   },
			deviceOfflineFunction: function() {
												console.log('Ajax Callback Action - convertInk - deviceOfflineFunction');
								   			  }
		});
		console.log('CovertAll:');
	}
}else{
	console.log('CovertAll: No records found in SalesCallList');
}

console.log('BTN_CONVERTALL - end');

Thanks Penge. I'll give that a try in the morning.

[Davidk]

Re: Escaping the plus (+) sign in an XBasic function

I don't know how many List rows you're working on, but I wouldn't make 1 Ajax Callback for each row. I would collect all information in a json object array, convert it to a string, and pass that data back to XBasic. Convert that json to a pointer variable and loop through processing the ink data. 1 callback for all the data.

[RustyB]

Re: Escaping the plus (+) sign in an XBasic function

Rusty, you may just need to encode the ink string before passing it to XBasic.

Are you getting an error with your code?

Unfortunately the encodeURI function did not work. No, I am not getting any errors in my code. It is the weiredest thing. I can console log the ink field in Javascript and the + signs are there, but when I pass them to XBasic the + signs are gone.

I don't know how many List rows you're working on, but I wouldn't make 1 Ajax Callback for each row. I would collect all information in a json object array, convert it to a string, and pass that data back to XBasic. Convert that json to a pointer variable and loop through processing the ink data. 1 callback for all the data.

I'm not dealing with much data. As a matter of fact, the next step after I get this working is to try to make this a little more automatic and have the process trigger as soon as a signature is synced from someones tablet. But what you are saying sounds like a pretty good practice. I will try that out.

[Davidk]

Re: Escaping the plus (+) sign in an XBasic function

Using your code, without the encodeURI, a5_ink_to_png() gives me an XBasic error "Unexpected token xx in JSON at position 0" . With the encodeURI in place in the Javascript code, there are no errors and the conversion is successful.

Are you sure your target folders have all the proper permission for writing a file?

Regarding the missing "+" signs from the signature, I see the same here, there are no "+" signs. I don't think this is the issue as they are probably just non-displayable characters.

How do all the variables look under Javascript and XBasic debugging?

[Davidk]

Re: Escaping the plus (+) sign in an XBasic function

Another Javascript function to try is encodeURIComponent() as this encodes more characters including +. At least this will give you back your + signs. I get the same successful results using either function but you may have better luck using this.

I may have misunderstood your original post. Are your + signs simply missing from your txt file? Is that the only problem?

Is your png file being correctly created?

[RustyB]

Re: Escaping the plus (+) sign in an XBasic function

Regarding the missing "+" signs from the signature, I see the same here, there are no "+" signs. I don't think this is the issue as they are probably just non-displayable characters.

The png file does not look right at all and does not match the signature. That is why I though the + signs missing were causing problems. It does create the png, so I don't think it is a permission issue.

Using your code, without the encodeURI, a5_ink_to_png() gives me an XBasic error "Unexpected token xx in JSON at position 0"

I was getting that error in Live Preview, but not when I published to the server. So I thought it was just a Live Preview problem.

[RustyB]

Re: Escaping the plus (+) sign in an XBasic function

Another Javascript function to try is encodeURIComponent() as this encodes more characters including +. At least this will give you back your + signs. I get the same successful results using either function but you may have better luck using this.

encodeURIComponent() did the trick. Thank you so much for your help!!!