end while error - xbasic array Multiple SMS twilio

[CharlesParker]

I have the following xbasic that is giving me an annoying error after a successful send! In other words it works as expected and sends multiple SMS messages but for some reason it still throws the error. I also noticed that for some reason remspecial doesn't seem to work but again this does work as expected and sends all sms messages as expected.

xbasic

FUNCTION SendTw AS C (e as p)

debug(1)
'==CONNECTION AND VARS
dim cn as SQL::Connection
dim vHasError as c
dim cf_1 as extension::CurlFile
dim flag_1 as l
dim ce as extension::Curl    
dim vSendNumber as c
dim args as sql::arguments
dim vUser as c
dim SendTw as c




vHasError = "N"


cn.open("::Name::Connection1")


vTwilioURLPre= "https://api.twilio.com/2010-04-01/Accounts/"
vSID = "******"
vTwilioURL=vTwilioURLPre+vSID+"/Messages.json"
vToken = "*******"
vPassword=vSID+":"+vToken
vFromNumber="+******"
vFrom="&From="+vFromNumber




vSubject = "Job Assigments" 'irrelevant really to the SMS




args.Add("thedate",convert_type(e._CurrentRowDataNew.Date,"D"))
args.Add("coid",e._CurrentRowDataNew.company_id)


 
vSelect = "SELECT Employee_phone, Sending_Data FROM alphanwcopro.send_tasks WHERE Date = :thedate AND company_id = :coid"


cn.execute(vSelect,args)


ce = extension::Curl.Init()
ce.setOpt("URL",vTwilioURL)
ce.setOpt("NOPROGRESS",1)
ce.setOpt("USERPWD",vPassword)
ce.setOpt("USERAGENT","curl/7.34.0")
ce.setOpt("MAXREDIRS",50)
ce.setOpt("CAINFO","C:\\Program Files (x86)\\a5V12\\CARoot\\ca-cert.pem")
ce.setOpt("CAPATH","C:\\Program Files (x86)\\a5V12\\CARoot")
ce.setOpt("CUSTOMREQUEST","POST")
ce.setOpt("TCP_KEEPALIVE",1)






while eval_valid(cn.ResultSet.data("Employee_phone"))


vSendNumber= cn.ResultSet.data("Employee_phone")
vMessage = cn.ResultSet.data("Sending_Data")
vTo="&To=+1"+remspecial(vSendNumber)
vBody = "Body="+urlencode(vMessage)    
vPostFields=vBody+vFrom+vTo


ce.setOpt("POSTFIELDS",vPostFields)
ce.SetOpt("FILE",cf_1)
flag_1 = ce.Exec()


flag_1 = cn.ResultSet.NextRow()


end while
ce.close()
cn.Close()


end function

error is attached - any thoughts would be helpful!

end-while-error.JPG

[madtowng]

Re: end while error - xbasic array Multiple SMS twilio

I could be wrong but shouldn't the while statement be while eval_valid(cn.ResultSet.data("Employee_phone")) .and. flag1 ?

[CharlesParker]

Re: end while error - xbasic array Multiple SMS twilio

Testing that and
while eval_valid(cn.ResultSet.data("Employee_phone".and. flag_1))
your suggestion did not work and throws an error that the arg is an incorrect type
my attempt to put the .and. inside resulted in one of the 3 expected sends to go through.
On the bright side, the end while error was not produced, lol

[madtowng]

Re: end while error - xbasic array Multiple SMS twilio

lol...my goal was to get rid of the end while error.
Now that that's done, need to figure out what's wrong with the rest of the code.
It's obviously not all bad since something got through. I'm guessing your code
needs to test for at least 1 more option.

[madtowng]

Re: end while error - xbasic array Multiple SMS twilio

Now that I'm thinking about this, what is the difference between the text that got through, and the one(s) that didn't get through.

[CharlesParker]

Re: end while error - xbasic array Multiple SMS twilio

nothing really, they all go through unless I add the ".and. flag_1 at the and then ONLY 1 goes.
I have lots of test data, regardless only 1 goes through.

Now, running the original code they all go through and it works as expected except for the xbasic error stating we have a null value now

[madtowng]

Re: end while error - xbasic array Multiple SMS twilio

I'm guessing the one that gets through is the first one.

[CharlesParker]

Re: end while error - xbasic array Multiple SMS twilio

yes, I wish there was a way to suppress the error for now - the code works except it seems to find the null array value and proudly announce it instead of ending the while statement...and closing the curl command

[CharlesParker]

Re: end while error - xbasic array Multiple SMS twilio

I guess NULL is valid?

[madtowng]

Re: end while error - xbasic array Multiple SMS twilio

what field or fields have the null value ?
Is this something that can be filtered out in the sql query ?

[Al Buchholz]

Re: end while error - xbasic array Multiple SMS twilio

So you want to loop through the entire ResultSet and only send data to Twilio if the row has a valid Employee_phone number?

I think your statement

eval_valid(cn.ResultSet.data("Employee_phone"))

needs to be an if block within the loop.

I found this in the docs...

rs = conn.ResultSet

while rs.NextRow()

    <do something for each row found>

end while

do yours would look like

while cn.NextRow()
if eval_valid(cn.ResultSet.data("Employee_phone")) then
<send to Twillio>
end if
end while

I'm thinking you're now reading through the ResultSet until you read an invalid Employee_phone and stopping the loop.

If all Employee_phone values are valid, the while tries to read one row beyond the end of the ResultSet and errors since there is not another row.

Or am I suffering from a lack of coffee?

[CharlesParker]

Re: end while error - xbasic array Multiple SMS twilio

Gregg, there are no NULL values in the data - Al is more on point in that the statement is continuing beyond into an invalid result - I will let you guys know what I can do with Al's suggestion

[madtowng]

Re: end while error - xbasic array Multiple SMS twilio

This is telling me that something about Employee_phone isn't valid.
I would think changing your vSelect line to vSelect = "SELECT Employee_phone, Sending_Data FROM alphanwcopro.send_tasks WHERE Date = :thedate AND company_id = :coid and Employee_phone is not null and trim(Employee_phone) <> '' " would eliminate the need for the if/then block, unless something else is causing flag1 to be false.

[CharlesParker]

Re: end while error - xbasic array Multiple SMS twilio

Success! I changed the lower half to read as follows:

While cn.ResultSet.Nextrow()
if eval_valid(cn.ResultSet.data("Employee_phone")) then

vSendNumber= cn.ResultSet.data("Employee_phone")
vMessage = cn.ResultSet.data("Sending_Data")
vTo="&To=+1"+remspecial(vSendNumber)
vBody = "Body="+urlencode(vMessage)	
vPostFields=vBody+vFrom+vTo

ce.setOpt("POSTFIELDS",vPostFields)
ce.SetOpt("FILE",cf_1)
flag_1 = ce.Exec()

flag_1 = cn.ResultSet.NextRow()

end if
end while
ce.close()
cn.Close()

No more errors! thanks a googolplex!

[madtowng]

Re: end while error - xbasic array Multiple SMS twilio

good job