Javascript function

[dfricke10]

What would be the correct format for this script. It works, but I know it's not correct. I can't get the proper 'else' terms right.

function setpricing() {

	var ptype =  ({dialog.object}.getValue('PricingType'));
	var onert = ({dialog.object}.getValue('one_retail'));
	var lnftrt = ({dialog.object}.getValue('lnft_retail'));
	var sqftrt = ({dialog.object}.getValue('sqft_retail'));
	var varirt = ({dialog.object}.getValue('vari_retail'));
	
	if(ptype == "1") {
		return {dialog.object}.setValue('Price',onert);
		}
		else
		{
	if(ptype == "2") 
		return {dialog.object}.setValue('Price',sqftrt);
		
		}
		{
	if(ptype == "3") 
		return {dialog.object}.setValue('Price',lnftrt);
		
		}
				{
	if(ptype == "4") 
		return {dialog.object}.setValue('Price',varirt);
		
		}

}

It checks the PricingType field for a specific number and then sets the Price field accordingly.

[Davidk]

Re: Javascript function

Don't use an if statement for this... use "switch"... much cleaner... easier to read and understand.

	switch(pType){
		case "1":
			{dialog.object}.setValue('Price',onert);
			break;
		case "2":
			{dialog.object}.setValue('Price',sqftrt);
			break;
		case "3":
			{dialog.object}.setValue('Price',lnftrt);
			break;
		case "4":
			{dialog.object}.setValue('Price',varirt);
			break;
	}

But, to answer the question... each if statement, except the last (unless you want a default), needs an else. And... indent... easier to read... but it's still a bit of a mess.

	if(pType == "1"){
		{dialog.object}.setValue('Price',onert);
	}else{
		if(pType == "2"){
			{dialog.object}.setValue('Price',sqftrt);
		}else{
			if(pType == "3"){
				{dialog.object}.setValue('Price',lnftrt);
			}else{
				if(pType == "4"){
					{dialog.object}.setValue('Price',varirt);
				}
			}
		}
	}

And... if I may... use camelCase... e.g. pType instead of ptype... setPricing instead of setpricing. And... why "return" the setValue... why not just run the setValue?

And... why are you wrapping your .getValue methods in parens? It's not needed.

[GGandhi]

Re: Javascript function

function setpricing() {

	var ptype = {dialog.object}.getValue('PricingType');
	var onert = {dialog.object}.getValue('one_retail');
	var lnftrt = {dialog.object}.getValue('lnft_retail');
	var sqftrt = {dialog.object}.getValue('sqft_retail');
	var varirt = {dialog.object}.getValue('vari_retail');
	
	if(ptype == "1") {
		{dialog.object}.setValue('Price',onert);
		}
	else if(ptype == "2") {
		{dialog.object}.setValue('Price',sqftrt);
		} 
        else  if(ptype == "3") {
		{dialog.object}.setValue('Price',lnftrt);
		}
        else if(ptype == "4") {
		{dialog.object}.setValue('Price',varirt);
		}

this should work also.
as you can see in your example the code worked even though it did not look right.
multiple if statements can be just listed as they are, or including else ifs.
the difference is that if you do not have else condition then the entire code segment needs to be run thru before exiting even though first line is proved to be the selected item. switch is much cleaner for the user to read definitely, so is the above example. in both when the condition is satisfied the loop exists saving processor time.

in javascript almost all use camel case instead of underline character but in my learning the camel case and underline character separates words not just break apart a single word. for example:
pType when used for ptype won't mean anything to me but priceType or price_type will. ( one can argue ptype is not a recognizable English word, so camel case is recommended or used, then they have a point)
your naming convention reminds me of old desktop (DOS) limitation of seven characters or less, i think you can use descriptive names like

var priceType = {dialog.object}.getValue('PricingType');
	var oneRetail = {dialog.object}.getValue('one_retail');
	var lineFootRetail = {dialog.object}.getValue('lnft_retail');
	var squareFootRetail = {dialog.object}.getValue('sqft_retail');
	var variableRetail = {dialog.object}.getValue('vari_retail');

so also in the ux/dilaog
instead of lnft_retail, line_foot_retail then you will notice the dialog will make the label Line Foot Retail saving you to go back rename the label
so if you ever have an assistant looking at this code he/she will understand right away what you are doing.

[dfricke10]

Re: Javascript function

Thank you both for the insight. I'm very good at using the Alpha components to do what I want to do, but my app is growing rapidly and it was about time I started using functions to make things cleaner and faster. So, I'm still learning this but I'm a quick study. And yes, gandhi, I'm a 90's computer guy, so the short abbreviations are probably my subconscious doing it. :)

David, I copied some from a previous function, so no idea why the brackets. But it looks like I'l be reviewing some of the previous code.

Thanks again!!!