Alpha Software Mobile Development Tools:   Alpha Anywhere    |   Alpha TransForm subscribe to our YouTube Channel  Follow Us on LinkedIn  Follow Us on Twitter  Follow Us on Facebook

Announcement

Collapse

The Alpha Software Forum Participation Guidelines

The Alpha Software Forum is a free forum created for Alpha Software Developer Community to ask for help, exchange ideas, and share solutions. Alpha Software strives to create an environment where all members of the community can feel safe to participate. In order to ensure the Alpha Software Forum is a place where all feel welcome, forum participants are expected to behave as follows:
  • Be professional in your conduct
  • Be kind to others
  • Be constructive when giving feedback
  • Be open to new ideas and suggestions
  • Stay on topic


Be sure all comments and threads you post are respectful. Posts that contain any of the following content will be considered a violation of your agreement as a member of the Alpha Software Forum Community and will be moderated:
  • Spam.
  • Vulgar language.
  • Quotes from private conversations without permission, including pricing and other sales related discussions.
  • Personal attacks, insults, or subtle put-downs.
  • Harassment, bullying, threatening, mocking, shaming, or deriding anyone.
  • Sexist, racist, homophobic, transphobic, ableist, or otherwise discriminatory jokes and language.
  • Sexually explicit or violent material, links, or language.
  • Pirated, hacked, or copyright-infringing material.
  • Encouraging of others to engage in the above behaviors.


If a thread or post is found to contain any of the content outlined above, a moderator may choose to take one of the following actions:
  • Remove the Post or Thread - the content is removed from the forum.
  • Place the User in Moderation - all posts and new threads must be approved by a moderator before they are posted.
  • Temporarily Ban the User - user is banned from forum for a period of time.
  • Permanently Ban the User - user is permanently banned from the forum.


Moderators may also rename posts and threads if they are too generic or do not property reflect the content.

Moderators may move threads if they have been posted in the incorrect forum.

Threads/Posts questioning specific moderator decisions or actions (such as "why was a user banned?") are not allowed and will be removed.

The owners of Alpha Software Corporation (Forum Owner) reserve the right to remove, edit, move, or close any thread for any reason; or ban any forum member without notice, reason, or explanation.

Community members are encouraged to click the "Report Post" icon in the lower left of a given post if they feel the post is in violation of the rules. This will alert the Moderators to take a look.

Alpha Software Corporation may amend the guidelines from time to time and may also vary the procedures it sets out where appropriate in a particular case. Your agreement to comply with the guidelines will be deemed agreement to any changes to it.



Bonus TIPS for Successful Posting

Try a Search First
It is highly recommended that a Search be done on your topic before posting, as many questions have been answered in prior posts. As with any search engine, the shorter the search term, the more "hits" will be returned, but the more specific the search term is, the greater the relevance of those "hits". Searching for "table" might well return every message on the board while "tablesum" would greatly restrict the number of messages returned.

When you do post
First, make sure you are posting your question in the correct forum. For example, if you post an issue regarding Desktop applications on the Mobile & Browser Applications board , not only will your question not be seen by the appropriate audience, it may also be removed or relocated.

The more detail you provide about your problem or question, the more likely someone is to understand your request and be able to help. A sample database with a minimum of records (and its support files, zipped together) will make it much easier to diagnose issues with your application. Screen shots of error messages are especially helpful.

When explaining how to reproduce your problem, please be as detailed as possible. Describe every step, click-by-click and keypress-by-keypress. Otherwise when others try to duplicate your problem, they may do something slightly different and end up with different results.

A note about attachments
You may only attach one file to each message. Attachment file size is limited to 2MB. If you need to include several files, you may do so by zipping them into a single archive.

If you forgot to attach your files to your post, please do NOT create a new thread. Instead, reply to your original message and attach the file there.

When attaching screen shots, it is best to attach an image file (.BMP, .JPG, .GIF, .PNG, etc.) or a zip file of several images, as opposed to a Word document containing the screen shots. Because Word documents are prone to viruses, many message board users will not open your Word file, therefore limiting their ability to help you.

Similarly, if you are uploading a zipped archive, you should simply create a .ZIP file and not a self-extracting .EXE as many users will not run your EXE file.
See more
See less

Javascript function

Collapse
X
 
  • Filter
  • Time
  • Show
Clear All
new posts

    Javascript function

    What would be the correct format for this script. It works, but I know it's not correct. I can't get the proper 'else' terms right.

    Code:
    function setpricing() {
    
    	var ptype =  ({dialog.object}.getValue('PricingType'));
    	var onert = ({dialog.object}.getValue('one_retail'));
    	var lnftrt = ({dialog.object}.getValue('lnft_retail'));
    	var sqftrt = ({dialog.object}.getValue('sqft_retail'));
    	var varirt = ({dialog.object}.getValue('vari_retail'));
    	
    	if(ptype == "1") {
    		return {dialog.object}.setValue('Price',onert);
    		}
    		else
    		{
    	if(ptype == "2") 
    		return {dialog.object}.setValue('Price',sqftrt);
    		
    		}
    		{
    	if(ptype == "3") 
    		return {dialog.object}.setValue('Price',lnftrt);
    		
    		}
    				{
    	if(ptype == "4") 
    		return {dialog.object}.setValue('Price',varirt);
    		
    		}
    
    }
    It checks the PricingType field for a specific number and then sets the Price field accordingly.

    #2
    Re: Javascript function

    Don't use an if statement for this... use "switch"... much cleaner... easier to read and understand.

    Code:
    	switch(pType){
    		case "1":
    			{dialog.object}.setValue('Price',onert);
    			break;
    		case "2":
    			{dialog.object}.setValue('Price',sqftrt);
    			break;
    		case "3":
    			{dialog.object}.setValue('Price',lnftrt);
    			break;
    		case "4":
    			{dialog.object}.setValue('Price',varirt);
    			break;
    	}
    But, to answer the question... each if statement, except the last (unless you want a default), needs an else. And... indent... easier to read... but it's still a bit of a mess.

    Code:
    	if(pType == "1"){
    		{dialog.object}.setValue('Price',onert);
    	}else{
    		if(pType == "2"){
    			{dialog.object}.setValue('Price',sqftrt);
    		}else{
    			if(pType == "3"){
    				{dialog.object}.setValue('Price',lnftrt);
    			}else{
    				if(pType == "4"){
    					{dialog.object}.setValue('Price',varirt);
    				}
    			}
    		}
    	}
    And... if I may... use camelCase... e.g. pType instead of ptype... setPricing instead of setpricing. And... why "return" the setValue... why not just run the setValue?

    And... why are you wrapping your .getValue methods in parens? It's not needed.

    Comment


      #3
      Re: Javascript function

      Code:
      function setpricing() {
      
      	var ptype = {dialog.object}.getValue('PricingType');
      	var onert = {dialog.object}.getValue('one_retail');
      	var lnftrt = {dialog.object}.getValue('lnft_retail');
      	var sqftrt = {dialog.object}.getValue('sqft_retail');
      	var varirt = {dialog.object}.getValue('vari_retail');
      	
      	if(ptype == "1") {
      		{dialog.object}.setValue('Price',onert);
      		}
      	else if(ptype == "2") {
      		{dialog.object}.setValue('Price',sqftrt);
      		} 
              else  if(ptype == "3") {
      		{dialog.object}.setValue('Price',lnftrt);
      		}
              else if(ptype == "4") {
      		{dialog.object}.setValue('Price',varirt);
      		}
      this should work also.
      as you can see in your example the code worked even though it did not look right.
      multiple if statements can be just listed as they are, or including else ifs.
      the difference is that if you do not have else condition then the entire code segment needs to be run thru before exiting even though first line is proved to be the selected item. switch is much cleaner for the user to read definitely, so is the above example. in both when the condition is satisfied the loop exists saving processor time.

      in javascript almost all use camel case instead of underline character but in my learning the camel case and underline character separates words not just break apart a single word. for example:
      pType when used for ptype won't mean anything to me but priceType or price_type will. ( one can argue ptype is not a recognizable English word, so camel case is recommended or used, then they have a point)
      your naming convention reminds me of old desktop (DOS) limitation of seven characters or less, i think you can use descriptive names like
      Code:
      var priceType = {dialog.object}.getValue('PricingType');
      	var oneRetail = {dialog.object}.getValue('one_retail');
      	var lineFootRetail = {dialog.object}.getValue('lnft_retail');
      	var squareFootRetail = {dialog.object}.getValue('sqft_retail');
      	var variableRetail = {dialog.object}.getValue('vari_retail');
      so also in the ux/dilaog
      instead of lnft_retail, line_foot_retail then you will notice the dialog will make the label Line Foot Retail saving you to go back rename the label
      so if you ever have an assistant looking at this code he/she will understand right away what you are doing.
      Last edited by GGandhi; July 25, 2017, 07:03 AM.
      thanks for reading

      gandhi

      version 11 3381 - 4096
      mysql backend
      http://www.alphawebprogramming.blogspot.com
      [email protected]
      Skype:[email protected]
      1 914 924 5171

      Comment


        #4
        Re: Javascript function

        Thank you both for the insight. I'm very good at using the Alpha components to do what I want to do, but my app is growing rapidly and it was about time I started using functions to make things cleaner and faster. So, I'm still learning this but I'm a quick study. And yes, gandhi, I'm a 90's computer guy, so the short abbreviations are probably my subconscious doing it. :)

        David, I copied some from a previous function, so no idea why the brackets. But it looks like I'l be reviewing some of the previous code.

        Thanks again!!!

        Comment

        Working...
        X