Zooming to Record from Browse

[johngtatp]

I was having issues with "Zoom to a Record" which occasionally would throw out an error or go to the wrong record, so I wrote my own...

dim sptr as P
DIM GLOBAL getrecordnum AS N
getrecordnum = a5_eval_expression("=recno(\"rcardetail\")")
sptr = Form.load("Rental Car Edit","dialog","","Center","Center")
sptr.Recno_goto(var->getrecordnum)
sptr.show()

Every once and a while I still get the wrong record to show in the form. I am using shadowed network workstations for this app and was wondering if anyone else had this issue. Rebooting the machine seems to help which led me to believe its a corrupt index. I am trying a test to flush the index on workstation via a button but I have to wait until it happens again to see if this could be the culprit.

[MoGrace]

Re: Zooming to Record from Browse

Are you saving the record first before this script runs so you are sure you are in view mode on the parent form?

[johngtatp]

Re: Zooming to Record from Browse

Are you saving the record first before this script runs so you are sure you are in view mode on the parent form?

Yes, the browse is read only. Users can only enter from a single record form. This is only to edit the record in the browse. I also have multiple users, could this have some effect perhaps?

[Tom Cone Jr]

Re: Zooming to Record from Browse

John,

You're calling the edit form as "dialog". This requires special handling in your script. Check the help file discussion of the LOAD method of the FORM object for details. Unless they've changed something in the last version your calling script must explicitly close the dialog form. User closing the dialog's window does NOT release it from memory, or close the table(s) that were opened when the edit dialog is opened.

[Ray in Capetown]

Re: Zooming to Record from Browse

Use pointers rather than eval with a table name, it makes assumptions

curecn=table.current().recno() ' guaranteed the record in focus
'Then best to check if there is an already open form and get or give it a pointer
dim pfod as p
if is_object("Rental Car Edit")=.f.
	pfod=form.load("Rental Car Edit") ' dialog or whatever you like
else
	pfod = obj("Rental Car Edit")
end if

pfod.Recno_goto(curecn) 'makes the specified record number current.
pfod.Activate()

like Tom says - you may otherwise not be closing and then opening multiple instances of the form.

[Tom Cone Jr]

Re: Zooming to Record from Browse

Here's a link to the help file material.

The "Dialog Style" notes are critical. The example code (closing the dialog form explicitly) should be used every time a form is opened as Dialog.

-- tom

[Ray in Capetown]

Re: Zooming to Record from Browse

Tom are you simply assuming that John with minimum 7 years experience with A5 and running forms as dialog hasn't yet read the instructions for using that option.
I presume the opposite and that the reliability issue is relating to the code being used and not leaving forms open.
That using
getrecordnum = a5_eval_expression("=recno(\"rcardetail\")")
will expose one to that kind of event (where for whatever reason, there is more than one copy of the form open)

[Tom Cone Jr]

Re: Zooming to Record from Browse

Ray,

I know nothing about John's experience, and certainly did not mean to offend.

The code John posted at the beginning of the thread omitted a vital statement, closing the dialog form. His script, as displayed for us, was dangerously incomplete. I was simply trying to help, did not mean to imply that closing the open dialog form was responsible for his troubles. To may way of thinking he had two problems. One he knew about, and one he apparently did not. Your criticism of my efforts illustrates again the oft quoted principle that no good deed ever goes unpunished.

I won't bother to respond further.

[Ray in Capetown]

Re: Zooming to Record from Browse

Tom you are the standards setter and stickler to good practices and he who goes the extra mile to help, never ever even suspect any offense taken on my part.
I feel comfortable enough through many years of communications with you on and off the board to challenge. I hope not to offend you.
The intention was to not underrate a potential flaw in the actual code of John's that is a little subtle, if indeed John has still not resolved his issue.
I do tend to make a judgement on what level to reply to a poster based on what I know of their previous posts and failing that, the date of joining.
Respect

[johngtatp]

Re: Zooming to Record from Browse

Guys, can't we just get along. I appreciate both your comments and I know that after 20 years experience with alpha back to the DOS days, that I still know very little. I have learned everything from this board and my attempts to read the documentation. As most of you know I am a pilot by profession and although I can run he systems on a Gulfstream 550 Alpha still eludes me many times. Both Ray and Tom, I really appreciate your input over the years and it helps so much. I can't tellyou the satisfaction of having try to get something to work for two days and then being able to post something and actually getting some help.

I have been laid up the last couple of days with a severe bronchitis and I could not get to my computer to try some of your suggestions. I know I close the form from the form itself but I am not sure of the methodology besides a regular form close. I know if the user gets out of Alpha and gets back in the problem clears itself. I am double-clicking from a browse which should guarantee me the proper recno , But I think I see your point that perhaps if another form is open it may not be going to the record number on that particular form but on another that maybe hidden. Unfortunately, I am out this week but really want to fix this issue. My users get to suffer while I enjoy Christmas. Thank you both again very much, And I hope you have a happy holiday.

[Ray in Capetown]

Re: Zooming to Record from Browse

Immediately following the "sptr.show()" statement the dialog has been hidden. If you want code access to the hidden dialog you have, until you close it with
"sptr.close()"

[martinwcole]

Re: Zooming to Record from Browse

here is something simple
in the browse, where you are on the row containing the record for which you want to open the form
dim global rnum as n
t=table.current()
rnum=t.recno()
f=form.viewqueried("the form name","recno=var->rnum","","dialog")
f.close()

[johngtatp]

Re: Zooming to Record from Browse

Martin, I tried your code but got a field does not exist.

Ray, I was closing the dialog form with a parentform.close() from the dialog that opened. I never noticed it until I had a tabbed display that the form was still open and I suspect as you all have suggested that this is the culprit. If I add sptr.close() in the onrowdoubleclick event, it indeed lets me manipulate the form which I still close and then when control is returned to the main form with the browse, the form is really "closed" and does not appear in a tab. I never knew that using .close() right after a .show() would not close the from right away. It makes sense given it is a dialog. I learn every day. I think this will fix the problem but time will tell. Thanks all.

[martinwcole]

Re: Zooming to Record from Browse

should have been:

f=form.viewqueried("the form name","recno()=var->rnum","","dialog")
f.close()

[johngtatp]

Re: Zooming to Record from Browse

Martin,

Thanks, I tried that but did not get a window to open. I will play with it some more. What do you think about the methodology of the two. They are similar, and I will have to see which one is faster.