Function and Query

[DaveM]

Thanks in advance for the help.

We all know that a query is my worst subject. I get query cannot be used in this manner. I also get an error on var->myfname

function scheckrtf as c(mytable as c, myrecnme as c, myfname as c)
dim shared mytext as c
dim thetext as c
dim t as P
dim ti as P
t = table.open(var->mytable,FILE_RW_SHARED)
query.filter = "file_num = var->myrecnme"
t.query_create()
thetext = RTF_FIELD_TO_TEXT(var->myfname)
ti = a5_spellcheckstring(var->thetext,"text","rtf",.t.)
t.change_begin()
 t.field_blank(var->myfname)
t.change_end()
var->mytext = alltrim(ti.text)
if ti.CorrectionsMade = .f. then
end
end if
INSERT_TEXT_IN_RTF_MEMO(t, var->myfname,var->mytext,1,"arial,9","black")
t.close()
end function

errornew.png

[Stan Mathews]

Re: Function and Query

First glance

mytable as c, myrecnme as c, myfname as c

these are parameters, not variables
t = table.open(mytable,FILE_RW_SHARED)
query.filter = "file_num = "+quote(myrecnme)

etc.

[Tom Cone Jr]

Re: Function and Query

Dave,

I think you can strip out "var->" throughout the script. Can't see why they're necessary.

Also, since the "query" object is global a better practice is to set or clear "query.options" each time query_create() method is called.

[DaveM]

Re: Function and Query

Thanks Stan and Tom.

I have been doing this for a month or so, but decided to turn it into a function because I still have a number of places for it to go. More efficiency??
I did 3 the old way, but there are 35 needs.
My biggest error was myfname, I was sending the contents rather than the name of the field.

I had stayed up late last night and got it working, now to clean it up and do as Tom suggested.

Stan, I had figured that out about 3:00 am. Thanks!!

Once I get it complete, I will post the notated results back to here so others may benefit.

[Al Buchholz]

Re: Function and Query

Dave

Is file_num numeric or character? The num implies numeric to me..

Here are some techniques to put variables into a string - which your filter is..
(I've placed these links to functions in the order of the version of Alpha that they appeared in...)

REPLACE_PARAMETERS v5

REPLACE_VARIABLES_IN_STRING v6

EVALUATE_STRING v8

CompileStringTemplate v9

[DaveM]

Re: Function and Query

Al, it is character and is the same type and name across all the tables file_num, c, 15. Values are different of course all the tables have that as an index as well.
the table name and rtfmemo field names do change.

The help file gave me a query filter that did not work. I looked up another one I did a year ago and modified to match, then Stan gave me the same one.

[Stan Mathews]

Re: Function and Query

query.filter = "file_num = var->myrecnme"

Think of the filter you would use in a report.

file_num = "Dave"
quote it
"file_num = "var->myrecnme""
replace the static Dave with the variable
modify so you don't have quotes within quotes
"file_num = \""+var->myrecnme+"\""
or
"file_num = "+quote(var->myrecnme)

[DaveM]

Re: Function and Query

Thanks, Stan.

[DaveM]

Re: Function and Query

This is working well for me

 

' used for records with a index select character

function scheckrtf as C (mytable as c, myrecnme as c, myfname as c)
dim qry as P
dim shared mytext as c
dim thetext as c
dim t as P
dim ti as P

t = table.open(var->mytable,FILE_RW_SHARED)
query.filter = "file_num=" +quote(trim(var->myrecnme))
query.order="" ' Get into variables the permissions for the users.  Most stuff in here will be based on this.  They will only be able to go and do if the permissions they have allow ir
query.options="T" ' like to see the control pane, they will need ecp set to .t., otherwise they can push the button all day and nothing happens.
qry = t.query_create()
thetext = RTF_FIELD_TO_TEXT(var->myfname)
ti = a5_spellcheckstring(var->thetext,"text","rtf",.t.)

if ti.CorrectionsMade = .t. then
t.change_begin()
	t.field_blank(var->myfname)
t.change_end()
var->mytext = alltrim(ti.text)
INSERT_TEXT_IN_RTF_MEMO(t, var->myfname,var->mytext,1,"arial,9","black")
end if
t.query_detach_all()
t.close()
end function

[Stan Mathews]

Re: Function and Query

Must be a lot of flexibility built into the Alpha handling of udf's.

No reason to reference function parameters with the var-> prefix, though it doesn't seem to throw an error.

mystring = "one two three"


tst =  up_first_word(mystring)
function up_first_word as C (mystring as C)
up_first_word = f_upper(mystring)
end function

? tst
= "One two three"

Then there's the possibility

dim global mystring as C
mystring = "one two three"

tst =  up_first_word("down by the river")
function up_first_word as C (mystring as C)
up_first_word = f_upper(mystring)
end function

? tst
= "Down by the river"

dim global mystring as C
mystring = "one two three"

tst =  up_first_word("down by the river")
function up_first_word as C (mystring as C)
up_first_word = f_upper(var->mystring)
end function

? tst
= "Down by the river"

dim global mystring as C [COLOR="#0000FF"]'try to force variable use in function[/COLOR]
mystring = "one two three"

tst =  up_first_word("down by the river")
function up_first_word as C (mystring as C)
dim global mystring as C [COLOR="#0000FF"]'try to force variable use in function[/COLOR]
up_first_word = f_upper(var->mystring)
end function

? tst
= "Down by the river"

[DaveM]

Re: Function and Query

Stan, I have been in the habit of the var-> for so long, it is not funny. It was always due to errors that seemed to get corrected by having it.

You are right about not needing them.