add_bus_days Function

[Tom Henkel]

I found an issue with this function. I'm hoping someone else can verify.

We have our own internal holiday calendar that we update yearly with our appropriate holiday.

in the add_bus_days() function, there is a parameter that you can specify to use your own calendar instead if the one set up in view->settings->holidays.


we have a form with a calculated field (fd_deadline) that is supposed to be 5 business days after the final decision date (Final_Dec)
THIS IS THE CODE I AM USING:

fd_Deadline = if(Final_Dec_Recd<>{},add_bus_days(Final_Dec_Recd,5,"N""\\cosmo\a5share\bcbss\holiday_lkup.dbf"),{})

and the error we are getting on a runtime machine without the "a_holidays.dbf" set up

error.jpg

If I add even 1 date to the Holidays table in settings, the error does NOT appear.

To me this looks like a bug, but I would like someone else to verify before submitting a bug report.

Thanks,

Tom

[Stan Mathews]

Re: add_bus_days Function

Probably a typo but your code as posted is missing a comma between "N" and "\\.......

[Tom Henkel]

Re: add_bus_days Function

Stan,

Thanks, your eyes are better than mine. THAT was the issue. Since there was no comma, then the parameter defining the table didn't exist. DUHHH!
With the comma where it belongs, the function works as expected.

Tom

[Stan Mathews]

Re: add_bus_days Function

The function should have errored due to the adjacent quotes so I think there is an internal bug in its error checking.

"N""\\cosmo\a5share\bcbss\holiday_lkup.dbf"

Should not be a valid value for the Ignore_Holiday_Flag parameter. Usually one gets an "Invalid characters at end of expression" notice.

[Tom Henkel]

Re: add_bus_days Function

probably so, but it didn't error out in the expression builder.

calc_expression.jpg

THAT may actually be the real bug.

Again, Stan, thanks for the extra set of eyes...

Tom

[GGandhi]

Re: add_bus_days Function

sorry to intrude:

THAT may actually be the real bug.

i am not sure it is a bug, but you both are more experienced than i.
the expression is still at the flag for to ignore the holidays or not. the expression if empty then it will ignore , the whole expression
"N""\\cosmo\a5share\bcbss\holiday_lkup.dbf"
is still being considered for the flag as you can see it searched for the default holiday dbf and reports it did not find it.
while it could be a real bug, but the alpha interpreter is looking for "yes" or (default) "" and since it is not an empty expression - the default it took as yes and looked for the default holiday dbf.

when I run this in the interactive window no problem reported here:

dim dd as d
dd = date()
?dd
= {07/01/2016}

?add_bus_days(dd,1,"N""i don't really have a holiday dbf")
= {07/04/2016}


?add_bus_days(dd,1)
= {07/04/2016}

?dd
= {07/01/2016}

dim date2 as d
date2 = if(dd<>{},add_bus_days(dd,1,"This is not "" the correct holiday dbf"),{})
?date2
= {07/04/2016}
does not look for the default holiday dbf!

strange, right.

the expression:
Final_Dec_Recd,5,"N""\\cosmo\a5share\bcbss\holiday_lkup.dbf" is just equal to
Final_Dec_Recd,5,"N\\cosmo\a5share\bcbss\holiday_lkup.dbf"