Change Fieldnames Code not working

[David Boomer]

I am trying to change fieldnames in a table... the following code displays the ui_msg_box() correctly... I get no error message, but the field names are not changed... I get no error message

dim TblXtab As P
dim Old_Fields As C
dim new_names As C
dim TableName As C
TableName = A5.GET_PATH()+ "\XtabConsultCredit.dbf"
TblXtab = Table.open(TableName)
Old_Fields = TblXtab.field_name_get() 'This will get a CRLF list of the names of the fieldNmaes from yearStart = year(date())-3 to year(Date()) eg if this year is 2017 --> 2014, 2015, 2016, 2017
TblXtab.close()
ui_msg_box("OLD FIELDS",Old_Fields,UI_INFORMATION_SYMBOL+UI_OK)
new_names = "Month" + crlf() + "YearMinus3" + crlf()+ "YearMinus2" + crlf() + "YearMinus1" + crlf() + "Year"
ui_msg_box("NEW FIELDS",new_names,UI_INFORMATION_SYMBOL+UI_OK)
TABLE.FIELDNAME_CHANGE( TableName, "Old_Fields", "new_names" )

Please advise.

[GGandhi]

Re: Change Fieldnames Code not working

TABLE.FIELDNAME_CHANGE( TableName, "Old_Fields", "new_names" )

instead try this
TABLE.FIELDNAME_CHANGE( TableName, Old_Fields, new_names )

edit:

do you need to open and close the table, is that not correct the table.field_name_get() will do that for you as well as table.fieldname_change()?

[Stan Mathews]

Re: Change Fieldnames Code not working

This is correct.

TABLE.FIELDNAME_CHANGE( TableName, Old_Fields, new_names )

This is not.

is that not correct the table.field_name_get() will do that for you

There is no table.field_name_get(), the method requires that a table pointer be obtained first and used.

There is table.external_field_name_get(TableName,"n")

[GGandhi]

Re: Change Fieldnames Code not working

stan
as usual you are right, i read my code i did open the table. and closed it. so the edit is not correct.

[David Boomer]

Re: Change Fieldnames Code not working

Thanks Gandhi and Stan...

The quotes were the problem... it was 5 AM and I may have been less alert than I would have liked :-)

Code that works:

dim TblXtab As P
dim Old_Fields As C
dim new_names As C
dim TableName As C
TableName = A5.GET_PATH()+ "\XtabConsultCredit.dbf"
TblXtab = Table.open(TableName)
Old_Fields = TblXtab.field_name_get() 'This will get a CRLF list of the names of the fieldNmaes from yearStart = year(date())-3 to year(Date()) eg if this year is 2017 --> 2014, 2015, 2016, 2017
TblXtab.close()
ui_msg_box("OLD FIELDS",Old_Fields,UI_INFORMATION_SYMBOL+UI_OK)
new_names = "Month" + crlf() + "YearMinus3" + crlf()+ "YearMinus2" + crlf() + "YearMinus1" + crlf() + "Year"
ui_msg_box("NEW FIELDS",new_names,UI_INFORMATION_SYMBOL+UI_OK)
TABLE.FIELDNAME_CHANGE( TableName, Old_Fields, new_names )