Multiple form instances being created with log on/off routine

[Scott Kurimski]

I have a "log on/off" routine that can be run from a button on every form in my application. I am having an issue with the routine opening up multiple instances of my Main_Menu form if I repeat the logon process multiple times while I am on the Main_Menu form when launching the routine.

The Log On/Off process .....
1. Closes the current form with - parentform.close(.f.)
2. Sets a couple of global variables
3. Open the Main_Menu form with
form.view(vCenterForm, "", "", "center", "center")
Note: vCenterForm is set to Main_Menu in this case

I wanted to make the process run the same no matter what form the user is on, so I always close the parent form first.

The issue I have is that if I am on the Main_Menu form when I run the script it closes the Main_Menu and reopens it as Main_Menu0 (a zero is placed after Main_Menu). If I repeat the logon process while on the Main_Menu form it cycles the open form name between Main_Menu and Main_Menu0

I know I am leaving out a lot of details although I believe my problem is geared around the way I am closing and opening the forms.

Any ideas?

Let me know what additional information would be needed or helpful.

[Tom Cone Jr]

Re: Multiple form instances being created with log on/off routine

May I ask what useful purpose is served by having the button on your Main_menu form ? If I were you I'd have a second script that is used only on your Main_menu form.

[Scott Kurimski]

Re: Multiple form instances being created with log on/off routine

The purpose of the Log on/Off option being on any form is because we use "Shared" workstations and will be allowing users to walk up to the machine and Log On from wherever they are in the application.

Why would the process matter if I am closing the form before using the form.view command?

[Peter.Greulich]

Re: Multiple form instances being created with log on/off routine

Why would the process matter if I am closing the form before using the form.view command?

It probably doesn't matter.

Try this:

IF is_object("Main_Menu")
    Main_Menu.show()
    Main_Menu.activate()
ELSE
    :Form.view("Main_Menu","","","center","Center")
END IF

[Tom Cone Jr]

Re: Multiple form instances being created with log on/off routine

I suspect your script is running to conclusion before the Main_menu form is completely closed. After all, the script itself is running in the form's space in memory, right? I asked about the purpose because you may be able to achieve your goal by keeping the form open, while still doing the necessary processing you require. Have you found its necessary to close the form in order to log in a new user?

[Scott Kurimski]

Re: Multiple form instances being created with log on/off routine

I close forms so the interface is very simple for the user and there would only be one tab showing (lower left) is Alpha at any one point in time. I was having refresh issues with global variables on the form and found if the form was closed and reopened the always updated appropriately. It looks like closing the form is causing other issues as well.

Can I hide the form and accomplish the same results? I assume it would make it faster to respond in the long run becuase it would not have to reopen the forms each time I wanted to access them?

What would the proper process be to refresh the parent form after the Log on/off script has run? I want to make it so no matter what form they are on it is closed or hidden and they are returned to the Main_Menu form.

Interestingly enough, I commented out parentform.close(.f.) and used Peters code from the previous post although when I am not on the Main_Menu form it does not open the Main_Menu form again although I think it may be a refresh issue. What is the command to refresh/repaint the screen no matter where you are at?

[Tom Cone Jr]

Re: Multiple form instances being created with log on/off routine

Have you decided not to use

A5_ChangeLoggedOnUser()

?

-- tom

[Scott Kurimski]

Re: Multiple form instances being created with log on/off routine

I am not using Alpha's built in security.

[Tom Cone Jr]

Re: Multiple form instances being created with log on/off routine

Ok. I see now why you're in this box. Will ponder.

Is the main_menu form based on a dummy table?

[Scott Kurimski]

Re: Multiple form instances being created with log on/off routine

Yes, the table is called startup.

[Scott Kurimski]

Re: Multiple form instances being created with log on/off routine

Tom,

Just in case it is helpful I am posting the Log On/Off code I have to date so you can see what I am doing. The code below works as expected except for the original issue regarding opening up multiple instances of the form when run from the Main_Menu form.

DIM GLOBAL gvModuleName as C
DIM GLOBAL gvuser as C
DIM GLOBAL gvEmpName as C
DIM GLOBAL gvEmpid as C
DIM GLOBAL gvLogOnOff as C

DIM SHARED vuserpass as C
DIM SHARED varC_result as C
DIM SHARED vCenterForm as C
DIM vuserfound as C

'Change Title to "Log On As" and refresh parent layout
gvModuleName = "Log On As"

'Blank the Username and Password
gvuser=""
vuserpass=""

'Change the Employee Name to "No Employee"
gvEmpName="No Employee"

'Set Log_On_Off button text to "Log On"
gvLogOnOff = "Log On"
Log_On_Off.text = gvLogOnOff

'Refresh Main Menu
topparent.Repaint()

'---------------
Retry_here:
'---------------
ok_button_label = "&Log On"
'cancel_button_label = "&Cancel"
varC_result = ui_dlg_box("EIM Track",<<%dlg%
{font=Arial,10}
{frame=1,1:Enter your Username and Password:}
{region}
{lf};
Username:| [.40gvuser];
Password:| [%p%.40vuserpass];
{lf};
{endregion};
{lf};
{region}
{justify=right}
<*15=ok_button_label!Log On*?>
{endregion};
%dlg%)

IF varC_result = "Log On"
' Get data from Employee Master file to verify password - make one text string that has both values and then parse it out below
' Lookup the records for the matching username and password
lres = lookupc("F",alltrim(gvuser),"alltrim(emplognid)+' -- '+alltrim(emppass)",a5.Get_Path()+"\emp.dbf","_emplognid")
vuserfound = word(lres,1," -- ")
vpassfound = word(lres,2," -- ")

'Compare user name entered to that in the Employee Master file (found with lookupc above)
IF alltrim(lower(gvuser)) = alltrim(lower(vuserfound))
'Name matches - now look at the password for a match

IF alltrim(lower(vuserpass)) = alltrim(lower(vpassfound)) ' Password matches too
gvuser = alltrim(lower(gvuser))

'Clear vuserpass variable
vuserpass = ""

'Close the current form
parentform.close(.f.)

'Set a Global Variable containing the Employees full name
gvEmpName = lookupc("F", gvuser, "alltrim(Empfname)+' '+ alltrim(Emplname)", "emp","_Emplognid")

'Set a Global Variable containing the Employees ID Number
gvEmpid = lookupc("F", gvuser, "alltrim(Empid)", "emp","_Emplognid")

'Set a Global Variable containing the current module name
gvModuleName = "Main Menu"

'Form Name to Center when opening
vCenterForm = "Main_Menu"

'Set Log_On_Off button text to "Log Off"
gvLogOnOff = "Log Off"
Log_On_Off.text = gvLogOnOff

'Loads the Main Menu
form.view(vCenterForm, "", "", "center", "center")

'Refresh Main Menu
topparent.Repaint()
END'
ELSE
'Password does not match - try again
ui_msg_box("Password Error!","Password entered is incorrect.",UI_STOP_SYMBOL)

'Clear vuserpass variable
vuserpass = ""
GOTO retry_here
END IF

ELSE 'User Name is wrong - this is from first IF statement
ui_msg_box("User Name Not Found","The User Name you entered could not be found",UI_STOP_SYMBOL)
gvuser = ""
vuserpass = ""
GOTO Retry_here
END IF
END IF

[Tom Cone Jr]

Re: Multiple form instances being created with log on/off routine

Ok. I'm back to my original question. Why close the main_menu form?

[Scott Kurimski]

Re: Multiple form instances being created with log on/off routine

Ok. I'm back to my original question. Why close the main_menu form?

Reduces the number of tabs open and I was having issues with the screen not refreshing/repainting.

[Tom Cone Jr]

Re: Multiple form instances being created with log on/off routine

It seems to me that your script could determine if it were running in the main_menu form or not. If it is not, then let the script close the parentform. If it is running in the main_menu form there should be no reason to open and close it. Right?

later edit...

parentform.name()

will return the name of the form within which you button lives.

[Scott Kurimski]

Re: Multiple form instances being created with log on/off routine

Correct, there would be no need to close and open the form if it was already on the Main_Menu form although I would need to refresh it so we can see the changes to the variables.

I was not able to get the IS_Object() function to work properly as Peter suggested earlier.

Being new to Xbasic I am still struggling with the correct syntax to do everything you mentioned. Can you provide an examples based on the code I listed previously?