How to delete?

[gskelton]

V10 2814-2539

I have a set based on a Customer table linked to a Repair_invoice table by customer_id with a one to many link. The Repair_invoice table is linked to a Repair_item table by invoice_number with a one to many link set with referential integerity to cascade changes and deletes.
On my form based on this set I have a button to delete an invoice that I have selected.
When I delete Invoice number say TEST1 it is deleted as expected. But when I open a default browse of the repair_item table, TEST1 is still there. TEST1 is gone in the default browse of the Repair_Invoice table.
I guess my question is: I thought referential integerity was supposed to delete child records when the record was deleted in the parent, and if not what is the best way to set up a button to delete all the repair_items linked to the deleted invoice_number besides manually opening the default browse and deleting them?

[Tbaker]

Re: How to delete?

Garry

I created a sample app based on your specifications (I think).

I have a parent with a child (recent_work) 1:M no referential integrity, Recent_work then has a child(repairs) 1:M with referential integrity (cascading deletes).

There is a button on the form to delete the highlighted record in the recent_work browse (browse1). When you push the button the invoice is deleted from Recent_work and it relations with the child (repairs) the invoice number is also deleted.

The set in this case is called Testing 1. Look at how the set is set up - see if it is like your set. (set up the same way or what did I do differently)

By the way you are working with an older release (nothing wrong with that if everything is working okay - I tried the app with the release you are working with and it still worked okay.

Tom

[gskelton]

Re: How to delete?

Thanks Tbaker, what you sent me is exactly what I have. Only difference, yours does what it's suppose to and mine don't. When I deleted an invoice on your form and then went to the default browse of the repair table they were deleted like I thought they should be using cascade changes and deletes.
My set is configured exactly the same as yours and my delete button has the same action script but my repair items are not being deleted in the repair item table. I did however notice and this is strange, if I open the set up in the default browse the repair items are deleted there.

[Tbaker]

Re: How to delete?

Garry

Can you post a sample so we can get a look to see what is causing this.

Tom

edit:
As far as opening the default browse for the set, if the invoice numbers were deleted in the Repair_invoice table and still existed in the repair_items table, they would not show up on the default browse for the set since there would be no link to the repair items table. But they could still be in the repair items table.

[Tom Cone Jr]

Re: How to delete?

Please clarify. Are you saying the child is being deleted but the grandchild is not, or are there two child tables? A sample of your database would help us understand what you have.

[gskelton]

Re: How to delete?

Here is my db, be merciful this is my one and only attempt at a database I use at work to track sales and repairs at a small mom and pop furniture store where I do the tv and appliance repair.

First, if you want, you can click the Enter Repair button on the menu then find some customer ,just remember their name, and enter a repair invoice you can remember. Then from the menu go to View Sales and Repairs and lookup that customer. The repairs are at the bottom. Delete the repair, then goto the repair_item table and the invoice is still there.

[Tbaker]

Re: How to delete?

Garry

Edit - Garry read the edit at the bottom of this post

I have gone over your set and the form and your set is set up correctly.

I have come to the conclusion it is the build your are using - 2814-2539 that is causing the problem.

I tried your app in that build on my machine and it does the same thing - pushing the button deletes the repair invoice number but does not delete the repair items associated with that invoice number.

I have tried it with build 3040-3571 and build 3272-3589 and it works every time - the only thing is there is a refresh problem with the repair-items browse after the delete, the records still show in the repair items browse until you shift to another record and then come back - at that time the browse refreshes and the records are no longer there.

I would suggest that you update your version to a newer build perhaps 3040-3571 or the 3272-2589 the next to last update (update of Sept 03 2010.

I will try using xbasic to delete the invoice in the repair invoice browse which will allow the refreshing of browse4 and browse3. Hopefully, it can be accomplished.

I could not see anything wrong with the set with the exception when using a version of 10.5, with the new xbasic set editor, there was a box checked in the repair-items set properties to be case sensitive - I unchecked that box. Why it was there I don't know, since when in 2814-2539 (which uses the old set editor) there were no boxes to check for case senstive.

Tom Baker

Edit

I did a little more investigating. I went back to the build you are using 2814-2539 and changed the code behind the delete repair button in the repair invoice to xbasic and then put in the following code

dim res as n
dim tbl as p

res=msgbox("Caution","Do You really want to delete this record?",UI_QUESTION_SYMBOL+UI_YES_NO)
	if res=ui_no_selected then
	    cancel()
	    end 
	end if


tbl=table.get("repair invoice")
	tbl.change_begin()
	tbl.delete()
	tbl.change_end(.t.)
	
parentform:cond1.refresh()
parentform:browse3.activate()
parentform:browse3.refresh()
parentform.Refresh_Layout()

I then opened the View Sales and Repairs form, and deleted an invoice using the new code behind the Delete Repair button, and it deleted the record in the repair invoice browse as well as in the repair items.

I have revised the zip file you sent me with the above code. Don't update yet, try this one using you current build 2814-2539.

Tom

[Tbaker]

Re: How to delete?

Here is the latest on this - Garry was using build 2814-2539 of V10. In reading the release notes for the next update after that build - one of the bugs that was fixed was Set Referentail Integrity and cascading deletes that were not working properly.

The code that I provided in the button on the repair_invoice form, did work sometime but not all the time - it was hit or miss (however, it did solve the refresh problem that I saw when deleting the records in the browse).

The outcome was to update to a later patch (update) to overcome the cacading deletes problem.

Just wanted to post this for future reference to future readers of this post.

Tom Baker