Why does my code still process records when the status field is false?

[Tanman]

In my script I have added in a code that should evaluate whether the status is true or false.... and then adds a record to the transaction record if the status is true.

I did a test and changed all records to status f to see if the script would work as expected.

It skips the first record but it adds records while it continues the while function.

Does anyone see where I am going wrong? I have attached the database training database.zip

many thanks,

[code]
'Date Created: 06-Aug-2011 11:04:27 PM
'Last Updated: 09-Aug-2011 12:27:57 AM
'Created By : weiyentan
'Updated By : weiyentan
'This script goes thru all the contacts and enters the contact id to the transaction table.
dim contacttbl as p
dim transtbl as p

contacttbl = table.open("contact")
transtbl = table.open("transactions")


if exist(year(now()),"transactions","Transyd")
ui_msg_box("Rollover","The subscription , Please add transactions manually. ", UI_STOP_SYMBOL)
end if


contacttbl.fetch_first()

WHILE .not. contacttbl.fetch_eof()
if contacttbl.status = .f. then
contacttbl.fetch_next()
end if
SELECT
CASE contacttbl.type = "Client"
transtbl.enter_begin()
transtbl.date =date()
transtbl.contactid = contacttbl.contactid
transtbl.description = "Subscription Fee"
transtbl.flddebit = 50
transtbl.enter_end(.T.)
CASE contacttbl.type = "Supplier"
transtbl.enter_begin()
transtbl.date =date()
transtbl.contactid = contacttbl.contactid
transtbl.fldcredit = 100
transtbl.description = "Invoice"
transtbl.enter_end(.T.)



END SELECT
contacttbl.fetch_next()
END WHILE
transtbl.batch_end()
transtbl.close()
contacttbl.close()

[Stan Mathews]

Re: Why does my code still process records when the status field is false?

I think the while loop should look like this.

WHILE .not. contacttbl.fetch_eof()
	IF contacttbl.status = .f. THEN
		'do nothing
	ELSE
		SELECT
			CASE contacttbl.type = "Client"
				transtbl.enter_begin()
				transtbl.date =date()
				transtbl.contactid = contacttbl.contactid
				transtbl.description = "Subscription Fee"
				transtbl.flddebit = 50
				transtbl.enter_end(.T.)
			CASE contacttbl.type = "Supplier"
				transtbl.enter_begin()
				transtbl.date =date()
				transtbl.contactid = contacttbl.contactid
				transtbl.fldcredit = 100
				transtbl.description = "Invoice"
				transtbl.enter_end(.T.)
		END SELECT
	END IF
	contacttbl.fetch_next()
END WHILE

[Peter.Greulich]

Re: Why does my code still process records when the status field is false?

You might also want to make this change, if I understand your message:

IF exist(year(now()),"transactions","Transyd")
	ui_msg_box("Rollover","The subscription , Please add transactions manually. ", UI_STOP_SYMBOL)
	[B][COLOR="#FF0000"]END[/COLOR][/B]
END IF

[G Gabriel]

Re: Why does my code still process records when the status field is false?

I did a test and changed all records to status f to see if the script would work as expected.
It skips the first record but it adds records while it continues the while function.

Yes.. it will do that.
Your script goes to the first record, tests the field "status", if it is false it moves to the next record and runs the select code then moves to the next record, i.e. you run through 3 records in the first loop then you run through 2 records in each loop thereafter. If the status is true, the select code runs on the current record then goes to the next one. Perhaps all this forensics is not required but then again maybe it helps understand why your code does not work the way you want. The fix is very simple:

ontacttbl.fetch_first()
WHILE .not. contacttbl.fetch_eof()
[COLOR=#ff0000][B]if contacttbl.status = .T. then[/B][/COLOR]
 SELECT
CASE contacttbl.type = "Client"
transtbl.enter_begin()
transtbl.date =date()
transtbl.contactid = contacttbl.contactid
transtbl.description = "Subscription Fee"
transtbl.flddebit = 50
transtbl.enter_end(.T.)
CASE contacttbl.type = "Supplier"
transtbl.enter_begin()
transtbl.date =date()
transtbl.contactid = contacttbl.contactid
transtbl.fldcredit = 100
transtbl.description = "Invoice"
transtbl.enter_end(.T.)
END SELECT
[COLOR=#ff0000]end if[/COLOR]
contacttbl.fetch_next()
END WHILE
transtbl.batch_end()
transtbl.close()
contacttbl.close()

That said, I am not sure of the big picture? You are looking to see if a year exists...in what? In each member? In general?
Obviously the answer depends on what the index is made of.
Furthermore, if exist() will negate the need for updating the transaction table, I wouldn't open it in the outset.

[Stan Mathews]

Re: Why does my code still process records when the status field is false?

You might also want to make this change, if I understand your message:

IF exist(year(now()),"transactions","Transyd")
	ui_msg_box("Rollover","The subscription , Please add transactions manually. ", UI_STOP_SYMBOL)
	[B][COLOR="#FF0000"]END[/COLOR][/B]
END IF

Good eye, Peter. That was the way it was in his prior development.

[Tanman]

Re: Why does my code still process records when the status field is false?

Thanks all.

I will try out all those suggestions at home. I think g Gabriel is on the right path.

I think it's a matter of getting the right logic!!

Once again thanks!