Problem calling form in dialog mode

[Nick Oldfield]

I have code that runs on a button from a form (let's call it form A) that is comparing data from a quickbooks import with data in anothe alpha table. The code calls form B in dialog mode, hidden, then I set some fields on the form with data from the quickbooks import, and then activate the form and then show it, because I need the user to process form B before continuing with the script on form A. The script on form A is actually a while loop, that goes back and gets the next record from the import table.
I noticed that form B was not actually being closed by the "close" command on form B's "close" button, although the script on form A does continue when you return from form B.
After investigation, I found this thread http://msgboard.alphasoftware.com/al...ing+modal+form on the message board, talking about the same issue. It was pointed out that you had to close form B a 'second" time, in the code on the calling form (A), otherwise form B was still in memory. Still not quite sure why that is, but none the less I added code to form A as suggested in the thread, to close form B, in the script on form A where it resumes once you return from form B, and that closes the form successfully.
So far so good. But the problem is, when I call form B again from my "while" loop, to process the next record from the import table, it does not open properly - I open the form again, using completely standard code for opening a form in dialog mode, but the pointer to the form object is blank.

I won't have time to develop a postable version of the code until the weekend, but I wondered if anyone could respond with any idea what is wrong.

[Nick Oldfield]

Re: Problem calling form in dialog mode

OK, attached is a test application.
When I run the Parts Import form, and push the Check Import button, the application checks to see if the item in the import table is aready in the stock table and if not, it displays a form (enter new item) in dialog mode so I can accept the item into stock, decide not to (by using the red X), or edit it and then save it in the stock table. When the script on the "check import" button resumes, it closes the form so it is removed from memory, and then returns to check the next item.
But when it goes to open the "enter new item" form again, something seems to be left in memory, because it opens another version of the form (enter new item0). Then as it processes each new item, it moves backward and forward between "enter new item" and "enter new item0".

Or am I missing something really obvious?

[Tim Kiebert]

Re: Problem calling form in dialog mode

Nick,

I see the same in your sample. It looks like a timing issue in that the new instance is being created before the first is destroyed. I tired putting a sleep(1) but nothing changed. Not sure how this affects your process but I rearranged your code a bit so form B doesn't close. It just gets hidden by the close of the red X or the save button and then gets redisplayed. After the loop if the form test as being there it is closed.

dim vform as P
dim qpoint as p
'and for the stock list
dim stockpoint as p
qpoint=table.open ("parts import")
stockpoint=table.open ("parts in stock")
qpoint.fetch_first()
WHILE .not.qpoint.fetch_eof()
	'lets see if the item is already in the stock list
	indx=qpoint.item_code
	stockpoint.index_primary_put("Item_Code")
	value=stockpoint.fetch_find (indx)
	IF value>0 THEN
		'item already exists in stock so do nothing
	ELSE
		'this is a new item so create it
		'open a form so we can edit the info
		
		If .not. is_object(vform)
			vform = :Form.load("enter new item","dialog")
		end if
		vform.new_record()
		
		'now lets enter the import item data in the form
		vform:source.text=qpoint.source
		vform:description.text=qpoint.description
		vform:part_number.text=qpoint.part_number
		vform:item_code.text=qpoint.item_code
		
		'now show the form
		vform.show()
		'script should resume here when form
		' is closed on the form itself
		'close the form to remove it from memory
		'vform.hide()
	END IF
	qpoint.fetch_next()
END WHILE
if is_object(vform) then
    vform.close()
end if
qpoint.close()
stockpoint.close()

[Nick Oldfield]

Re: Problem calling form in dialog mode

Thanks for the response.
I had also tried changing the timing with sleep commands but it did not change things. It looks like something remains set up in the background even when you close the form in the script, and then clears when the script terminates, which is why it was an issue closing the form in the loop. I'll report it as a probable bug anyway.
I tried your suggestion, avoiding the form close in the loop, and it worked perfectly. Thanks.