Toolbar help needed

[K2kcc]

Hi All,

I have a script that runs great by itself, in the autoexec or from a button on a form.

But......

When I use it on a button on a toolbar it fails. Why?

Here is what I'm using:

In the autoExec: script_play_local("CnCCal").......works

In a button on a form: script_play_local("CnCCal").......works

In a button on the toolbar: script_play_local("CnCCal").......Fail

Specifically I get this error:

Script: CncCal: Line:62
myendDate=names[x}.Shortedate+duration
names[x].Shortedate+duration:Argument is incorrect data type

Which refers to this part of the script:

for x=1 to arr_count
myendDate=names[x].cncdatea+duration
if names[x].tassigned = "custom" then
eventCol="blue"
end if
if names[x].tassigned = "cabinets" then
eventCol="green"
end if
if names[x].tassigned = "office" then
eventCol="orange"
end if
proname="-"+trim(lookupc("F",names[x].group_id,"jobname","sales","Group_Id"))
myname="{id: "+names[x].pnum+", text: "+"""+names[x].operation+proname+"""+",start_date: "+"""+date_format(names[x].cncdatea,"MM-dd-yyyy")+"""+", end_date: "+"""+date_format(myendDate,"MM-dd-yyyy")+"""+", color: "+"""+eventcol+"""+"},"+crlf()'names[x].Shipduration
longstring=longstring+myname
next x

I don't understand why the error when running from a toolbar button

Any help solving this would be appreciated.

Thank you

[Ronald Anusiewicz]

Re: Toolbar help needed

Didn't look at your code.
What I do sometimes, I put a button on a form and get the code behind the button working the way I want.

Then I get the object name of the button. In the code below, the button object name is: 'button8'

Then the code behind the toolbar button is:

parentform:button8.push()

Lastly, I hide the button on the form.

Hope this helps.

[K2kcc]

Re: Toolbar help needed

Hi Ron

Thank you for your reply.

I've found a work around similar to yours.

I created a blank form and run the script in the init event, then close the form in the same init event. The blank form is then called by the button on the toolbar. Works like a charm but I'd still like to know why the script wont run when called from the toolbar.

Thank you again for your reply

Regards

Keith

[MoGrace]

Re: Toolbar help needed

Syntax error:

Script: CncCal: Line:62
myendDate=names[x}.Shortedate+duration
names[x].Shortedate+duration:Argument is incorrect data type

[Al Buchholz]

Re: Toolbar help needed

The toolbar script doesn't run within the form.

You would have to check that the form is open and point to the objects on the form, or write the toolbar script to open the table(s), do the work, close the tables, and then refresh the form if the data being changed is showing on the form.

[K2kcc]

Re: Toolbar help needed

Hi Robin

Thank you for your reply.

Sorry that was a typo, it's correct in my application. the script runs great by itself, in the autoexec and from a form. Just doesn't want to run when called from a toolbar.

Thank you again for your reply

Regards,

Keith

[K2kcc]

Re: Toolbar help needed

Hi Al

The script I want to run is on a toolbar on a browse.

The blank form I created is on a blank table I use for misc forms.
I set the init event on the blank form to run the script, then close the form.

The button on the toolbar on the browse opens the blank form which triggers the script on the init event, then closes the form. Works great.

Thank you again for your reply.

Regards,

Keith

[G Gabriel]

Re: Toolbar help needed

In a button on the toolbar: script_play_local("CnCCal").......Fail

Instead try:

script_play("CnCCal")

[K2kcc]

Re: Toolbar help needed

Hi G Gabriel,

Thank you for your reply.

Tried that as well to no avail.

Regards,

Keith

[G Gabriel]

Re: Toolbar help needed

The issue about a script working from a button or on a form but not running from a toolbar is a pretty old one and has to do with the variables namespaces.
I didn't delve into your script, but an easy (not necessarily the best way) is to dim your variables in a broader scope: shared or global

[K2kcc]

Re: Toolbar help needed

Hi G Gabriel

Ok, I'll give that a try.

Thank you for your help

Regards,

Keith

[Al Buchholz]

Re: Toolbar help needed

You should write the code into a UDF (User Defined Function) and call the function from the toolbar.

If you make a function work from the interactive window without any forms being open, then it will run from a toolbar or an object.

When a script just won't due, wrap it in a function.

[G Gabriel]

Re: Toolbar help needed

Just a quick explanation as to the root of the problem:
1-The toolbar is nothing but an xdlg (a modeless xdlg to be exact)
2-When you put the script on a button on a form, all the variables on the form are available to the script on the button
3-But when you place your script in the toolbar, basically you took it out of the form and placed it in a different object, an xdlg (toolbar)
4-All the variables that are available to a button on the form, are not necessarily available to the xdlg (the toolbar) unless:
a-you make them available, i.e., by changing their scope say to global, OR,
b-by acquiring their values by pointing to their name space with a function like local_variables()

5-As Al suggested, you could use a function, BUT:
a-The function has to acquire these values in the form of parameters, or
b-If the function is global and the variables are global as well, it should work. Which is the same as dimming the variables in the form as global.
That's not my preferred choice, but a lot of people have trouble with local_variables(). Use what you are comfortable with.

[K2kcc]

Re: Toolbar help needed

Hi Al and G. Gabriel,

Thank you both for your help.

I'll be coming back to this problem this week and will certainly try both of your suggestions.


Thank you again for your help

Regards,

Keith