On_Key CLOSE problem.

[Zradene]

I have a problem when closing a form using On_Key that it crashes the application on occasions.
This happen only when using On_Key to press my CLOSE button.
Pressing the same CLOSE button with the mouse works perfectly without crashing ever!
All I have in action script is the following:-
Close Form/Browse
Open Form or Browse Layout

Any idea's guys ?

Thanks

[Tom Cone Jr]

Re: On_Key CLOSE problem.

Ideas to try:

1) move the button's onpush event code into your onKey event script;

2) open the next form before closing the current one

3) pay close attention to what's happening in the form when the script fails. Are unsaved edits pending? Have you use the debug() function to slow things down and observe what's happening more closely?

In my own work I often leave the "main menu" form running all the time. When I close a data entry form Alpha takes me back to the main menu automatically. No need to keep opening and closing the main menu form.

[Zradene]

Re: On_Key CLOSE problem.

Hi Tom, thanks for that mate.
Option No.2 works a treat.....
Seems an odd solution but it don't appear to crash anymore.

Many thanks

[Tom Cone Jr]

Re: On_Key CLOSE problem.

Closing the form may prevent the script from ending normally since the script lives in the form itself.

[G Gabriel]

Re: On_Key CLOSE problem.

What script are you using?

[Zradene]

Re: On_Key CLOSE problem.

Hi Gabriel, just using action script to Close Form / Browse and Open Form Browse.
The key to the crashing is dependent whether I have system menu's turned on in my forms.
The problems disappear if these menu's are visible, but I want a clean screen without these Menus.

It would certainly be great if you can find a permanent fix for this.
Doing as Tom suggested Opening a new form before closing the existing one seems to work, but always a worry that it still may crash.

[G Gabriel]

Re: On_Key CLOSE problem.

Which key triggers that button?
And what is the script?

[Zradene]

Re: On_Key CLOSE problem.

'Menu
IF a_user.key.value = "D"
a_user.key.handled=.t.
if a_user.key.event="down"
Exit.Push()
topparent.commit()
end
end if
end if

[G Gabriel]

Re: On_Key CLOSE problem.

What is the script on the button "Exit"? and what is the name? and the text of that button?
I could see from the above script that you had 2 lines upside down, but before making the correction, I would like to know the answer to the above.

[Zradene]

Re: On_Key CLOSE problem.

The button (object name) is called EXIT, the script is:-

'Close current form or browse window.
DIM mode as c
mode = parentform.mode_get()
'If the form is in Enter or Change mode, first save the changes before closing the form
if mode = "ENTER" .or. mode = "CHANGE" then
parentform.commit()
'Check to see if the record was successfully saved
if parentform.mode_get()<>"VIEW" then
ui_msg_box("Unable to save your changes","Please correct and save, or discard your changes", UI_STOP_SYMBOL)
end
end if
end if
'Close the form
parentform.close(.f.)

'Open a Form or Browse layout, displaying all, or selected records in the layout.

DIM Shared varP_MENU as P
DIM layout_name as c
layout_name = "MENU2"
DIM tempP as p
'Get pointer to existing window. In case layout_name is qualified with a dictionary name, extract up to first @. In case formname has spaces, normalize it
tempP=obj(":"+object_Name_normalize(word(layout_name,1,"@")))
'Test if pointer is valid
if is_object(tempP) then
'Test if pointer refers to a form or browse
if tempP.class() = "form" .or. tempP.class() = "browse" then
'If so, then activate the already open window
tempP.activate()

else
'Window is not already open, so open it
varP_MENU = :Form.view(layout_name)


end if
else
varP_MENU = :Form.view(layout_name)


end if

[G Gabriel]

Re: On_Key CLOSE problem.

Put this script on the Exit button:

DIM mode as c
mode = parentform.mode_get()
if parentform.mode_get()<>"VIEW" then
ui_msg_box("Unable to save your changes","Please correct and save, or discard your changes", UI_STOP_SYMBOL)
end
else
parentform.commit()
parentform.close()
end if

And this script on the OnKey:

 IF a_user.key.value = "D"
a_user.key.handled=.t.
if a_user.key.event="down"
Exit.Push()
end if 
end if

[Zradene]

Re: On_Key CLOSE problem.

Hey Gabriel, you have cracked it again !
Massive big thanks....

I don't know how you manage to resolve these problems, but I am most grateful.

This particular problem has been bugging me for months.

Best regards

[G Gabriel]

Re: On_Key CLOSE problem.

They come to me in a dream.
Glad to help.

[Zradene]

Re: On_Key CLOSE problem.

Thank you Gabriel.