Browse opening in specific location and failing to save data

[MikeData]

I have a basic process in which I would like to open a browse of another table from a button in this form.
I have attache a sample. describing the issues.
Issue 1
the option 3 button gives an erros upon saving
Issue 2 is bringing to front the opened browse.
Please advise.

[Tom Cone Jr]

Re: Browse opening in specific location and failing to save data

Concerning your 3rd button, the error is coming from the OnSave event in the called browse layout. (notes_browser3, I believe).

- your script there refers to the wrong layout
- your script there also refers to a variable that is not in scope. In the main menu form your button populates a local variable called Pick. then opens the called browse. you know of course that local variables in one form are not visible in other forms, right? change the scope of the variable PICK in both form and browse and you should be good to go, after you fix the OnSave event script to reference the right layout.

I believe I've referred you to the "Passing values between forms" examples in the Code Archive forum on earlier occasions, right? Might be time to review the examples again. This is a fundamental skill in building database applications with Alpha Five.

[Stan Mathews]

Re: Browse opening in specific location and failing to save data

Spent too long typing, basically the same response as Tom's.

Why do you think the browse filter

acc = Var->pick2

should know anything about the variable you defined on the button on the form?

pick2 = a5_eval_expression("=Accno")

Issue 2 is bringing to front the opened browse.

ptr.activate()

There seems to be something wrong with the action script on the browse onsave event. Remove that, switch to the cansave event, use inline xbasic

'Set properties of multiple objects in Browse 'Notes_Browse3' .
Dim global pick2 as C

Date.value = date()
Acc.value = var->pick2

[Finian Lennon]

Re: Browse opening in specific location and failing to save data

Mike:

Get rid of the OnSave event in notes_browse3 and make the form button code

dim ptr as P
ptr = browse.load("Notes_Browse3")
'ptr = browse.view("Notes_Browse3")
ptr.window_position("300", "50")
ptr.show()
ptr.activate()
ptr.new_record()
ptr:acc.value = pick2
ptr:date.value = Date()
ptr:note.activate()

then the user just needs to type the note and hit F9.

[MikeData]

Re: Browse opening in specific location and failing to save data

Thanks all for the responses.
Yes, the addition ptr.activate() did bring it to front.
The code change in the button #3 did all the work.
I did add the pick2 defintion to the code by Finnian as it was a global variable.

pick2 = a5_eval_expression("=Accno")

dim ptr as P
ptr = browse.load("Notes_Browse3")

ptr.window_position("300", "50")
ptr.show()
ptr.activate()
ptr.new_record()
ptr:acc.value = pick2
ptr:date.value = Date()
ptr:note.activate()
-----------------------------------
I have been using a form with a brosse built in it and the performance was erratic.
This will help me clean my code.

Thanks to all. Great.

[Finian Lennon]

Re: Browse opening in specific location and failing to save data

Mike:

Get rid of the OnSave event in notes_browse3 and make the form button code

dim ptr as P
ptr = browse.load("Notes_Browse3")
'ptr = browse.view("Notes_Browse3")
ptr.window_position("300", "50")
ptr.show()
ptr.activate()
ptr.new_record()
ptr:acc.value = pick2
ptr:date.value = Date()
ptr:note.activate()

then the user just needs to type the note and hit F9.

[Finian Lennon]

Re: Browse opening in specific location and failing to save data

FWIW, there is no reason for pick2 to be a global variable unless there are compelling reasons elsewhere in the application, which I doubt I would agree with! Not that I am against global variables, far from it. But using globals this way can give rise to a giant haze of useless objects that just clogs up the environment.

As I'm sure Tom's article about passing values between forms will point out, all the variables in the calling form could be dimmed as local and have their values assigned to the fields (or variables) in the called form when referenced in the form/button script. Once you have the pointer to the form/browse you are opening, you can likewise reference (set or get) any object on that form/browse, using the pointer:object.value.

[MikeData]

Re: Browse opening in specific location and failing to save data

Finnian, that is what I ma trying to do is changing my early codes developed a while back as speed and performance is becoming increasingly needed.
Thanks.