Cannot use function in this context

[gagsoft]

Hi All

I have three scripts. Summarise_Bookings, Update_Resbal, and one that opens a Wndow displaying the resulting table details. These scripts run with all windows closed from a buttonbar.
Summarise_Bookings - Summarises Tours per date and sums various numerical qty's.
Update_Resbal - Looks for existing records and updates where neccessary and appends new ones.
A third script that opens the form with :form.view("Resource_Balancing")
Runing these scripts from another script called from the buttonbar gives the "Cannot use funtion in this context" message: see atached image. Running the one script that calls the other two and completes everything as required.

This is the code to update the resbal table from the summary booking table:

dim tbl as P
dim vTour as c
dim vDate as d
dim vCount as n
vCount = 0
tbl = table.open("summary_tour_day")
'debug(1)
tbl.fetch_first()
while .not. tbl.fetch_eof()
	vTour = tbl.tour
	vDate = tbl.tour_date
	'Pause the script for a instant until the user interface has finished repainting.
	xbasic_wait_for_idle()
	'--------------------------------------------------
	dim tblResbal as P
	dim qry as P
	dim nrecs as N
	nrecs = 0 ' CHECK THIS OUT
	tblResbal = table.open("resbal")
	tblResbal.index_primary_put("TDate")
	query.description = "TourAndDate"
	query.order = "Tour"
	query.filter = "tour = VAR->vTour .and. tour_date = {" + VAR-> vDAte + "}"
	query.options = "U"
	qry = tblResbal.query_create()
	nrecs = qry.records_get()
	IF (nrecs = 0) then
		qry.drop()
		'ui_msg_box("Null Query","There are no records in the Query" ,UI_INFORMATION_SYMBOL)
		query.order = ""
		query.filter = ""
		END
		'DO INSERT HERE
		tblResbal.enter_begin(.T.)
    		tblResbal.tour = tbl.tour
    		tblResbal.tour_date = tbl.tour_date
    		tblResbal.action_day = CDOW(DATE())
    		tblResbal.action_date = Date()
    		tblResbal.action_time = Time()
    		tblResbal.total_balance_outstanding = tbl.total_balance_outstanding
    		tblResbal.total_total_amount = tbl.total_total_amount
		tblResbal.total_tot_pax  = tbl.total_tot_pax
    		tblResbal.count_tour  = tbl.count_tour
    		tblResbal.enter_end(.T.)
    		tblResbal.close()
	end if
	if (nrecs > 0) then
	'	script_play("Test_Message")
		'DO RECORD UPDATE HERE
		tblResbal.change_begin(.T.)
		tblResbal.action_date = Date()
		tblResbal.action_time = Time()
		tblResbal.action_day = CDOW(DATE())
    		tblResbal.total_balance_outstanding = tbl.total_balance_outstanding
    		tblResbal.total_total_amount = tbl.total_total_amount
		tblResbal.total_tot_pax  = tbl.total_tot_pax
    		tblResbal.count_tour  = tbl.count_tour
		tblResbal.change_end(.T.)
		tblResbal.close()
		'--------------------------------------------------
		query.order = ""
		query.filter = ""

		'--------------------------------------------------
	end if
	'--------------------------------------------------
	vCount = vCount +1
	tbl.fetch_next()
end while
tbl.close()

Any assistance with this would be appreciated
Thanks
Peter G

[Stan Mathews]

Re: Cannot use funtion in this context

query.filter = "tour = VAR->vTour .and. tour_date = {" + VAR-> vDAte + "}"

should be

query.filter = "tour = "+quote(VAR->vTour)+" .and. tour_date = {" + dtoc(VAR-> vDAte) + "}"
or
query.filter = "tour = "+quote(VAR->vTour)+" .and. tour_date = " + s_quote(VAR-> vDAte )

[gagsoft]

Re: Cannot use funtion in this context

Hi Stan
Thank you very much for the help. Works like a charm.
Much appreciated
Thanks
Peter G

[gagsoft]

Re: Cannot use funtion in this context

Hi Stan

I do still get "Property not found" on the query.filter line intermittently.

query.filter = "tour = "+quote(VAR->vTour)+" .and. tour_date = " + s_quote(VAR-> vDAte )

Do you perhaps know what could cause this or point me in the right direction to look for the cause?

Many thanks
Peter G

[Ray in Capetown]

Re: Cannot use funtion in this context

Peter
presumably you have debug on that you know which line results in error.
Since at that line only a string is being assembled - so the only problem could be one of the values.
Test those two values right there in the debugger

[Tom Cone Jr]

Re: Cannot use funtion in this context

Peter,

Here are some ideas for you.

1) I don't understand why you open a new instance of the resbal table on each fetch in the summary_tour_day table. Opening, querying, and closing a table is among the slowest things a script can do. Why not open the resbal table once before the while loop starts?

2) Why do you query the resbal table and then only update one record if any are found? Are there never more than 1 there? If so, wouldn't an indexed find by key be cleaner (and possibly faster) ?

3) Your script makes no provision for multi-threading. Are you assuming the script stops while the resbal table is found, opened, queried, updated, and closed? It probably does not. Windows offloads these kinds of disk activities, and the script keeps running. I'm thinking you're having a timing issue here. You cannot safely assume that alpha will complete each line in your script before it moves on to the next. If the script includes sequences that retrieve, filter, store data on disk, its always possible that Windows will offload that activity and keep plowing ahead to the next lines in your script.

[Ray in Capetown]

Re: Cannot use funtion in this context

Or, if you get the error in an error dialog then write the values with traceln() immediately before the line.

[Ray in Capetown]

Re: Cannot use funtion in this context

Toms on the track
Noting that if nrecs < 1 then you leave tblResbal open.
And open it again - I have no idea what the effect of that is.

[gagsoft]

Re: Cannot use funtion in this context

Hi Tom, Ray
I really appreciate all the inputs. will have a look at and optimise.

Thanks
Peter G