Can anyone spot a problem in this script please?

[[email protected]]

I have been using this script with some modifications for two years. It was very kindly provided by Stan Matthews. I recently tried to change machines but after downloading a fresh version of A5V11 and copying the directory to the new maching I get "Couldnot open or create multi-user information file C:\Program Files (x86)\a5V11\Laprima\Laprima.MUF'. The file is there (Windows 10) with 0 bytes exactly as on the old machine (XP). So firstly can someone help me fix that? In the meantime I tried a minor change at the same time on the old XP machine, the change was to add a bcc_param to send the same pdf report elsewhere as a check that the file had been sent, you can see the two lines that I have changed. When I run the script, I get the message "File not found: "Your attached account covers the month of June". I'm not very familiar with scripting so it must be my mistake but it looks to me as though the script is looking for a file in the;
if filefind.get(a5.Get_Path()+chr(92)+"Accounts "+cmonth(date()),FILE_FIND_DIRECTORY,"PN") = ""
dir_create(a5.Get_Path()+chr(92)+"Accounts "+cmonth(date())) part but I'm sure I haven't changed that.
I would really appreciate any help.

'Date Created: 19-Oct-2013 03:07:47 PM
'Last Updated: 04-Jun-2016 09:32:47 AM
'Created By : usuario
'Updated By : Laura Johnson
parentform.commit()
tbl = table.current()
tbl.fetch_first()
'debug(1)
while .not. tbl.fetch_eof()
query.filter = "cuscode = "+quote(alltrim(tbl.cuscode))
query.order = ""
to_param = Lookup("Clients","cuscode = "+quote(alltrim(tbl.cuscode)),"alltrim(email)")
if alltrim(to_param) > "" 'only execute this section if an email address is found
cc_param = a5_eval_expression("",local_variables())
bcc_param = a5_eval_expression("[email protected]",local_variables())
subject_param = "Monthly account from Laprima S.L."
message_param = "Your attached account covers the month of "+cmonth(date())+"."
if filefind.get(a5.Get_Path()+chr(92)+"Accounts "+cmonth(date()),FILE_FIND_DIRECTORY,"PN") = ""
dir_create(a5.Get_Path()+chr(92)+"Accounts "+cmonth(date()))
end if
:report.SaveAs("AccMonthly","PDF",query.filter,query.order,a5.get_path()+chr(92)+"Accounts "+cmonth(date())+chr(92)+" Acct "+tbl.cuscode+".pdf")
sleep(4)
email_send(to_param,bcc_param,subject_param,message_param,a5.get_path()+chr(92)+"Accounts "+cmonth(date())+chr(92)+" Acct "+tbl.cuscode+".pdf")
sleep(4)
end if 'end of section to create and send email if address found
tbl.fetch_next()
end while
fil.flush()
fil.close()

Thank you in advance,
Trevor.

[Stan Mathews]

Re: Can anyone spot a problem in this script please?

"Could not open or create multi-user information file C:\Program Files (x86)\a5V11\Laprima\Laprima.MUF'.

Has nothing to do with the script. It indicates you do not have write access rights to the directory where the database is located. Windows often sets limited access until told otherwise.

In the script itself it would seem that tbl.cuscode should be alltrim(tbl.cuscode) in both the report.saveas() lijne and the email.send() line.

if filefind.get(a5.Get_Path()+chr(92)+"Accounts "+cmonth(date()),FILE_FIND_DIRECTORY,"PN") = ""
 dir_create(a5.Get_Path()+chr(92)+"Accounts "+cmonth(date()))
 end if
 :report.SaveAs("AccMonthly","PDF",query.filter,query.order,a5.get_path()+chr(92)+"Accounts "+cmonth(date())+chr(92)+" Acct "+tbl.cuscode+".pdf")
 sleep(4)
email_send(to_param,bcc_param,subject_param,message_param,a5.get_path()+chr(92)+"Accounts "+cmonth(date())+chr(92)+" Acct "+tbl.cuscode+".pdf")

The first section checks to see if the directory to save in exists and if it doesn't, creates it.

I would remove the leading space in both instances of +" Acct "+
not sure Alpha would understand a file name beginning with a space.

[[email protected]]

Re: Can anyone spot a problem in this script please?

Hi Stan, thank you for trying to help - again.
O.k., my first problem is solved, I played around with the windows security settings and I can now open the database on the new machine.
Getting back to the old machine and the second problem, I have removed the leading spaces in front of the " Acct " in both instances and added alltrim so it reads alltrim(tbl.cuscode in both instances. I also tried it with (alltrim(tbl.cuscode)) but neither work. The moment I remove the bcc address and the bcc_param in the send line, it works again (I have to remove both).
So could the space after the Acct be causing the problem?
I also noticed a colon at the beginning of the report.SaveAs line, is that o.k.? I would check it out but now that A5 has gone to Alpha Anywhere I can't find the syntax in the help file.
Regards,
Trevor.

[Stan Mathews]

Re: Can anyone spot a problem in this script please?

Maybe things accidentally got mangled when you made the change to the email_send(). I didn't really look at that line other than the path to the file to send. The syntax is

 EMAIL_SEND( Send_To as C, Subject as C, Message as C [, Attachments as C [, CC as C [, BCC as C [, Store_In_Outbox as L [, Text_Type as C [, HTML_Message as C [, Profile as C [, Zip_Attach as L [, Silent as L ]]]]]]] )

If you include a bcc you must include all the parameters before it in the proper order

email_send(to_param,subject_param,message_param,a5.get_path()+chr(92)+"Accounts "+cmonth(date())+chr(92)+" Acct "+tbl.cuscode+".pdf","",bcc_param)

[[email protected]]

Re: Can anyone spot a problem in this script please?

Thank you so much. After a few tweaks (me, staggering about in the dark) it now works, although not yet on the new machine. Can you tell me where to find the list of functions\syntax that used to be on F1 key (A5V11 help file) please? Then I may not have to keep pestering you. The reason is that the internet connection isn't good here and after sending 27 of the 31 files, it stopped because it couldn't find the smtp server that I had specified in email settings. So I would like to try either a pause and restart but where it failed from, or at least just be able to specify what remaining files to send one by one, perhaps using 'ask'.
Thanks again,
Trevor.