Browse/Hyperlink - Open Form

[enstorms]

The new Browse Control->Browse/Hyperlinks->Open Form uses the :Form.viewqueried method to call a form to edit a selected record in a browse. In reading the Help on this, I think it requires a <tbl>.Close() method when closing the form.

Note : If you do not close the form at the end of your script, you will leave the underlying table(s) open.

The reason I'm bringing this up is I, on several occasions, have tried to do a Backup Database after running this procedure and always get the "<this form's tablename> is in use and can't be backed up" message. This is the only possibility I can come up with at this point. I don't see where the table, the called form is based on, is being closed, unless it's done somewhere internally. Can anyone shed some light on this situation?
Ernie

P.S. This is the script it generates:

function Actions_ButtonClick as v( event as C,data as C, row as N)
	this.Set_Viewport_row(row)
	if this.Table_Get().Mode_Get() > 0 then
		this.Commit()
	end if
:Form.viewqueried("payments_form",eval("\"Pay_id=\"+s_quote(payments->Pay_id)",this.Name(16)+".this"),"","Dialog","","",.t.)
browse3.Refresh_Layout()    [COLOR="Red"]<<my code[/COLOR]
parentform:total_paid.value = vPayments.value  [COLOR="Red"]<<my code[/COLOR]
parentform:total_paid.refresh()  [COLOR="Red"]<<my code[/COLOR]
end function

[MoGrace]

Re: Browse/Hyperlink - Open Form

Hi Ernie,
The help is referring to when you open a form as a dialog, you must put the form_ptr.close() in the calling script else the form remains in memory when the user closes it. I think the help for Form.load() gives more info.

[enstorms]

Re: Browse/Hyperlink - Open Form

Hi Robin,
Well, in looking at all the example scripts for "form.viewqueried", they all are opening a form, "doing things...", then have a <frmpointer>.close() at the end. Is this not the same? I am understanding it as saying, the form has to have a specific close() command, not just putting a Close button that closes the form window. In my case, if I call the update form using this method, close the form, then try to backup the database, I get an immediate message saying the the table the form is tied to is in use and cannot be backed up. I will try it on another browse and see what happens. Thanks for your help in this.
Ernie

Later: In running my app with the Control Panel tabs visible, I call the form with this method, close the form with a Close button, but the form is still open when I return to the calling form. I am calling it as "Dialog". So, I think, this is, in fact, what is happening. The script seems to need the close() method attached somewhere. This is the sequence of openings:
1st time, tab says "myform"
2nd time, tab says "myform0"
3rd time, tab says "myform1" and continuing on up.
If I open the form from the control panel, it gets the next "instance number" of the form. I close it out and reopen it from control panel and it gets the same instance. Open it from the embedded browse, it gets that instance. Close, re-open from browse, it's the instance + 1.

[Tom Cone Jr]

Re: Browse/Hyperlink - Open Form

Edit the generated script to close the form.

function Actions_ButtonClick as v( event as C,data as C, row as N)
	this.Set_Viewport_row(row)
	if this.Table_Get().Mode_Get() > 0 then
		this.Commit()
	end if
:Form.viewqueried("payments_form",eval("\"Pay_id=\"+s_quote(payments->Pay_id)",this.Name(16)+".this"),"","Dialog","","",.t.)
browse3.Refresh_Layout()    <<my code
parentform:total_paid.value = vPayments.value  <<my code
parentform:total_paid.refresh()  <<my code
[COLOR="Red"]if is_object("payments_form") then
     :payments_form.close()
end if[/COLOR]
end function

[enstorms]

Re: Browse/Hyperlink - Open Form

Great, Tom. That did it. I couldn't figure out how to get the proper pointer to the table/form. I just submitted a bug report on this. I feel like that should be part of the script that is calling the form.
Thanks a bunch.
Ernie

[Tom Cone Jr]

Re: Browse/Hyperlink - Open Form

I agree, but only if you opt to open the called form as dialog. The genie should supply the necessary form closing code when the called form is opened as dialog.

[MikeC]

Re: Browse/Hyperlink - Open Form

Hi,

The genie should supply the necessary form closing code when the called form is opened as dialog.

And the Action Script Genie usually does do just that....but not always I find...and it doesn't always work when AS writes it either (too inconsistant to be reproduced for a bug report so far). So in this case I many times resort to redundancy to make sure any dialog form gets closed when opened via a Genie by adding another close script as Tom showed at the very end of my scripts (in AS it would be Window Commands left panel, Close Window right panel). Of course when using xbasic this is a moot point.

[enstorms]

Re: Browse/Hyperlink - Open Form

As an update to this issue, this is the fix that Selwyn has made when using this method of calling an update form as a "Dialog".

P = :Form.viewqueried("payments_form",eval("\"Pay_id=\"+s_quote(payments->Pay_id)",this.Name(16)+".this"),"","Dialog","","",.t.)
P.CLOSE()

Thanks to all for your inputs.
Ernie