while .not. tbl.fetch_eof() not working

[reynolditpi]

I have the below code attached to a button on a form. When the button is fired, the table field "Assign_workout" (which is a field in the parent table of the set the form is based from) should be set to .t. for the filtered list of records.

dim tbl as p

tbl = table.get("workouts") ' I have also tried table.current(1)
tbl.fetch_first()

while .not. tbl.fetch_eof()
	 tbl.change_begin()
	 tbl.ASSIGN_WORKOUT=.t.
	 tbl.change_end()	 
	 tbl.fetch_next()
end while

The problem is that it never stops looping. I placed a ui_msg_box() in the loop so i could cancel if I needed to and it seems it would go for ever. I hit the okay button on the message box 20 times before I canceled the action...there are only 4 records in the Workouts table!!!

I have the same code (using table.get) on another form that is based just on the workout table. This code works fine for it.

I know this is something simple that I am doing wrong and that it is related to the fact this form is based on a set unlike the form where this code works which is based on a single table.

Any feedback would be appreciated.
Thanks
Tony

[Doug Page]

Re: while .not. tbl.fetch_eof() not working

According to the docs, table.get() uses an OPEN file. This could be your problem. How about trying table.open().

[reynolditpi]

Re: while .not. tbl.fetch_eof() not working

Doug,
I have tried table.get and table.current because the workout table is filtered (by criteria set on the form) so only selected records get their assign_workout value set to .t..

Am i wrong in thinking that table.open() opens a new instances of the table without the filter in place.

[Doug Page]

Re: while .not. tbl.fetch_eof() not working

No you are not wrong. However, you have filtered on a set and I don't think that you can then use that filter on an individual table. Why are you not using the set that is filtered? You would still be able to update the field you want to.

[reynolditpi]

Re: while .not. tbl.fetch_eof() not working

Just for curiosity sake and filter aside...shouldnt the code i posted work? Why does it continue to loop?

[jaryder]

Re: while .not. tbl.fetch_eof() not working

Tony,

You could have an index problem with your data. Try rebuilding your indexes. If that does not help then try changing the message box to show some of the data so you know which records are being processed. But to your answer yes I looks like it should work OK.

Jeff

[reynolditpi]

Re: while .not. tbl.fetch_eof() not working

Thanks Jeff. I have rebuilt my index for all tables and it did not help.

I changed the message box to display the current record (or workout) name as it is looping....and it stays on the first record. It just repeatedly displays it.

I have stripped down the database to just the form in question and attached it.

The "problem" code is on the onpush event for the "Check All" button

[G Gabriel]

Re: while .not. tbl.fetch_eof() not working

Your script is fine (with one minor exception):

tbl.change_end(.t.)

Something else is wrong.

What is the full script?

[reynolditpi]

Re: while .not. tbl.fetch_eof() not working

Thats the whole script. I did have tbl.change_end(.t.) at first. I will add it back.

[Stan Mathews]

Re: while .not. tbl.fetch_eof() not working

Your combination of two one to many links to the same table with one of the links set for referential integrity is causing strange behavior.

[reynolditpi]

Re: while .not. tbl.fetch_eof() not working

I removed the second one to many link from the set and am still having the problem

[G Gabriel]

Re: while .not. tbl.fetch_eof() not working

Falling under the bizzarre category, time to post a sample. I am off to the gym, good luck.

[reynolditpi]

Re: while .not. tbl.fetch_eof() not working

G,
I attached the db to an above post.

[Tom Cone Jr]

Re: while .not. tbl.fetch_eof() not working

Tony, I'm not sure why you're having this trouble. I can see it and can only say that you're doing things differently than I would ever have attempted.

For the benefit of others, Tony's form is based on a set. The set spec in his example is based on three tables, but the example only includes two. However, even after dropping the missing table from the set spec the problem in the form happens as he describes. The problem occurs even if referential integrity is disabled.

His form contains a browse object displaying the records in the primary table. His script is trying to set a logical field value in all the records of the primary table. Instead of opening a new instance of the primary table and updating the field values in all the records his script tries to establish a pointer to the primary table and then step through the records in the instance of the table supporting the form.

The linked child table contains JPG images in a relatively large memo file. My suspicion is that the script is running ahead of the disk activity. Each primary table record is linked to multiple child records which are relatively large (because of the embedded images). My guess is that his script is failing because of a timing issue. Each time it fetches the next record it does not stop and wait for all the related children to be fetched, too. This must happen since the script is fetching through the instance of the table supporting his set based form. I think his trouble goes away if the script doesn't try to move so much data on each fetch of the primary table records. Or, if his script is broken down into separate UDF's which run consecutively. To my way of thinking an easier approach by far is to have the script open a new instance of the one table, update all the records, refresh the display and then end.

Will follow this thread to see if others have better ideas.

-- tom

[G Gabriel]

Re: while .not. tbl.fetch_eof() not working

G,
I attached the db to an above post.

Sorry..missed it.
Yeh.. nothing wrong with your script and nothing bizzare either.
You are under the mistaken impression that the script runs indefinitely.
It does not.

Both table.current() and table.get() point to an open file. In this case and when using it in the context of a form based on a set, it points to the composite table.

While you do have only 4 records in the parent table, you have close to forty (I didn't count them but that's pretty close) in the composite table and that's how many times the script will run when you expect it to run 4 times only.

If you use table.open() instead, all is well with the world. It runs only 4 times as expected.