very frequent a5 crashes

[reynolditpi]

A5 has crashed on me more than 10 times since yesterday morning.

It happens frequently but not consistantly when running the following xbasic from a button push.

	'************************************************************
'open the cl_team form. Get id and delete record.
'************************************************************		
dim clid as c
dim tbl as p
tbl = table.open("cl_team",FILE_RW_SHARED)

tbl.fetch_first()
tbl.batch_begin()
while .not. tbl.fetch_eof()
	
if tbl.Picked= .t. then
		clid = tbl.cl_id
		'***delete client for cl_team table
		tbl.change_begin(.t.)
		tbl.delete()
		tbl.change_end(.t.)
		
		
		'**************************
		'***open the clients table
		'**************************
		dim atbl as p
		atbl=table.open("clients",FILE_RW_SHARED)
		
		'***filter to client id
		atbl.index_primary_put("client_id")
		atbl.fetch_find(var->clid)

		
		'***delete the clients picture if it exists
		dim img as c
		img=atbl.Client_picture
		dim name as c
		dim bname as c
		dim fullpath as c
		name = word(img,-1,"\\",1)
		bname=word(name,1,chr(34))
		fullpath=a5.get_path()+chr(92)+"images"+chr(92)+"ClientPictures"+chr(92)+bname
		if file.exists(fullpath) then
			file.remove(fullpath)
		end if
		
		'***delete the client
		atbl.change_begin()
		atbl.delete()
		atbl.change_end(.t.)
		atbl.close()
								
		'**************************
		'***open the cl_exer table
		'**************************
		dim btbl as p
		btbl=table.open("cl_exer",FILE_RW_SHARED)
		btbl.delete_range("client_id="+s_quote(clid))
		btbl.close()
			
		'**************************
		'***open the cl_workout table
		'**************************
		dim ctbl as p
		ctbl=table.open("cl_wrkout",FILE_RW_SHARED)
		ctbl.delete_range("client_id="+s_quote(clid))
		ctbl.close()	
		
		'**************************
		'***open the cl_notes table
		'**************************
		dim dtbl as p
		dtbl=table.open("cl_notes",FILE_RW_SHARED)
		dtbl.delete_range("client_id="+s_quote(clid))
		dtbl.close()
			
end if	

	
end while	
tbl.batch_end()
tbl.close()
'************************************************************
'refresh the form
'************************************************************
athlete_Browse.refresh()
athlete_Browse.fetch_first()

Does anything in this script look like it may cause an a5 crash?

I did do a one step doc with the a5 documenter addin yesterday morning as well. I do not know if that has done something.

Any thoughts would be appreciated.
Tony

[reynolditpi]

Re: very frequent a5 crashes

I have added several msgbox's to see if I could figure out where it is hanging up:

		msgbox("","0")
	'************************************************************
'open the cl_team form. Get id and delete record.
'************************************************************		
dim clid as c
dim tbl as p
tbl = table.open("cl_team",FILE_RW_SHARED)
	msgbox("","0a")
tbl.fetch_first()
tbl.batch_begin()
while .not. tbl.fetch_eof()
	msgbox("","0b")
if tbl.Picked= .t. then
	msgbox("","1")
		clid = tbl.cl_id
		'***delete client for cl_team table
		tbl.change_begin(.t.)
		tbl.delete()
		tbl.change_end(.t.)
		
		
		'**************************
		'***open the clients table
		'**************************
	msgbox("","2")
		dim atbl as p
		atbl=table.open("clients",FILE_RW_SHARED)
		
		'***filter to client id
		atbl.index_primary_put("client_id")
		atbl.fetch_find(var->clid)

	msgbox("","3")		
		'***delete the clients picture if it exists
		dim img as c
		img=atbl.Client_picture
		dim name as c
		dim bname as c
		dim fullpath as c
		name = word(img,-1,"\\",1)
		bname=word(name,1,chr(34))
		fullpath=a5.get_path()+chr(92)+"images"+chr(92)+"ClientPictures"+chr(92)+bname
		if file.exists(fullpath) then
			file.remove(fullpath)
		end if
	msgbox("","4")		
		'***delete the client
		atbl.change_begin()
		atbl.delete()
		atbl.change_end(.t.)
		atbl.close()
	msgbox("","5")								
		'**************************
		'***open the cl_exer table
		'**************************
		dim btbl as p
		btbl=table.open("cl_exer",FILE_RW_SHARED)
		btbl.delete_range("client_id="+s_quote(clid))
		btbl.close()
	msgbox("","6")			
		'**************************
		'***open the cl_workout table
		'**************************
		dim ctbl as p
		ctbl=table.open("cl_wrkout",FILE_RW_SHARED)
		ctbl.delete_range("client_id="+s_quote(clid))
		ctbl.close()	
	msgbox("","7")		
		'**************************
		'***open the cl_notes table
		'**************************
		dim dtbl as p
		dtbl=table.open("cl_notes",FILE_RW_SHARED)
		dtbl.delete_range("client_id="+s_quote(clid))
		dtbl.close()
			
end if	

	
end while	
tbl.batch_end()
tbl.close()
'************************************************************
'refresh the form
'************************************************************
athlete_Browse.refresh()
athlete_Browse.fetch_first()

it displays msgbox("","0b"). I click the close button on the msgbox and it flashes and remains open. I then have to open my windows task manager and close a5 down.

[reynolditpi]

Re: very frequent a5 crashes

One more discovery. If i comment out the if then statement then it does not lock up.

[MikeC]

Re: very frequent a5 crashes

Hi Tony,

Just a thought and unknown if related to your current problem.....I would think that normally child records would be deleted before the parent especially if you are still using data from the parent to find the child(ren).

[Tbaker]

Re: very frequent a5 crashes

Tony

I just reveiwed your code again, I think that the problem lies in the fact that you are starting out with tbl.fetch_first(), then going through the iteration ; however your first bit of code if tbl.Picked=.t. then do stuff, there is no way for your code to fetch the next record if tbl.picked=.F. You are getting hung up because if tbl.picked =.f. then you will always look at the first record fetched since there is nothing to fetch the next record.

Just add tbl.fetch_next() before the end while statement - then if tbl.picked=.f. then the fetch_next() will start the iteration at the next record.

If tbl.picked=.t. the table fetch would not upset the tbl.delete() and the tbl.delete_range() statements within you code.

You would still need the tbl.fetch_next() before the end while statement to keep the iteration going since you are going through the whole client file both picked=.t. and picked=.f.

[Tom Cone Jr]

Re: very frequent a5 crashes

Tony, I think Tom is on to something, but I'd recommend doing it differently. use an ELSE statement before the "end while" statement and put your tbl.fetch_next() there. You don't need it when tbl.picked = .t. because the delete method will automatically fetch the next record for you.

Other issues:
a) you are dimming, opening and closing all the child tables and the related variables each time through the WHILE... END WHILE code block. Don't. Open them before the code block. Dim your variables at the top, before the Code Block. Then close all the tables when the code block finishes. i.e. only dim, open, and close once for each child table.

b) If it were me, I'd put the child table delete sequences in separate user defined functions to avoid timing issues. Do not assume your script will stop running when a command requires alpha to go over to the server fetch some records and then delete them. the script does not wait unless you do the disk activity work inside a udf.

[G Gabriel]

Re: very frequent a5 crashes

dim clid as c

Change to:
dim global clid as c

[reynolditpi]

Re: very frequent a5 crashes

This all make sense. It does bring up two more questions.
1) would i be better off removing the if..then and instead use query_create() to filter the table to just include the .t. values. This table could hold up to 600 records with only small numbers of records getting deleted at a time.

2) Gabriel. Why should I use a global variable here? I am not sure I understand the reason since it is only used within the script.

Thanks again for all of the help!
Tony

[reynolditpi]

Re: very frequent a5 crashes

Alright,
I have tried to implement your suggestions.

Here is what I now have:

dim global cl_id as c
dim tbl as p
dim atbl as p
dim btbl as p
dim ctbl as p
dim dtbl as p

atbl=table.open("clients",FILE_RW_SHARED)
btbl=table.open("cl_exer",FILE_RW_SHARED)
ctbl=table.open("cl_wrkout",FILE_RW_SHARED)
dtbl=table.open("cl_notes",FILE_RW_SHARED)				

tbl = table.open("cl_team",FILE_RW_SHARED)
tbl.query_create("","picked=.t.")
tbl.fetch_first()
tbl.batch_begin()

while .not. tbl.fetch_eof()

	clid = tbl.cl_id
		
	'***Clients Table-Remove record and delete the clients image stored in the storage folder
	Delete_Athl_Client_Tbl()

	'***Delete from cl_exer table
	Delete_Athle_Exer()
	
	'***delete from the cl_workout table
	Delete_Athle_Wo()

	'***delete from the cl_notes table
	Delete_Athl_Notes()
	
	'***delete the cl_team record
	tbl.change_begin(.t.)
	tbl.delete()
	tbl.change_end(.t.)
			
end while
	
tbl.batch_end()

tbl.close()
atbl.close()
btbl.close()
ctbl.close()
dtbl.close()
'************************************************************
'refresh the form
'************************************************************
athlete_Browse.refresh()
athlete_Browse.fetch_first()

My UDFs just contain the delete code for each table

For instance, my Delete_Athle_Wo() udf is:

dtbl.delete_range("client_id="+s_quote(clid))

Am I more in the ballpark here???
Thanks again.
Tony

[Tom Cone Jr]

Re: very frequent a5 crashes

yes, almost, but you should pass the filter / search key to each function as a parameter, and your function should open each table. You don't need to open the child tables in your main script if you are using UDF's

The function would be something like:

FUNCTION Delete_Athle_Wo AS L (srch_key as C)
      dtbl = table.open("cl_notes")
      dtbl.delete_range("client_id = " + s_quote(srch_key))
      dtbl.close()
END FUNCTION

And then call it in your script like this:

Delete_Athle_Wo( clid )

What I've described is the simpler approach. Once you get it working you might want to open each child table in the main script and pass a pointer to that table to your function as well as the srch_key. Your functions wouldn't have to open and close the tables each time they're called if you did it that way. However, this is more advanced.

[reynolditpi]

Re: very frequent a5 crashes

Tom,
I didnt take long for me to figure out what I had posted would not work.

Here is what I had come up with...Here is the udf:

FUNCTION Delete_Athlete_Child_Rec AS C (tabl as p )

tabl.delete_range("client_id="+s_quote(clid))
END FUNCTION

Here is how I called the function:

	delete_athlete_child_rec(btbl)
	
	'***delete from the cl_workout table
	Delete_athlete_child_rec(ctbl)

	'***delete from the cl_notes table
	Delete_athlete_child_rec(dtbl)

As you had initially suggested, I dimmed the pointer variables and opened/closed the tables outside the loop.

I must admit that I was quite suprised that this worked for me as I have not really done much with UDFs yet.

Is this acceptable or do I need to change it to you your suggestion?

[Tom Cone Jr]

Re: very frequent a5 crashes

Tony, I think what you have will work fine. In my own work here I try to design my functions so that there are no dependencies. If a value is needed inside the function I pass it to the function explicitly. In the last version your function is dependent on the term "clid" being declared and populated by some other process. If it were me, I'd pass the table pointer AND the search key to the function. This removes the dependency and makes the UDF more versatile. -- tom

[reynolditpi]

Re: very frequent a5 crashes

Makes perfect sense Tom.

I will make the change.
Thanks
Tony