Xdialog problem

[tsoileau]

I am trying to create a desktop application to keep track of inventory of textbooks for our school system. At this point I am trying to create a dialog box to input a room number which will use a report to show what textbooks are in a certain room. I have created the dialog box with a field that is 6 characters long. The dialog box comes up and I input the room number then the report comes up but not with the filtered data. All the data shows up. I tried to follow the training to a tee. I have repeated the building steps many times but..... Any ideas? Thanks. Also, do any of you have a sample of a straight inventory program that I could look at to help with the textbook inventory program? Merry Christmas.

[Tbaker]

Re: Xdialog problem

Are you using the reports "Select Records" (in design mode for the report, select "report" from the upper menu then "select Records"?

What is the filter that you are using? Something like

room_number = var->nameofvariable for room number

Or have you created a query opertion to get the records you need?

Tom Baker

[tsoileau]

Re: Xdialog problem

I am using Records selected by a filter expression. The filter expression is:
Room_ number=Var->room_number. thanks.

[Tbaker]

Re: Xdialog problem

Ted

Could you post a small sample to look at

Tom

[Tbaker]

Re: Xdialog problem

Here is a sample of what I think you need

Tom

[tsoileau]

Re: Xdialog problem

Here is the folder with the start of the application. Any suggestions is appreciated.

[Tbaker]

Re: Xdialog problem

Ted

There was nothing in the zip file except folders

Tom

[tsoileau]

Re: Xdialog problem

Let me try it again.

[Tbaker]

Re: Xdialog problem

Ted

I see a lot of forms - can you tell me which one I should be looking at for the dialog and then the report?

Tom

[tsoileau]

Re: Xdialog problem

Tom,

I do appreciate you patience. I created the code--it is room inventory--it should be the only code. The report is room inventory.

[Tbaker]

Re: Xdialog problem

Ted

It seems that this app was converted from Version4. There also seems to be one corrupted form (room number).

Anyway, I have attached your zip file revised. Put the filter for the report in the report itself (in design mode, select report, then select "select Records" and in the box at the top I put the filter (room_number=var->room_number).

Then in action scripting for "print the layout" in your code, I changed the select records to print from "records selected by a filter expression" to "no additional selection criteria".

Now when you run the report, you put in a room number in the dialog box and then the report runs showing just the room number you want.

There seems to be some trouble using the filter from the code - I don't know why right now, but I will keep on checking a get back to you. But by putting the filter directly into the select records of the report - it will work just fine.

Tom Baker


Edit -

I wasn't seeing the forest for the trees.

If you put a button a form which is based on the testbook_orders.dbf which calls the script (code), it will run the report the way you want it from you original code.

I was trying to run the code from the code editor which was not relating properly to the correct table when running the report.

Again just place a button on a form associated with textbook_order table and run the room inventory script from that button.

[Tbaker]

Re: Xdialog problem

Ted

Just to keep this thread in order, I have attached a zip file based upon the edit from my last post.

I put a button on the "TextbookS" form called "Run the room inventory Report" which just has the code

 script_play("room inventory")

You could also just copy your code to that button and it will do the same thing.

I changed the code back to your original code and deleted the filter from "select records" in the reports properties.

Tom

[CALocklin]

Re: Xdialog problem

You could also just copy your code to that button and it will do the same thing.

Absolutely true BUT it's often easier to develop when the code is in the Code tab and use Script_play("<ScriptName>") to call it from the button/event.

Consider these two editing scenarios. You've just finished testing your first attempt at fixing a problem and find you need to change something else. (I know, a truly good developer would get it on the first attempt but not me.):

1. Code on the button:
- Switch the form to Design mode. (a short wait)
- Right click the button to be edited.
- Select Events / On Push.
- Another short wait for the script to open then edit the script.
- Save and close the script.
- Save the form and switch back to View mode (another short wait) to test your changes.

2. Script in the Code tab.
- Click the Code tab in the Window Bar and edit the script.
- Click on the form name in the Window Bar and test your changes.

I don't know about other developers but I like #2 much better.

Even if you're just starting the first edit in option #2, you don't have to close the form. Just go to the Control Panel, select the Code tab, and open the script. After that you can just switch back and forth.

That's not to say I don't have quite a few scripts directly in my buttons/events but those are only the very simple ones that shouldn't need to be edited unless I decide to make a change to the functionality. (i.e., a simple script like parentform.commit() probably won't need to be edited unless I decide to add some other feature.) If the script is complex or longer than what fits on about 1 screen, I usually put it in the Code tab for ease of development.

[Tbaker]

Re: Xdialog problem

Cal

Good advice


Tom Baker

[Mike Wilson]

Re: Xdialog problem

Cal,
I am glad that you have written up what I have tried to explain to several folks about the efficiency of scripts off buttons. I have gone one step further in making them user defined functions (UDFs), which is even easier to type.

Let me also add this. Form Curruption. There have been occassions where a form gets corrupted and whatever is on the form is LOST! Hours work on a form with lots of coding on buttons...not yet backed up...lost. That only needs to happen once to adopt this approach.