Trouble with ui_bitmap_draw

[Davidk]

Anyone see any problem with this code? It's taken pretty much from the help file...

dim jpg as B
dim bmp as B
Dim Global fname as c

fname = varShowImagePath + varShowImageName
If Isnull(fname) = .f. then
jpg = file.to_blob(fname)

bmp = jpeg_to_bitmap(jpg)

pixsize = ui_bitmap_info_get(bmp, "w,h")
xpix = val(word(pixsize, 1, ","))
ypix = val(word(pixsize, 2, ","))
xperin = ui_info(4)
yperin = ui_info(5)
width = xpix/xperin
height = ypix/yperin
ui_bitmap_create("combine", width, height)
ui_bitmap_load("image_name", bmp)
ui_bitmap_draw("combine", <<%code%
bitmap("image_name", 0, 0,0,0,"ROTATE-RIGHT")
%code%)

This is the error I'm getting on the ui_bitmap_draw line...

Script:OnInit line:28
ui_bitmap_draw("combine", <<%code%
ui_bitmap_draw: bitmap 'combine' not found

but I'm creating a couple of lines above. If you do a search in help on ui_bitmap_draw this is the code they use. Thanks... driving me crazy!

[Peter.Greulich]

Re: Trouble with ui_bitmap_draw

... driving me crazy!

It drives me crazy too! Unfortunately, both the explanations and the examples in the help file regarding A5 graphics is sadly deficient. The examples are overly complex and tend to combine multiple techniques making it very difficult to do something simple. You can indeed spend hours spinning your wheels studying the code examples. Anyway, the following works but might require further tweaking. I have assumed that you are trying to display a jpg image.

filename = "C:\Graphic Images\Autumn 008.jpg"

width = 8
height = 4

imagebits = file.to_blob(filename)
bmpbits = jpeg_to_bitmap(imagebits)

ui_bitmap_load("selected_picture", bmpbits)
ui_bitmap_create("thumbnail", width, height)

ui_bitmap_draw("thumbnail",<<%code%
bitmap("selected_picture",0,0,width,height)
%code%)

ui_dlg_box("Display Bitmap", <<%dlg%
{image=thumbnail}
%dlg%)

ui_bitmap_drop("thumbnail")
end

[G Gabriel]

Re: Trouble with ui_bitmap_draw

Works just fine for me.

It's driving you crazy because this code, which I don't know where you got it from, is definitely NOT complete.

Your code stops dead in it's track most likely at:
fname = varShowImagePath + varShowImageName
You have to dim these 2 variables first: varShowImagePath and varShowImageName
Actually, it does not stop there but it does not produce any image because it does not load any file.

Second, your code is missing "end if".

For testing purpose, just hard-code it with the actual file name.

[Peter.Greulich]

Re: Trouble with ui_bitmap_draw

Works just fine for me.
...
For testing purpose, just hard-code it with the actual file name.

Doesn't work for me, Gabe. Here is my code:

im jpg as B
dim bmp as B
Dim Global fname as c

fname = "C:\Graphic Images\For a few dollars more.jpg"

IF Isnull(fname) = .f. THEN
    jpg = file.to_blob(fname)
END IF

bmp = jpeg_to_bitmap(jpg)

pixsize = ui_bitmap_info_get(bmp, "w,h")
xpix = val(word(pixsize, 1, ","))
ypix = val(word(pixsize, 2, ","))
xperin = ui_info(4)
yperin = ui_info(5)
width = xpix/xperin
height = ypix/yperin
ui_bitmap_create("combine", width, height)
ui_bitmap_load("image_name", bmp)
ui_bitmap_draw("combine", <<%code%
bitmap("image_name", 0, 0,0,0,"ROTATE-RIGHT")
%code%)

[Raymond Lyons]

Re: Trouble with ui_bitmap_draw

Peter,

Are you saying the code following "here is my code:" does not work? If so, it does work (after adding a "d" to your "im" on line 1). But for it to show the result you have to add the following line at the end.

ui_dlg_box("","{image=combine}")

You can see that it works by changing the rotate statement from right to left of just "".

Raymond Lyons

[G Gabriel]

Re: Trouble with ui_bitmap_draw

Of course it won't work for you Peter.You put end if at the wrong spot. It should be all the way at the end of the script and if you are going to hard-code the file name, you don't need the IF statment to begin with.

[Raymond Lyons]

Re: Trouble with ui_bitmap_draw

Of course it won't work for you Peter.You put end if at the wrong spot. It should be all the way at the end of the script and if you are going to hard-code the file name, you don't need the IF statment to begin with.

If when hard coding you don't need the IF statement to begin with, it can't really matter where you put the end if (in any case, that is not the problem). And, as I previously stated, Peter's code does work, he just needed the ui_dlg_box("","{image=combine}") line to see some results. Peter's code with my jpg file and the added line to show the result:

dim jpg as B
dim bmp as B
Dim Global fname as c
dim combine as c

fname = "C:\0_pca_out\email_reader.jpg"

IF Isnull(fname) = .f. THEN
    jpg = file.to_blob(fname)
END IF

bmp = jpeg_to_bitmap(jpg)

pixsize = ui_bitmap_info_get(bmp, "w,h")
xpix = val(word(pixsize, 1, ","))
ypix = val(word(pixsize, 2, ","))
xperin = ui_info(4)
yperin = ui_info(5)
width = xpix/xperin
height = ypix/yperin
ui_bitmap_create("combine", width, height)
ui_bitmap_load("image_name", bmp)
ui_bitmap_draw("combine", <<%code%
bitmap("image_name", 0, 0,0,0,"rotate-right")
%code%)
ui_dlg_box("","{image=combine}")

[Davidk]

Re: Trouble with ui_bitmap_draw

Here's the full code... I just included those bit which were pertinent to see if anyone could see a problem with the syntax... sorry.

There is a problem... but not one that is obvious... because of all the great responses I knew something was wrong... but not in my code.

Here's the full code...

'On Error Goto Proc_Err

dim jpg as B
dim bmp as B
Dim Global fname as c

'the following two variables are dimensioned globally

fname = varShowImagePath + varShowImageName
If Isnull(fname) = .f. then
jpg = file.to_blob(fname)
bmp = jpeg_to_bitmap(jpg)
pixsize = ui_bitmap_info_get(bmp, "w,h,b")
xpix = val(word(pixsize, 1, ","))
ypix = val(word(pixsize, 2, ","))
bpix = val(word(pixsize, 3, ","))
xperin = ui_info(4)
yperin = ui_info(5)
width = xpix/xperin
height = ypix/yperin

ui_bitmap_create("combine", width, height)
ui_bitmap_load("image_name", bmp)
ui_bitmap_draw("combine", <<%code%
bitmap("image_name", 0, 0, width, height,"BEST-FIT, ROTATE-RIGHT")
%code%)

x = OLE.createpicture("combine")
:frmShowImage:activex1.activex.Picture = x
:frmShowImage:imagefilename.text = fname

ui_bitmap_drop("combine")
End if

Proc_Exit:
end

Proc_Err:
err = error_code_get()
msg = error_text_get(err)
ui_msg_box("Digital Adjuster", "Error # : " + err + " : " + msg)
resume Proc_Exit


So, the problem shows up when you throw my JPG image at it. Peter's JPG was fine... if you display the pixels for Peters image they'll be "reasonable"... whatever that is. For my image... even though it's small - 621k - it's pixel dimensions are 2304 x 1728. Divide those by the bits per pixel (96) and you get an image being created of 24 x 18. ui_bitpmap_create can't handle this so no image gets created so ui_bitmap_draw blows up. I need to test the create to make sure it's there first. An image size of 20x15 works... who knows.

Anyway... even at 20x15 the image that displays is really bad because of the colour depth I suppose.

All I want to do is rotate an image and display it in my Activex control... so hard to do... yikes.

This is not easy stuff to figure out... thank you for the discussion... never would have found it otherwise.

[G Gabriel]

Re: Trouble with ui_bitmap_draw

David:
I don't know what to make of:
varShowImagePath + varShowImageName
With these 2 variables you get the file name. I am guessing there is a previous code that presents an xdlg to choose the image file and then the path is assigned to these variables and thus the code is still incomplete in explaining these 2 variables.

As to the image size, you could manipulate it any way you want. You could further divide the dimension by any factor to get it small enough. No, ui_bitmap_draw does not blow up. The image is there in cache memory and to see it you have to place it somewhere as for example in an xdlg.

[G Gabriel]

Re: Trouble with ui_bitmap_draw

Disregard. It seems that you already figured it out.

[Peter.Greulich]

Re: Trouble with ui_bitmap_draw

Peter,

Are you saying the code following "here is my code:" does not work? If so, it does work (after adding a "d" to your "im" on line 1). But for it to show the result you have to add the following line at the end.

ui_dlg_box("","{image=combine}")

You can see that it works by changing the rotate statement from right to left of just "".

Raymond Lyons

Ray,

I lost the "d" in the cut & paste. Yeah, the ui_dlg - like, duhhhhh. Thanks for pointing that out. I was so fixated on one thing that I missed the obvious.

---
P.S. Of course, I didn't mean it's "my" code. Just that "the" code wouldn't work w/o the dlg.

[Peter.Greulich]

Re: Trouble with ui_bitmap_draw

Of course it won't work for you Peter...

Ray pointed out my blind spot. Thanks.

[Peter.Greulich]

Re: Trouble with ui_bitmap_draw

David,

Hint: use IMAGE_OPAQUE. This will prevent unhappy flashing when loading or mousing over the dlg.

ui_dlg_box("Display Bitmap", <<%dlg%
{image_opaque=combine}
%dlg%)

[Davidk]

Re: Trouble with ui_bitmap_draw

Thanks Peter... the flashing I noted to tackle in a bit... excellent.

[gagsoft]

Re: Trouble with ui_bitmap_draw

Hi All

I want to change the following code I got from the help file to add a jpg image selected by the user and save it in the database. What is does now, is adding a Black bitmap. Any pointers would be appreciated. Also how can one check if a bitmap exists in the adb

DIM SHARED vSelectedPic as c
DIM SHARED varC_result as C
ok_button_label = "&OK"
cancel_button_label = "&Cancel"
vSelectedPic = ""
varC_result = ui_dlg_box("Selected Image",<<%dlg%
{region}
Chooase An Image:| [%fJPeg (*.jpg)%.40vSelectedPic];
{endregion};
{line=1,0};
{region}
<*15=ok_button_label!OK> <15=cancel_button_label!CANCEL>
{endregion};
%dlg%)
'msgbox("The Selected File","Thefilename is "+vSelectedPic)
'-----------------------------------
IF varC_result = "OK" THEN
dim r as C
dim g as C
dim b as C
dim rd as N
dim gd as N
dim bd as N
dim d as P
dim dn as C
hourglass_cursor(.t.)
dn = a5.Get_Name()
dn = stritran(dn,".adb",".alb")
d = dictionary.open(dn,FILE_RW_EXCLUSIVE)
ui_bitmap_create(vSelectedPic, 1.15,1.15)
d.enter_begin()
d.name = word(file.filename_parse(vSelectedPic,"n"),1,chr(34))
d.type = "GBMP"
f = d.field_get("contents_m")
b1 = ui_bitmap_save(vSelectedPic)
f.value_put(b1)
d.enter_end(.t.)
d.close()
hourglass_cursor(.f.)
ControlPanel.Refresh()
END IF


Thanks
Peter Gagiano