The code hangs

[mougur]

Hi,

I have the code below working normally on my machine, but when I load the program to the customers machine it hangs on the 255th record of the master table or sometimes it raises an index error.

The customer has 2 PCs working XP Pro, 2 notebooks, 1 vista starter, 1 xp home edition.

The master table has about 1000 records. Detail table has about 6000 records.

I couldnot understand why this is happening. Any ideas please ?


The code is;

hourglass_cursor(.T.)

DIM tbl1 as P
DIM tbl2 as P
DIM tbl3 as P
DIM qry1 as P

DIM count_loop as N
count_loop = 1
on error goto error_handler

tbl1 = table.open("carikart")
tbl2 = table.open("carihareket")
tbl3 = table.open("yaslandirma")
'tbl = table.open(table_to_zap, FILE_RW_EXCLUSIVE)
tbl3.zap(.T.)

DIM top_borc as N
DIM hes as C

tbl1.fetch_first()
while .not. tbl1.eof()
   hes = tbl1.Hesap_kodu
   top_borc = 0
   hes_bak = tbl1.Borc_toplami-tbl1.Alacak_toplami
   query.description = "Master Detail"
   query.order = "Tarih"
   query.filter = "Hesap_Kodu = VAR->hes"
   query.options = "D"
	
   qry = tbl2.query_create()
   nrecs = qry.records_get()
   IF (nrecs > 0) then
      tbl2.fetch_first()
      while  top_borc < hes_bak   '(.not. tbl2.eof()) .and.
         if tbl2.Borc > 0 then
	tbl3.enter_begin()
	tbl3.Hesap_kodu = tbl2.Hesap_kodu
	tbl3.Tarih = tbl2.Tarih
	tbl3.Tip = tbl2.Tip
	tbl3.Aciklama = tbl2.Aciklama
	tbl3.Borc = tbl2.Borc
	tbl3.Vade = tbl2.Vade
	top_borc = top_borc + tbl3.Borc
	if top_borc > hes_bak then
		tbl3.Odenen = top_borc - hes_bak
	else
		tbl3.Odenen = 0
	end if
	tbl3.enter_end(.T.)
         end if
         tbl2.fetch_next()
         ' tbl2    
      end while
   end if

   tbl1.fetch_next()
   count_loop = count_loop + 1
' tbl1
end while

qry.drop()
query.order = ""
query.filter = ""
tbl3.close()
tbl2.close()
tbl1.close()

hourglass_cursor(.F.)

end 

error_handler:
    err = error_code_get()
    msg = error_text_get(err)
'    ui_msg_box("Hata var!", msg)

    select
        case err = 800
            msg = msg + "Hata kodu: 800"
            resume next
        case err = 1146
            msg = msg + crlf() + "Kontrol edilemeyen bir hata oluştu..."
            resume next
        case else
            msg = error_text_GET(err)
            ui_msg_box("Bilinmeyen hata - Sıra no: " + str(count_loop), msg, UI_ATTENTION_SYMBOL)
            end
    end select
    ui_msg_box("Hata - Sıra no: " + str(count_loop), msg, UI_ATTENTION_SYMBOL)     
end

[Stan Mathews]

Re: The code hangs

while .not. tbl1.eof()


should be

while .not. tbl1.fetch_eof()

[mougur]

Re: The code hangs

Stan,

Thanks for your immediate answer. I corrected that part of the code ;) But I don't think that this will solve my problem. Because -as far as I can see- the code doesn't hang on the last record of the first table, but in the 255th record. So it needs to fetch about 760 more records for eof() to be true. But I will check it tomorrow in the customers' machines and let you know about the result.

[Tom Cone Jr]

Re: The code hangs

I think this is an issue with the design of your script. You appear to be making the assumption that each step in the script runs to conclusion before any other statements in the script are run. In this script that would be a mistake. Your script starts external disk activity each time it hits the line that runs a query... and each time you begin to enter a new record to tbl3. These external processes are multi-tasked by Windows. The script keeps running even while Windows is finishing the work on the many previous external disk sequences your script begins. I think your script is failing because there are 255 queries and tbl3 updates in the queue and Windows can't multi-task any more queries or updates.

The recommended solution for this is to break your script down into a series of user defined functions. Code inside a UDF will run to conclusion, and the script that calls such a function will "wait" for the return value from udf before moving to the next script statement.

[mougur]

Re: The code hangs

You are right, Tom.

Using UDFs have solved the problem.

Thanks,

[Tom Cone Jr]

Re: The code hangs

Ozgur, thanks for letting us know how things turned out. Good luck with your project.

-- tom