Array out of bounds

[Bruce Roberson]

Ok, I am just a dumb accountant, and I tried to take this example from Barry Rochford in his article "Hurray for an Array"

This is what I got when I tried to run the form:
Script:OnDepart line 10: welllisting=inputf.new_prprty array out of bounds

I have no clue how to fix this to give me the UI box I want to select from the field net_prprty in my table called "mmsprp". Can you help from what I have here?

''XBasic
dim welllisting(15) as c
dim inputf as p
dim name as c
dim global wellname as c
dim i as n
inputf=table.open("mmsprp",file_ro_shared)
i=1
inputf.fetch_first()
while .not. inputf.fetch_eof()
welllisting(i)=inputf.new_prprty
inputf.fetch_next()
i=i+1
end while
name=ui_get_list_array("Select your well",1,"welllisting")
namex=substr(name,1,25)
namex.refresh()
inputf.close()
end

[JerryBrightbill]

RE: Array out of bounds

The error indicates you are trying to populate the array with more values that you have in the definition.

dim welllisting(15) as c

Will allow only 15 entries and you probably have more. If you don't know many many results will be returned, just set the value to a much higher number.

dim welllisting(1000) as c

Or you can find the number of records in the table first and set the array value to that. Find the value first and then dim the array.

recs = inputf.records_get()

dim welllisting(recs) as c

Jerry

[Bruce Roberson]

RE: Array out of bounds

Ok, thanks, that makes sense, because there are hundreds of possible records, so I can set it at 1000 for now.

Thanks again.

[Bruce Roberson]

RE: Array out of bounds

Well, Jerry I still don't quite have it. Here is my revised script after your help last week.

In this attempt, the result message is: "Script:On depart line:17 namex.refresh()argument is incorrect data type"
Why is that the case, I declared my variable namex as a character in line 6 here.

Thanks for your help.

Bruce


''XBasic
dim welllisting(1024) as c
dim inputf as p
dim name as c
dim global wellname as c
dim global namex as c
dim i as n
inputf=table.open("mmsprp",file_ro_shared)
i=1
inputf.fetch_first()
while .not. inputf.fetch_eof()
welllisting(i)=inputf.new_prprty
inputf.fetch_next()
i=i+1
end while
name=ui_get_list_array("Select your well",1,"welllisting")
namex=substr(name,1,25)
namex.refresh()
inputf.close()
end

[Tom Cone Jr]

RE: Array out of bounds


Bruce, these two lines don't make sense to me:

namex=substr(name,1,25) 
namex.refresh()

The first assigns a char string to a char type
variable. Ok so far.

The next attempts to refresh an object on your
form named 'namex'.

The error message suggests to me that maybe there is no
such object on your form.

OR

Perhaps you're referencing the object on your form incorrectly.

The typical approach would be:

:Yourformname:Yourfieldname.refresh()

This also might explain your error message.

-- tom

[Bruce Roberson]

RE: Array out of bounds

Well, all I can tell you at this point is that I began with the subject title on 11-1 of "Forms Help Please" if you want to look back at that.

Someone replied and pointed me to an article online written by Barry Rochford that they thought would be an approach to use.

Having never tried to really do any x-basic work, I basically printed out that example and began trying to adapt it to my situation. I thought I about had it since the dialog box now pops up with my list of wells.

Unfortunately, I am stuck when I got the error message you read about in my previous posting.

Thanks,


Bruce

[Bruce Roberson]

RE: Array out of bounds

Well, all I can tell you at this point is that I began with the subject title on 11-1 of "Forms Help Please" if you want to look back at that.

Someone replied and pointed me to an article online written by Barry Rochford that they thought would be an approach to use.

Having never tried to really do any x-basic work, I basically printed out that example and began trying to adapt it to my situation. I thought I about had it since the dialog box now pops up with my list of wells.

Unfortunately, I am stuck when I got the error message you read about in my previous posting.

Thanks,


Bruce

[JerryBrightbill]

RE: Array out of bounds

Bruce,

As Tom's pints out, the question is what is namex? If it is an object on a form, then the syntax is incorrect on both lines. If it is a variable, then there is not need for the line namex.refresh() as the refresh() command only applies to form or browse objects. Try removing that line, the script should work.

Jerry

[Bruce Roberson]

RE: Array out of bounds

I guess that part was right. Again, I was only following examples that I didn't fully understand.

When I removed the namex.refresh(), then the script stopped bombing.

I'm still not sure the script actually populated the variable like I thought it would.

So, I'll go back to studying what happened and get back here again soon.

Thanks for your help.

[Bruce Roberson]

RE: Array out of bounds

Hot dog!!! That time I made some progress by getting the character value namex on my form.

Now, I'm trying to figure out how in that UI box to get the UI box to display my wells according to an index which would be in alphabetical order rather than by record number.

Again, my UI box is built with:

name=ui_get_list_array("Select your well",1,"welllisting")

[Tom Cone Jr]

RE: Array out of bounds

Ui_get_list_array() displays the array in the natural order of the array elements. To change this, you have to populate the array in the desired sequence to begin with.

Instead of:

inputf=table.open("mmsprp",file_ro_shared)
i=1
inputf.fetch_first()


try:

inputf=table.open("mmsprp",file_ro_shared)
inputf.index_primary_put("Yourindextagnamegoeshere")
i=1
inputf.fetch_first()


(This assumes you have an index defined for the table
in the sequence you need for the array. If not
you need to build one, and then use it's name in the index_primary_put() statement.

-- tom

[Tom Cone Jr]

RE: Array out of bounds

Bruce,

Copying someone else's script can be a great learning tool. It can also be very frustrating if you don't know what the script is doing. I recommend you step through the script one line at a time, with your Xbasic Reference Manual close at hand. Check the manual for each and every line. You'll begin to see how it all fits together.

It's the difference between being given a fish, and learning how to fish for yourself.

-- tom

[Bruce Roberson]

RE: Array out of bounds

I'm not sure how you go about "Stepping" through a script. Are you saying to click view debugger? I haven't probably figured out how to use it properly.

[Tom Cone Jr]

RE: Array out of bounds

Bruce, sorry. I didn't mean to be obscure. When I step through an unfamiliar script I study each line, one line at a time. Until I understand what it's doing I don't go on to the next line in the script.

Incidentally, this board is a great place to get clarificatioin if a particular line remains confusing after consulting the docs.

-- tom

[Bruce Roberson]

RE: Array out of bounds

Thanks Tom, you can be assured I will be around for a while asking goofy elementary questions. I have used Alpha V even when it was the DOS version Alpha IV,but I have never tried to do much with Xbasic.

But with the help of the discussion board, I feel like I will be able to make regular progress in my understanding.

Thanks again,


Bruce