Change in field postion in a DBF-mixed up data

[dchiass]

We use a script to move data from an older version of our application to a newer one. The script is in the new one. The following is the script for one data file. We have about 60 DBF's

'ACCOUNT
'-----------------------------
response = ui_msg_box("Update","Update Account Codes ?",51)
If response = 6 Then
filename = DDIR + "\account.dbf"
result = file.exists(filename)
IF result = .F. THEN
answer = ui_msg_box("","ACCOUNT.DBF File does not exist", UI_OK+UI_STOP_SYMBOL)
ELSE
a_tbl = table.open( "account.dbf")
a_tbl.zap( .T. )
append.t_db = DDIR + "account.dbf"
append.m_key = ""
append.t_key = ""
append.m_filter = ""
append.t_filter = ""
append.type = "All"
append.m_count = 2
append.m_field1 = "ACCOUNT"
append.m_exp1 = "@ACCOUNT->ACCOUNT"
append.m_field2 = "DESCRIPT"
append.m_exp2 = "@ACCOUNT->DESCRIPT"
append.t_count = 0
a_tbl.append()
a_tbl.close()
answer = ui_msg_box("","ACCOUNT.DBF Updated", UI_OK)
END IF
END IF

**************************************************

Both versions have identical structures but the fields are in a different order.

In old version, account.dbf
1.account C10
2.description C20

In NEW version, account.dbf
1.description C20
2.account C10.

We have noticed that data in larger DBF's appear to be going into the wrong field. Dates going into a character field. On some testing, it looks like both files MUST have the same order of fields.

Opinions? Or what mite be causing this.

Thanks.

DeWayne

[Tom Cone Jr]

Suggestions

I think it's possible the data errors are resulting from errors occurring in your script. Before posting this, I created a simple two table database. The tables had identical fieldnames and datatypes, but the order of the fields was different. Alpha Five had no trouble appending records to the correct fields. The different field sequence in the structure of the transaction table did NOT affect the accuracy of the append. This led me to look more closely at your script.

If response = 6 Then
     filename = DDIR + "\account.dbf"
     result = file.exists(filename)
     IF result = .F. THEN
          answer = ui_msg_box("","ACCOUNT.DBF File does not exist", UI_OK+UI_STOP_SYMBOL)
     ELSE
          a_tbl = table.open( "account.dbf")
          a_tbl.zap( .T. )
          append.t_db = DDIR + "account.dbf"

You don't show us what "DDIR" contains. However, in line 1 above, you insert a backslash. In the last line above, you do not. One or the other is wrong. Since the backslash is the line continuation character you may need to "escape" it, probably in both places. Check the help file topic "Backslash, using in expressions".

Next, it's useful to note that your script is not simply appending records. It begins by emptying the master table with the Zap command. Check the help file topic <tbl>.zap(). You will find that to use the Zap method you must open the table for exclusive use, which your script is not doing. When this is fixed you should also consider trapping the error Alpha Five will throw if someone else has the table open.

Next, you may be assuming the script will pause all by itself while zap is finishing its work. Not true. It will keep running. The result may be that the append actually starts (or tries to) while zap is still working. A better approach would pause the script, using xbasic_wait_for_idle(), before beginning the append.

HTH

-- tom