email onSave

[Stan Mathews]

Re: email onSave

That's strange, it's in mine. Attaching again.

[Larry Gordon]

Re: email onSave

OK. I still think we are nearly there, but still getting email sent on any field change in browse, even outside expression parameters. It might be an idea if I review both sets of code for any obvious typo's.

My onfetch code is now:

dim shared col_mr as L
col_mr = .F.
if (Call_Detail->Col_Mr<=(previous("Call_Detail->Col_Mr")+100)).AND.Call_Detail->Code="EM"
col_mr = .t.
end if

My cansave code is:

dim shared col_mr as L
if (Call_Detail->Col_Mr<=(previous("Call_Detail->Col_Mr")+100)).AND.Call_Detail->Code="EM" .AND. (.not. col_mr)
ui_msg_box("Service Note","This call has triggered the escalation procedure")
end if

'email code
parentform.commit()
Actions_ButtonClick("onsave","junk",1)
function Actions_ButtonClick as v( event as C,data as C, row as N)
'get value into variable
dim compiled_values as C
compiled_values="Company: " + parentform:Browse1:Company.value +chr(10) + "Model: " + parentform:Browse1:model.value +chr(10)+ "Serial No: " + parentform:Browse1:Ser_No.value+chr(10)+ "Service Code: "+ parentform:Browse1:code.value+chr(10)+ "Detail: "+ parentform:Browse1:item.value+chr(10)+ "Placed by: "+ parentform:Browse1:pl_by.value+chr(10)+ "Engineer: "+ parentform:Browse1:eng.value
' + "Add1: " + parentform:Browse1:add1.value +chr(10) + "Add2: " + parentform:Browse1:add2.value +chr(10) + "Town: " + parentform:Browse1:town_city.value +chr(10) + "County: " + parentform:Browse1:county.value +chr(10) + "Post Code: " + parentform:Browse1:P_code.value +chr(10) + "Tel: " + parentform:Browse1:mc_tel.value +chr(10)
msgbox(compiled_values)
'email the info
dim pm as P
dim ps as P
if (email_smtp_open(ps,"mail.m-press.biz", 25, "lgordon", "password")) then
pm.to = "[email protected]"
pm.cc = ""
pm.from = "[email protected]"
pm.subject = "Alpha Message"
pm.message = compiled_values
pm.attachments = ""
'pm.html_message = "<b>New Escalation Call</b>"
email_smtp_send(pm,ps)
end if
email_smtp_close(ps)
end function

[Stan Mathews]

Re: email onSave

That's it. Should wrap the whole thing in the if.

dim shared col_mr as L
if (Call_Detail->Col_Mr<=(previous("Call_Detail->Col_Mr")+100)).AND.Call_Detail->Code="EM" .AND. (.not. col_mr)
ui_msg_box("Service Note","This call has triggered the escalation procedure")
'email code
parentform.commit()
Actions_ButtonClick("onsave","junk",1)
end if

function Actions_ButtonClick as v( event as C,data as C, row as N)
'get value into variable
dim compiled_values as C
compiled_values="Company: " + parentform:Browse1:Company.value +chr(10) + "Model: " + parentform:Browse1:model.value +chr(10)+ "Serial No: " + parentform:Browse1:Ser_No.value+chr(10)+ "Service Code: "+ parentform:Browse1:code.value+chr(10)+ "Detail: "+ parentform:Browse1:item.value+chr(10)+ "Placed by: "+ parentform:Browse1:pl_by.value+chr(10)+ "Engineer: "+ parentform:Browse1:eng.value
' + "Add1: " + parentform:Browse1:add1.value +chr(10) + "Add2: " + parentform:Browse1:add2.value +chr(10) + "Town: " + parentform:Browse1:town_city.value +chr(10) + "County: " + parentform:Browse1:county.value +chr(10) + "Post Code: " + parentform:Browse1:P_code.value +chr(10) + "Tel: " + parentform:Browse1:mc_tel.value +chr(10)
msgbox(compiled_values)
'email the info
dim pm as P
dim ps as P
if (email_smtp_open(ps,"mail.m-press.biz", 25, "lgordon", "password")) then
pm.to = "[email protected]"
pm.cc = ""
pm.from = "[email protected]"
pm.subject = "Alpha Message"
pm.message = compiled_values
pm.attachments = ""
'pm.html_message = "<b>New Escalation Call</b>"
email_smtp_send(pm,ps)
end if
email_smtp_close(ps)
end function

[Larry Gordon]

Re: email onSave

It is now working - most of the time, i.e. it all worked perfectly on raising my first two records, but on the third new record I raised,which should have triggered an email, the record saved and closed without an email being sent. I'm not sure why. I will do further testing and try to establish the issue.

I do have one observation/concern though. In the cansave code at the end of line 7, by inserting or removing a space after the .AND. it and the following brackets turn green or black, as per the images below. With the space inserted and the .AND. being black, the event fails completely. Please excuse my ignorance, but is this significant?
1.jpg 2.jpg

[Stan Mathews]

Re: email onSave

You've named the shared variable the same as a table field. That may be confusing the script.

Either rename it in both scripts (just put a v in front) or try referencing it with

if (Call_Detail->Col_Mr<=(previous("Call_Detail->Col_Mr")+100)) .AND. Call_Detail->Code="EM" .AND. (.not. var->col_mr)

Edit: I do see the color change but the script compiles ok either way. Don't know why your're seeing a failure with the space inserted.

[Larry Gordon]

Re: email onSave

Have accordingly renamed the variable and also referenced it and I think its all OK now - though removing/inserting the space still changes the colour as before. I will thoroughly test tomorrow and report back. (Got to go for my dinner now!)

Very many thanks for your fantastic help.

[Larry Gordon]

Re: email onSave

Still progressing Stan, though I have made a few more schoolboy errors along the way! Firstly I renamed the shared variable in my cansave code as advised, but forgot to change it in the onfetch code. I also thought I was getting 'spurious' emails triggered, but these were because I then found these occurred if the col_mr field was blank, as that also satisfies the filter code, so have now added a >0 requirement, and it works properly. I am now trying to add the other fields that have colour equations.

The problem I can't solve is with the 'Call_Detail->Date_Op' field. It works in the colour equation, i.e. triggers the red colour change, but does not trigger an email from the event. (I copied and pasted the code so syntax is the same). My whole cansave 'if' statement is now as follows:

if ((Call_Detail->Date_Op<=(previous("Call_Detail->Date_Op")+7)).OR. (Call_Detail->Col_Mr<=(previous("Call_Detail->Col_Mr")+100).AND.Call_Detail->Col_Mr>0)).AND.Call_Detail->Code="EM" .AND. (.not. vcol_mr)

I have also copied the same filter code into the onfetch event and that is my second query: should I be keeping the 'if' filter the same in both events? Regarding the Date_op field problem, I think my next move is to strip the 'if' statement right back until I can get the date_op equation triggering emails.

[Stan Mathews]

Re: email onSave

should I be keeping the 'if' filter the same in both events?

The if in the onfetch should not have vcol_mr in it, rather it determines how to set vcol_mr. The if in the cansave uses that setting to determine whether or not to send an email. If vcol_mr is already true, don't send.

[Larry Gordon]

Re: email onSave

Sorry, I wasn't clear in my previous post. I do indeed only have the vcol_mr in the cansave statement as per your example.

I'm now finding another problem. When I add another equation to the statement, taking it to 450 characters in length, on triggering the cansave event, I get an error message stating that there are characters missing from my if statement towards the end. I've looked at the documentation and expressions can be much longer than 450 characters, so I'm not sure what is going on here. Is it OK to keep extending a line of code?

[Stan Mathews]

Re: email onSave

You should be able to build an expression to 1023 characters (one reason to keep table and field names as short as possible).

I get an error message stating that there are characters missing from my if statement towards the end

Probably an error in the construction.

[Larry Gordon]

Re: email onSave

I regret that I've had to leave this for a few days - but I'm back! I was starting to go round in circles so I've decided to go back to basics. I've trimmed my expressions back as follows:

Current onfetch event is:
vcol_mr = .F.
if (Call_Detail->Col_Mr<=(previous("Call_Detail->Col_Mr")+100)).AND.Call_Detail->Code="EM"
vcol_mr = .t.
end if

Current onsave event is:
dim shared vcol_mr as L
if (Call_Detail->Col_Mr<=(previous("Call_Detail->Col_Mr")+100)).AND.Call_Detail->Code="EM" .AND. (.not. vcol_mr)
ui_msg_box("Service Note","Date Escalation Triggered")
'And then the email code follows here

On inputting the new record 'test 3' in the jpeg below, the message and email are triggered, even though the record does not satisfy the expression, i.e. the Code field is 'TD' and not 'EM'.

I don't know why this is happening as I'm sure we did have it working before.

Test3.jpg

[Stan Mathews]

Re: email onSave

You need

dim shared vcol_mr as L


in the onfetch, otherwise you're not changing the shared variable. The onsave is reacting to the last value placed in the shared variable.

[Larry Gordon]

Re: email onSave

Sorry Stan. My mistake - I omitted the first line. My actual current onfetch is:

dim shared vcol_mr as L
vcol_mr = .F.
if (Call_Detail->Col_Mr<=(previous("Call_Detail->Col_Mr")+100)).AND.Call_Detail->Code="EM"
vcol_mr = .t.
end if

[Larry Gordon]

Re: email onSave

Started to make some progress again. I had been trying to use onsave event but am now back in cansave, where it works, sort of...
Current cansave code is:

dim shared vcol_mr as L
if (Call_Detail->Col_Mr<=(previous("Call_Detail->Col_Mr")+100)).AND.Call_Detail->Code="EM" .AND.Call_Detail->Col_Mr>0 .AND. (.not. vcol_mr)
ui_msg_box("Service Note","Colour Volume Escalation Triggered")
parentform.commit()
Actions_ButtonClick("onsave","junk",1)
end if
'email code follows

But I've now stumbled across a new challenge. If my Call_Detail->Col_Mr increases from say 60 to 65, the equation correctly triggers. However, it appears that if the same field increases from 995 to 999 it doesn't fire - even though I believe the equation is still satisfied and it should trigger. As I've said before, the colour equations all work, and with any number of digits. Am I missing something, i.e. should I be defining field sizes for the cansave equation?

[Stan Mathews]

Re: email onSave

Anything that changes a value triggers the cansave and onsave events. Doesn't matter whether is it by 1 or 5.

More accurate to say that changing a value and moving to another record fires the cansave and onsave. The color equation will affect the browse cell immediately upon moving out of the cell even when staying in the same row.