Modifying action javascript after converted to text mode if else

[bob9145]

Trying to add an if, else statement to a on click action javascript crud action after it has been converted to text mode. Then performing an incremental refresh. Also using
the this, then that sequencing. Can't get this to work, the first part executes if Email_P is null, and I get the alert, but if Email_P has a value the rest of the block does not execute. Can this be done? Not sure how the nesting should be bracketed? Is this a good practice? Is there a better way to approach this?

var email_check = {dialog.Object}.getValue('Email_P');
if (email_check == '')
{
alert("Customer must have an email to add them to your team, edit the referral an add a valid email");

}
else {




function tempfunction_d441b5ba_22cf_4fd7_b4e8_e24bbb40bdaa() {

{dialog.object}.ajaxCallback('','','system:CRUDaction','','_xbfunction=CRUDAction_533968d9a516412d90d7947a734df97d');
}

function tempfunction_c790a8a4_2cfa_4816_bb8a_0aa378c30d5b() {
{dialog.object}.refreshListData('VR_REFERRALS',{mode: 'incremental'});






A5.executeThisThenThat(tempfunction_d441b5ba_22cf_4fd7_b4e8_e24bbb40bdaa,tempfunction_c790a8a4_2cfa_4816_bb8a_0aa378c30d5b);
}
}

[Davidk]

I would dump the function names and make them more palatable. Then, indent properly and you'll see your error. Your code, properly indented...

var email_check = {dialog.Object}.getValue('Email_P');
if (email_check == ''){
	alert("Customer must have an email to add them to your team, edit the referral an add a valid email");
}else{
	function call_crudAction() {
		{dialog.object}.ajaxCallback('','','system:CRUDaction','','_xbfunction=CRUDAction_533968d9a516412d90d7947a734df97d');
	}

	function call_refreshList() {
		{dialog.object}.refreshListData('VR_REFERRALS',{mode: 'incremental'});
		A5.executeThisThenThat(call_crudAction,call_refreshList);
	}
}

You see that the executeThisThenThat is inside the function.

Corrected code...

var email_check = {dialog.Object}.getValue('Email_P');
if (email_check == ''){
	alert("Customer must have an email to add them to your team, edit the referral an add a valid email");
}else{
	function call_crudAction() {
		{dialog.object}.ajaxCallback('','','system:CRUDaction','','_xbfunction=CRUDAction_533968d9a516412d90d7947a734df97d');
	}

	function call_refreshList() {
		{dialog.object}.refreshListData('VR_REFERRALS',{mode: 'incremental'});
	}
	
	A5.executeThisThenThat(call_crudAction,call_refreshList);
}

[bob9145]

Gotcha,
Thank you!

[bob9145]

Corrected the javascript. However couldn't get it to work. So I took a step backwards and just converted the actions to text mode without adding the if/else statement, and, published it, and tried it, no go.
So it works in action javascript, but not after it is converted to text mode. Is there something else that needs to be done? This is two actions and the this then that statement

function tempfunction_4c4097c3_4449_42b3_9def_3f642603213a() {

{dialog.object}.ajaxCallback('','','system:CRUDaction','','_xbfunction=CRUDAction_533968d9a516412d90d7947a734df97d');
}

function tempfunction_3188a89e_75d7_48f4_a652_f6d87ea6ca36() {
{dialog.object}.refreshListData('VR_REFERRALS',{mode: 'incremental'});



}


A5.executeThisThenThat(tempfunction_4c4097c3_4449_42b3_9def_3f642603213a,tempfunction_3188a89e_75d7_48f4_a652_f6d87ea6ca36);

Simplified it and tried just this still no go

function tempfunction_4c4097c3_4449_42b3_9def_3f642603213a() {

{dialog.object}.ajaxCallback('','','system:CRUDaction','','_xbfunction=CRUDAction_533968d9a516412d90d7947a734df97d');
}

Left the function names as is didn't want to mess with that until I got it working. Using version 3962 build 4772.
-the button is in the detail view of a list control and I m inserting a record into one of the tables that the list is pulled from it's based on a join, so the list record is altered hence the need for the refresh, for more context.

[bob9145]

this was a miss fire

[Davidk]

this was a miss fire

Not sure what that means.

[bob9145]

sorry " this was a misfire" was a reply in error and couldn't delete so I just edited it. Kinda like when you send a text to the wrong girl friend. :)

[bob9145]

Created a fresh button control and got it working awful touchy. Guess the control was corrupted some how.