FTP Run Silent memory/storage problems

[chortle]

I have a set of scripts, functions and operations performing price updates to my database. It is run on a timer every 20 seconds. The function below runs OK for the first few times it is called and then it just stops. It would seem I am having memory or storage problems when I use this ftp batch script.

If I run it manually I get an error message that is attached.

Any idea how I can fix this?

Thanks

'-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------

FUNCTION ftpbatchscript AS C (Address as C, User as C, Password as C, Source_File as C, Destination_File as C , unused_Modal =.t., unused_Title="" )

'Description:Similar to A5 function, but no dialogs are used so it can run unattended. Always runs modal. just return value.
'the difference with a5 function is so this can run modally and silently in xbasic, with no need to respond to dialogs.
'unused_Title parameter is not used because there are no dialogs. retained for parameter compatibility.
'always run modal=.t. so there is no need to deal with FTPstatus parameter.

'filename is case sensitive

dim datefield as c=dtos(date())
dim fns as c = "/prices/"+alltrim(datefield)+"//"+datefield+"_hour"+left(time(),2)+".csv"
dim fnd as c = a5.get_path()+"\prices\"+"checkprices.csv"

Dim ftpscript as C
Dim vReturn as C

ftpscript = <<%code%
connect|[url]
onerror|error|Could not connect
login|[user]|[pw]
onerror|error|Could not log in
get|[sourcefile]|[destfile]
onerror|error|Could not transfer file
quit
%code%

ftpscript = stritran(ftpscript,"[url]",address)
ftpscript = stritran(ftpscript,"[user]",user)
ftpscript = stritran(ftpscript,"[pw]",password)
ftpscript = stritran(ftpscript,"[sourcefile]",source_file)
ftpscript = stritran(ftpscript,"[destfile]",destination_file)

vReturn = ftp_script_run_silent(ftpscript, .t.)
ftp_get_filex = vReturn

END FUNCTION

[Al Buchholz]

Re: FTP Run Silent memory/storage problems

That's a really fast turnaround. How long does each transfer take?

Especially since you are starting and ending an ftp connection each time.

You may want to add/look at some logging to get some idea of timing.

[chortle]

Re: FTP Run Silent memory/storage problems

Hi Al,

I accept that it is a fast FTP request time. Maybe, I should try 60 secs instead. I will test this and let you know.

I would like to look at a log of activity and timing issues, but don't have enough xbasic knowledge to add this to my routines.
Please could you help me do this?

Thanks,

Paul

[madtowng]

Re: FTP Run Silent memory/storage problems

file.append_line(<complete_filename>,time(<your time format>,now())+" <event> "+ <event message>

This is a simple way to create a log file. I use this in many of my scripts/functions to let me know how things are going.
here is a brief example.

dim filenameftp as c = "c:\myalphalogs\ftplog.txt"
dim ftpbtime as t
dim ftpftime as t

ftpbtime=now()
file.append_line(filenameftp,time("yyyy-MM-dd 0h:0m:0s",ftpbtime)+" Ftp started "+ "message with ftp start"
'put your ftp code in this section

ftpftime = now()
file.append_line(filenameftp,time("yyyy-MM-dd 0h:0m:0s",ftpftime)+" Ftp Finished "+ "message with ftp finish"

I used the time variables incase you want to let alpha calculate the elapsed time (ftpftime-ftpbtime).
I have also been know to have the scripts/functions email those times to me.

[chortle]

Re: FTP Run Silent memory/storage problems

Thanks Gregg,

Will give it a go.

Great support on here :)

Paul

[chortle]

Re: FTP Run Silent memory/storage problems

Tried 60 secs but made no difference.

Changed routines to use standard ftp_get instead of run silently but problem still remains - see new error message.

Am thinking that it must be an already open table which is not closed quickly enough before another script tries to access it, or my compiled autohotkey script which doctors the content of the downloaded checkprices.csv file before importing it (i.e. removes bulk of prices already processed or at times corrupted).

Gregg, could you actually send a working script for your log file idea?

Thanks,

Paulftp_getscriptCapture.JPG

[chortle]

Re: FTP Run Silent memory/storage problems

Sorry Gregg, Got it working with what you already have provided :)

Batch script seems to be OK, so error is elsewhere. Will insert you log routine systematically in all scripts and try to pinpoint issue.

Thanks

[madtowng]

Re: FTP Run Silent memory/storage problems

Glad I could help at least a little bit.
Have you tried to ftp the file using command prompt ?

[chortle]

Re: FTP Run Silent memory/storage problems

Thanks to all. I discovered that because I did not close a text file (a parameter file) I created and wrote the latest filtering parameters to in xbasic before calling the various necessary operations, scripts, etc. it screwed up later processes
Essentially, that after a short number of 'file.create' executions Alpha does not have a meaningful error message to display, except probably to fall over and mention the last error return variable in it's message...

Garry, your logfile suggestion worked a treat :)

Paul