Checking And Saving A File In S3

[TheDuke]

Re: Checking And Saving A File In S3

function itemName as c (e as p)
'-- checks to see if filename exists in S3

dim ConnectionString as C = "Provider='Disk';Container='Z:\items';"
dim ResultData as B
dim ContentType as C
dim Container as A5Storage::DataContainer = null_value()
dim Item as A5Storage::DataItem = null_value()
dim newName as c = e._itemName
dim URL as c
dim sql as c
dim args as sql::arguments
dim flag as l

dim globalcn as sql::connection
flag = globalcn.open("::Name::conn")

args.set("CURRENTITEMID", e.dataSubmitted.itemid)
CallResult = A5Storage::DataContainer::Open(Container, \
"Provider='Disk';Container='Z:\items';")
if CallResult.Success then
if Container.ItemExists(newName") then
newName = newName + "1"
end if
Item.SaveToFile("Z:\items\"+newName)
URL = "https://s3.amazonaws.com/items/" + newName
sql = "UPDATE items SET URL = '" + URL + "' where ID = :CURRENTITEMID"
flag = globalcn.execute(sql,args)
end if

globalcn.close()

end function

[swest]

Re: Checking And Saving A File In S3

Still getting the XHR Error, this is what I have: What do you use to check if filename exists in S3?

function ItemName as v (e as p)
'-- checks to see if filename exists in S3

dim ConnectionString as C = "Provider='Disk';Container='Z:\items';"
dim ResultData as B
dim ContentType as C
dim Container as A5Storage::DataContainer = null_value()
dim Item as A5Storage::DataItem = null_value()
dim newName as c = e._itemName
dim URL as c
dim sql as c
dim args as sql::arguments
dim flag as l

dim globalcn as sql::connection
globalcn.open("::Name::conn")

args.set("CURRENTITEMID", e.dataSubmitted.itemid)
CallResult = A5Storage::DataContainer::Open(Container, \
"Provider='Disk';Container='Z:\items';")
if CallResult.Success then
if Container.ItemExists("e._itemName") then
newName = newName + "1"
end if
Item.SaveToFile("Z:\items\"+newName)
URL = "https://s3.amazonaws.com/items/" + newName
sql = "UPDATE items SET URL = '" + URL + "' where ID = :CURRENTITEMID"
flag = globalcn.execute(sql,args)
end if

globalcn.close()

end function

[TheDuke]

Re: Checking And Saving A File In S3

As I said before, I don't use these methods so maybe someone else will chime in that has experience. According to the documentation, .ItemExists is how to determine if the file is already there. For now, let's add some return javascript to see if we can get more info on the error (revised function below). Beyond that, I'd turn off security and debug the function.


function itemName as c (e as p)
'-- checks to see if filename exists in S3

dim ConnectionString as C = "Provider='Disk';Container='Z:\items';"
dim ResultData as B
dim ContentType as C
dim Container as A5Storage::DataContainer = null_value()
dim Item as A5Storage::DataItem = null_value()
dim newName as c = e._itemName
dim URL as c
dim sql as c
dim args as sql::arguments
dim flag as l
dim js as c

dim globalcn as sql::connection
flag = globalcn.open("::Name::conn")
if flag = .f. then
js = "A5.msgBox.show('Error','Error reported was: " + js_escape(globalcn.CallResult.text) + "','o');"
itemName = js
exit function
end if

args.set("CURRENTITEMID", e.dataSubmitted.itemid)
CallResult = A5Storage::DataContainer::Open(Container, \
"Provider='Disk';Container='Z:\items';")
if CallResult.Success then
if Container.ItemExists(newName") then
newName = newName + "1"
end if
Item.SaveToFile("Z:\items\"+newName)
if .not. Item.SaveToFile("c:\mydata.jpg)
js = "A5.msgBox.show('Error','Error reported was: " + js_escape(Item.CallResult.text) + "','o');"
end if
URL = "https://s3.amazonaws.com/items/" + newName
sql = "UPDATE items SET URL = '" + URL + "' where ID = :CURRENTITEMID"
flag = globalcn.execute(sql,args)
else
js = "A5.msgBox.show('Error','Could not open container.','o');"
end if

globalcn.close()

itemName = js

end function

[TheDuke]

Re: Checking And Saving A File In S3

I also notice you still have the function set as void. Change it to return a character string as in my example.

[TheDuke]

Re: Checking And Saving A File In S3

At this point I've exhausted my resources. If the revised function above doesn't return any useful information about the error then why don't you just debug it in your browser?

[Davidk]

Re: Checking And Saving A File In S3

As I said before, I don't use these methods so maybe someone else will chime in that has experience. According to the documentation, .ItemExists is how to determine if the file is already there. For now, let's add some return javascript to see if we can get more info on the error (revised function below). Beyond that, I'd turn off security and debug the function.


function itemName as c (e as p)
'-- checks to see if filename exists in S3

dim ConnectionString as C = "Provider='Disk';Container='Z:\items';"
dim ResultData as B
dim ContentType as C
dim Container as A5Storage::DataContainer = null_value()
dim Item as A5Storage::DataItem = null_value()
dim newName as c = e._itemName
dim URL as c
dim sql as c
dim args as sql::arguments
dim flag as l
dim js as c

dim globalcn as sql::connection
flag = globalcn.open("::Name::conn")
if flag = .f. then
js = "A5.msgBox.show('Error','Error reported was: " + js_escape(globalcn.CallResult.text) + "','o');"
itemName = js
exit function
end if

args.set("CURRENTITEMID", e.dataSubmitted.itemid)
CallResult = A5Storage::DataContainer::Open(Container, \
"Provider='Disk';Container='Z:\items';")
if CallResult.Success then
if Container.ItemExists(newName") then
newName = newName + "1"
end if
Item.SaveToFile("Z:\items"+newName)
if .not. Item.SaveToFile("c:\mydata.jpg)
js = "A5.msgBox.show('Error','Error reported was: " + js_escape(Item.CallResult.text) + "','o');"
end if
URL = "https://s3.amazonaws.com/items/" + newName
sql = "UPDATE items SET URL = '" + URL + "' where ID = :CURRENTITEMID"
flag = globalcn.execute(sql,args)
else
js = "A5.msgBox.show('Error','Could not open container.','o');"
end if

globalcn.close()

itemName = js

end function

I can't see how this code runs... or could have been tested... as there are syntax errors within the code.

Does it run successfully?

[swest]

Re: Checking And Saving A File In S3

No it isnt working. Seems kind of complex on what is trying to be achieved here.

[TheDuke]

Re: Checking And Saving A File In S3

Instead of using this function, why not use the builtin 'File Upload - Amazon S3 Storage or Alpha Anywhere Server' action javascript? You should get a unique file name prior to uploading and not try to append something if it already exists on S3. If you want to upload fname and it exists then you're wanting to make it fname1 but what if that exists? Then you've got fname11, fname111... where does it end? Use a unique id from the table you're storing the image path in.

[Davidk]

Re: Checking And Saving A File In S3

No it isnt working. Seems kind of complex on what is trying to be achieved here.

It's actually a little unclear what you want to achive. The post title reads "Checking and Saving a File In S3" but none of the code posted gets anywhere near an S3 Bucket.

Do you want to check a file upload against an S3 Bucket to determine if the filename being uploaded already exists in S3?
Do you want to check a file upload against a local folder of files?

[swest]

Re: Checking And Saving A File In S3

Yes want to check in a S3 bucket to see if a file name already exists and if it does rename that file so it doesn’t overwrite the existing file. So if truck.jpg already exists and another user is uploading truck.jpg then it automatically renamed it to truck1.jpg or something.

[Davidk]

Re: Checking And Saving A File In S3

Yes want to check in a S3 bucket to see if a file name already exists and if it does rename that file so it doesn’t overwrite the existing file. So if truck.jpg already exists and another user is uploading truck.jpg then it automatically renamed it to truck1.jpg or something.

I'm assuming you're using the File Upload - Amazon S3 Storage Action... since I believe it's the only File Upload Action containing an After file select event... but you don't actually confirm it. If that's the case, and as David suggests, use the "Target object name of Amazon S3" property to give the file a unique name... a timestamp... a prefix/suffix... something.

[swest]

Re: Checking And Saving A File In S3

Would I do an ajax callback to a XBasic function to set the e.name to something else? Maybe set a variable to id which is a primary key in my table and then do like newName = e.name + id?

[swest]

Re: Checking And Saving A File In S3

How would I though change the name of the physical file that is uploaded to S3? Would I return newName from the XBasic function set e.name in "Target object name of Amazon S3"?

[Davidk]

Re: Checking And Saving A File In S3

You can do pretty anything you'd like... just return whatever name you come up with. E.g. If I choose apple.jpg and I have a counter namespace variable going... then I can do this...

var ulCnt = {dialog.Object}.__S3Cnt;

var arr = e.name.split('.')
arr[0] = arr[0] + '_' + ulCnt + '_' + A5.ts();
var name = arr.join('.');

{dialog.Object}.__S3Cnt = ulCnt + 1;

return name;

which will result in a completely unique S3 filename of...

apple_1_jdsbyrk5.jpg

[swest]

Re: Checking And Saving A File In S3

I put this below in "Target object name of Amazon S3' but am still getting XHR error:

var ulCnt = {dialog.Object}.__S3Cnt;

var arr = e.name.split('.')
arr[0] = arr[0] + '_' + ulCnt + '_' + A5.ts();
var name = arr.join('.');

{dialog.Object}.__S3Cnt = ulCnt + 1;

return name;