Why does this script not work?

[Graham Wickens]

The following script works fine when run from code editor, but when I try to run it from a "right_click_menu" attached to a browse on "gns_work_file" it throws up an error "no such table error occured at line 28" the tbl.copy() statement. What am I doing wrong please?
thanks in anticipation

'Date Created: 18-May-2005 05:50:07 PM
'Last Updated: 24-May-2005 04:46:33 PM
'Created By :
'Updated By :
on error goto error_routine
dim tbl as p
tbl = table.open("my airfields", FILE_RW_EXCLUSIVE)
tbl.zap(.t.)
tbl.close()
temporary_table = file.temp_path_get()+"temp_table.dbf"
tbl = table.open("gns_work_file")
query.filter = "left(Dsg,len(\"air\")) = \"air\""
query.order = "recno()"
tbl.query_create()
copy.set = ""
copy.db = temporary_table
copy.dd = .F.
copy.delete_o_dd = .F.
copy.records = .T.
copy.fields = 7
copy.field1 = "GNS_WORK_FILE-"FULL_NAME"
copy.field2 = "GNS_WORK_FILE-"AREA"
copy.field3 = "GNS_WORK_FILE-"ADM1"
copy.field4 = "GNS_WORK_FILE-"DMS_LAT"
copy.field5 = "GNS_WORK_FILE-"DMS_LONG"
copy.field6 = "GNS_WORK_FILE-"DSG"
copy.field7 = "GNS_WORK_FILE-"SORT_NAME"
tbl.copy()
a_tbl = table.open("my airfields")
append.t_db = temporary_table
append.m_key = ""
append.t_key = ""
append.m_filter = ""
append.t_filter = ""
append.type = "All"
append.m_count = 7
append.m_field1 = "Dms_Lat"
append.m_exp1 = "@temp_table-"dms_lat"
append.m_field2 = "Dms_Long"
append.m_exp2 = "@temp_table-"dms_long"
append.m_field3 = "Dsg"
append.m_exp3 = "@temp_table-"dsg"
append.m_field4 = "Adm1"
append.m_exp4 = "@temp_table-"adm1"
append.m_field5 = "Sort_Name"
append.m_exp5 = "@temp_table-"sort_name"
append.m_field6 = "Full_Name"
append.m_exp6 = "@temp_table-"Full_name"
append.m_field7 = "Area"
append.m_exp7 = "@temp_table-"Area"
append.t_count = 0
a_tbl.append()
a_tbl.close()
tbl.close()
end
error_routine:
err_msg = error_text_get(error_code_get())
script = error_script_get()
line = error_line_number_get()
ui_msg_box("Error",err_msg+" error occured at line "+alltrim(str(line,4,0))+" in Script "+alltrim(script))
end

[Stan Mathews]

RE: Why does this script not work?

The only thing I can see is something TC often warns against, namely the reuse of a pointer within one script

tbl = table.open("my airfields", FILE_RW_EXCLUSIVE)

tbl = table.open("gns_work_file")

You might give altering that a try.

[Tom Cone Jr]

RE: Why does this script not work?

Graham,

If it were me, I'd break the script down into its major components, and test each separately. i.e. the zap, the copy, the append.

Then, I'd combine them, using xbasic_wait_for_idle() statements to separate them from each other.

You may have a timing issue here. For example, the table being zapped may still be "in process" by the time the script tries to open it again.

It's difficult to do, but each time a script sets some process in motion (like zap, copy, or append) you must NOT assume the script itself is going to pause until the zap, copy, or append is finished. Cause it won't.

As Stan has already noted, I think it's asking for trouble to re-use pointer names. If you must, I suggest you delete the pointer, and recreate it using a dim statement.

I also avoid tablenames that include blank spaces, such as you are using here. The question that troubles me is this:

Does Alpha think:
"My Airfield"
is the same as
"My_Airfield"

To me they are very different. Usually Alpha sees them as being the same. But not always, or so it seems to me. My personal rule now is to never use blank spaces. Instead use the underscore character.

-- tom

[Graham Wickens]

RE: Why does this script not work?

ok Guys,

I take your points, but why does this script work perfectly when run from the code page, but gives this error when run from a "right-click-menu"

[Tom Cone Jr]

RE: Why does this script not work?

I don't know. It may be a naming conflict caused by more than one instance of a table being open at the same time. If any of the tables are open supporting the current form, you might try using alias names instead of actual table names. -- tom

[JerryBrightbill]

RE: Why does this script not work?

After the

tbl.copy()

try

tbl.close()

before running the append. Not only do you not need it open for the append, the append may not work since the table is open in another instqance (the first tbl.open)

Jerry

[Graham Wickens]

RE: Why does this script not work?

by process of trial-and-error, I got it to work from the "right-click-menu" by making the following change to the script:

tbl = table.open("gns_work_file")
TO
tbl_1 =table.current()

It did not like two copies of "gns_work_file" opened at once for some reason.

thanks for the help.

[Tom Cone Jr]

RE: Why does this script not work?

My guess: the second copy would have been assigned a different alias name, so the field identifiers you use in setting up the copy don't match the alias name, since you use the actual table name.

-- tom