Action Script/XBasic

[davej]

Sorry, I forgot the paragraph tags in the HTML.

I created a button on a form to terminate an employee. I followed the steps in the Introduction to Action Scripting manual and everything works as it should.
When I copy the XBasic copy and paste in into an icon on the custom toolbar that will go with the form. the code doesn't work properly! When I click the icon the three-choice dialog box appears. 'Cancel' works, 'No' works partically (the Note dialog box does not appear), and the Status is not changed, which is correct. The 'Yes' button does not work at all! Here is the code for anyone who want to take a hack at it.
I've gone over it and over it, and I cannot find what is wrong.

[code]
'Displays a message box (style:'Yes, No, Cancel Buttons', image: 'Question symbol', id: 'terminate').
DIM SHARED terminate_result as N
DIM SHARED terminate_YES_Button as L
DIM SHARED terminate_NO_Button as L
DIM SHARED terminate_CANCEL_Button as L
terminate_YES_Button = .F.
terminate_NO_Button = .F.
terminate_CANCEL_Button = .F.

title_var = "Terminate employee"
message_text_var = terminate_NO_Button=.t.") THEN
'Displays a message box (style:'OK Button', image: 'Information symbol', id: 'notterminated').
DIM SHARED notterminated_result as N
DIM SHARED notterminated_OK_Button as L
notterminated_OK_Button = .F.

title_var = "Note"
message_text_var = I'm just starting to get into the new Action Scripting, and I would really like to know what I did wrong.

Thanks


Dave

[Keith Hubert]

RE: Action Script/XBasic

Hi Dave

Back in the Beta days I wanted to press a button which opened a dialog box with 2 radio buttons for the use to choose New or Old, New would open a blank form. Old would open another dialog box that has 3 criteria boxes so that the user could find the old record by name or number etc. Selwyn the Great helped me with all this. What I learnt was that you had to give consideration to what you dont want to happen first.

Here is the the script that opens the first New or Old dialog the script_play_local("xdialog1") is the second dialog for the user to enter what is required. I hope this helps you as it did me.

Keith Hubert
London.

NEW_OR_OLD = ui_get_radio("New or Old Record","New","New","Old")

if new_or_old = "new" then
p = form.view("header")
p.New_Record()
topparent.close()
else 'user chose 'old'
'xdialog1 is an action script that prompts for three variables: job_ref, postal_code, and surveyor_name.
'you can change the title and prompts on the dialog by editing the xdialog1 script.
dialog:
script_play_local("xdialog1")
'varc_result is the name of the variable that is created when the "xdialog1" script plays. it contains "OK" or "cancel"
'depending on which button the user pressed to close the dialog
if varc_Result = "Cancel" then
end
end if
if varc_Result = "OK" then
if (vc_job_ref "" ) .and. (vc_postal_code = "" .and. vc_surveyor_name = "") then
filter_string = "job_ref = " + quote(vc_job_ref)
else if (vc_postal_code "" ) .and. (vc_job_ref = "" .and. vc_surveyor_name = "") then
filter_string = "post_code = " + quote(vc_postal_code)
else if (vc_surveyor_name "" ) .and. (vc_job_ref = "" .and. vc_postal_code = "") then
filter_string = quote(vc_Surveyor_Name) + " $ surveyor_name1)"
else
ui_msg_box("Error","You must specify just one search value.",UI_STOP_SYMBOL)
filter_string = ""
if filter_string = ""
vc_job_ref = ""
vc_postal_code = ""
vc_surveyor_name = ""
goto dialog
end if
end if
if filter_string "" then
p = form.ViewQueried("quote",filter_string)
'topparent.Hide()
end if
else
'user pressed cancel. so do nothing. just end the script.
end
end if
end if

[Keith Hubert]

RE: Action Script/XBasic

Just so you can see how greate the dialog box scipt works, and is so simple to create here it is.
All thanks to Selwyn.

Keith Hubert
London.

'Create an XDialog dialog box to prompt for parameters.
DIM SHARED vc_job_ref as C
DIM SHARED vc_postal_code as C
DIM SHARED vc_surveyor_name as C
DIM SHARED varC_result as C
vc_job_ref=""
vc_surveyor_name=""
varC_result=""
heading_string = "Type in details in one box and press OK or Cancel to stop."
ok_button_label = "&OK"
cancel_button_label = "&Cancel"
varC_result = ui_dlg_box("Quote Search",
{endregion};
%dlg%)

[davej]

RE: Action Script/XBasic

Keith,

Thanks for your input. I'll keep the code and learn from it. Action Scripting looks to be just my thing, if I get a good handle on it.

Dave

[CALocklin]

RE: Action Script/XBasic

Dave, I'm certainly no authority here but as I recall the "parentform" (and presumably "topparent") doesn't work as expected when the button is on the toolbar because the "focus" is different. If memory serves me correctly, I believe someone said you should substitute "this" instead.

[Peter.Greulich]

RE: Action Script/XBasic

Cal,

You are correct. If memory serves me, this was in the 4.5 documentation (and earlier). Toolbars "inherit" the forms alias.

Peter

[davej]

RE: Action Script/XBasic

Thanks. I forgot that.

Dave