topparent.command("RECORD_COMMIT") does not raise error

[atchut]

I am using topparent.command("RECORD_COMMIT") and when the statement failed to save record (lets say because failure of field rule) it does not raise error. The "On Error Goto" is not working. The Control does not go to error handler.

Any Suggestions highly appreciated.

This is the code I have
----------------------

on error goto rule_err
dim commit_flag as L
commit_flag = .t.

topparent.command("RECORD_COMMIT")

IF COMMIT_FLAG = .T. THEN
DisableButtons("EnterSave")
DisableButtons("EnterCancelChanges")
EnableButtons("Enternewrecord")
EnableButtons("Btnefile")
EnableButtons("EnterPrint")
END IF
end

'----------
rule_err:
commit_flag = .f.
resume next

[Tom Cone Jr]

Atchut, I'm sorry but I don't recognize the commands you're using. Cannot find a form method called

.command()

Were you thinking of

topparent.commit()

??

-- tom

[Kanaka]

Hello all,

topparent.command("RECORD_COMMIT") is the command we get when you are in xbasic script editor and click on the genie and then choose to do a menu commands action from the options.

'Execute menu command: 'RECORD_COMMIT'.
topparent.command("RECORD_COMMIT")

is the code that is displayed to be inserted in the editor.

I was also looking for trapping that kind of errors.

How is that accomplished?

I am basically trying to capture the field is required error to put a custom errror message.

Thanks in advance.
Kanaka.

[Tom Cone Jr]

Kanaka,

I'm sorry to say that I don't have experience using the command you're referencing. However, the required field rule is one that I routinely avoid. It is relentless.

In situations where I do not want a record to be saved unless a particular field is "filled in" by the user, I accomplish the same thing as the "required field" field rule by writing a short script in the CanSaveRecord event in field rules. This event will fire just before the pending changes are committed.

A sample script might be something like this in a case where I do not want the "Lastname" field left blank:

'CanSaveRecord event script 
tbl = table.current()
if tbl.lastname = "" then   'field is empty
   ui_msg_box("Oops","You must fill in the Lastname field before saving the record.")
   cancel()
end if

The cancel() function will cancel the pending commit. The msg box tells the user what is needed.

-- tom

[Kanaka]

Kanaka,

I'm sorry to say that I don't have experience using the command you're referencing. However, the required field rule is one that I routinely avoid. It is relentless.

In situations where I do not want a record to be saved unless a particular field is "filled in" by the user, I accomplish the same thing as the "required field" field rule by writing a short script in the CanSaveRecord event in field rules. This event will fire just before the pending changes are committed.

A sample script might be something like this in a case where I do not want the "Lastname" field left blank:

'CanSaveRecord event script 
tbl = table.current()
if tbl.lastname = "" then   'field is empty
   ui_msg_box("Oops","You must fill in the Lastname field before saving the record.")
   cancel()
end if

The cancel() function will cancel the pending commit. The msg box tells the user what is needed.

-- tom

Thank you Tom,
I have found from other messages about the same solution you have proposed above.
I am really curious if anyone else can help me out with this. I suppose no one has used the menu commands so much since they are restricted from trapping errors from their code when they use these commands.
I found a similar plea for help from another message about command. Apparently there were no replies.
http://msgboard.alphasoftware.com/al...ad.php?t=48986
I am not trying to be lazy here but with all the time it takes to change my almost finished program, I feel I should shout out for help.
There is one thing else I wanted to point out to you that, if you set a field as required in the field rules we can set the validation in the validation tab as
Lastname="" and your custom message. I found out all of this too after posting this message. Oh well, now I have things to do either way.

Thanks for all the help.

Kanaka.

[CALocklin]

How about something like the following. I think it's much simpler and more intuitive. I use this method quite a bit. The need for "xbasic_wait_for_idle()" seems to come and go so you may have to try it with and without but it should generally be safe to go "with".

parentform.commit()
xbasic_wait_for_idle()

IF parentform.mode_get() = "VIEW"
......

[CALocklin]

How about something like the following. I think it's much simpler and more intuitive. I use this method quite a bit. The need for "xbasic_wait_for_idle()" seems to come and go so you may have to try it with and without but it should generally be safe to go "with".

parentform.commit()
xbasic_wait_for_idle()

IF parentform.mode_get() = "VIEW"
......

[CALocklin]

How about something like the following. I think it's much simpler and more intuitive. I use this method quite a bit. The need for "xbasic_wait_for_idle()" seems to come and go so you may have to try it with and without but it should generally be safe to go "with".

parentform.commit()
xbasic_wait_for_idle()

IF parentform.mode_get() = "VIEW"    'It's saved.
......