topparent.close not closing form

[jkletrovets]

Greetings all

I have a simple table that is displayed in an embedded browse to the user. If the user wishes to edit one of the records - they highlight it and press a "Change Record" button. This opens an edit form (modal). After making the needed corrections the user presses a "Save and Close" button. My problem is that the record gets saved properly and the user is returned to the calling form (as they should be). However, the screen they used to edit the record stays open in the Alpha bar showing the open windows in the app. Below is relevant part of the "Save and Close" button.

Anyone have any ideas?

Thanks,

Jeff

topparent.command("RECORD_COMMIT")
'**********************************************
'Close current form or browse window.
DIM mode as c
mode = parentform.mode_get()
'If the form is in Enter or Change mode, first save the changes before closing the form
if mode = "ENTER" .or. mode = "CHANGE" then
parentform.commit()
'Check to see if the record was successfully saved
if parentform.mode_get()<>"VIEW" then
ui_msg_box("Unable to save your changes","Please correct and save, or discard your changes", UI_STOP_SYMBOL)
end
end if
end if
'Close the form
topparent.close(.f.)

[Stan Mathews]

Re: topparent.close not closing form

Greetings all

I have a simple table that is displayed in an embedded browse to the user. If the user wishes to edit one of the records - they highlight it and press a "Change Record" button. This opens an edit form (modal). After making the needed corrections the user presses a "Save and Close" button. My problem is that the record gets saved properly and the user is returned to the calling form (as they should be). However, the screen they used to edit the record stays open in the Alpha bar showing the open windows in the app. Below is relevant part of the "Save and Close" button.

Anyone have any ideas?

Thanks,

Jeff

topparent.command("RECORD_COMMIT")
'**********************************************
'Close current form or browse window.
DIM mode as c
mode = parentform.mode_get()
'If the form is in Enter or Change mode, first save the changes before closing the form
if mode = "ENTER" .or. mode = "CHANGE" then
parentform.commit()
'Check to see if the record was successfully saved
if parentform.mode_get()<>"VIEW" then
ui_msg_box("Unable to save your changes","Please correct and save, or discard your changes", UI_STOP_SYMBOL)
end
end if
end if
'Close the form
topparent.close(.f.)

I think the issue must be that at the time the save and close button is pressed

topparent.close(.f.)

is referencing the calling form, not the visible form. Try changing this to

parentform.close(.f.)

[jkletrovets]

Re: topparent.close not closing form

Thanks Stan

I just tried that and got the same problem. In the mean time I had played with some action scripting to close a window and not a form. With the following code it works but I don't really understand what is going on. Does this make any sense to you?

Thanks Jeff

******************
topparent.command("RECORD_COMMIT")
'**********************************************
'Close current form or browse window.
DIM mode as c
mode = parentform.mode_get()
'If the form is in Enter or Change mode, first save the changes before closing the form
if mode = "ENTER" .or. mode = "CHANGE" then
parentform.commit()
'Check to see if the record was successfully saved
if parentform.mode_get()<>"VIEW" then
ui_msg_box("Unable to save your changes","Please correct and save, or discard your changes", UI_STOP_SYMBOL)
end
end if
end if
'Close the form
topparent.close(.f.)
'*************************************************

'Close the current window.
'check that you are in a window
if is_object(topparent.this) then
topparent.close(.f.)
end if

[MikeC]

Re: topparent.close not closing form

Hi, I don't mean to butt in but as Jeff is opening a modal form(dialog) doesn't this mean he Also has to close that form as the last piece of code in his script...usually placed right after the script that first opens the form? Otherwise the form is simply hidden from view (still in memory) when closing it from the form itself?


dim window_to_close as c
window_to_close = "Your_Form_Name"
dim tempObj as p
tempObj = obj(window_to_close)
if is_object(tempObj) then
tempObj.close()
end if

Or even - pointer will vary--have to know the correct one

if is_object(varP_Your_Form_Name) = .t. then varP_Your_Form_Name.close()
end if

Mike

[jkletrovets]

Re: topparent.close not closing form

Hi Mike

Thanks for the reply. I tried the code you posted and it works to close me out of the form and return to the main calling form with the embedded browse(same as my original code). I am calling the form as a hidden dialog since the user presses a change button on the main form - this allows me to bring up the AddEdit form and puts it into change mode for the user. The code below is the xbasic from action scripting that closes a form when you choose a specific name for the form and this also accomplishes what I need. So I have 2 solutions that work but I am trying to understand why the simple topparent.close or parentform.close won't work in this instance? Any ideas?

Thanks again,

Jeff


***************
'Close current form or browse window.
DIM window_to_close as C
window_to_close = "PhotoType_AddEdit_frm"
DIM varP_Window as p

'If the window name was specified without a leading ":", then add it.
if left(alltrim(window_to_close),1) <> ":" then
window_to_close = ":"+alltrim(window_to_close)
end if

'Get a pointer to the specified window
varP_Window = obj(window_to_close)
'Check if the specified window really exists
if .not. is_object(varP_Window) then
ui_msg_box("Error","Can not close the window 'PhotoType_AddEdit_frm' because it is not open.",UI_STOP_SYMBOL)
end
else
'Check to see that the object supports the "close()" method
if .not. varP_Window.has_method("close") then
ui_msg_box("Error","Can not close 'PhotoType_AddEdit_frm' because it is not a window.",UI_STOP_SYMBOL)
else
'The window does exits, so close it
'Check to see that the object supports the "mode_get()" method
if varP_Window.has_method("mode_get") then
'Save any unsaved data before closing the window
DIM mode as c
mode = varP_Window.mode_get()
if (mode = "ENTER" .or. mode = "CHANGE") then
varP_Window.commit()
'Check to see if the record was successfully saved
if varP_Window.mode_get()<>"VIEW" then
ui_msg_box("Unable to save your changes","Please correct and save, or discard your changes", UI_STOP_SYMBOL)
end
end if
end if
end if
'Close the window
varP_window.close(.f.)
end if
end if

[MikeC]

Re: topparent.close not closing form

Jeff,
If I understand correctly you are using the parentform.close() and topparent.close from the hidden dialog form itself...this only serves to close the form from view but it is still in memory which allows your calling button (Change Record) script from the original form to perform additional actions once the dialog is closed in this way---any script that comes after the dialog's windows opening that is on your original calling button (change record) is not performed until it is closed. So as the dialog form is still in memory it has to be closed completely and hence my code which could be placed on the Change Record button's script after the window is shown---and therefore will not be performed until after the initial closing from the dialog form. It should be after any script that you need performed that uses the modal form's info.

Mike

[jkletrovets]

Re: topparent.close not closing form

Hi Mike,

You, in fact, did understand exactly what I was doing! That works just as you said! Thank you! I now see what was going on.

Thanks again....

Jeff

[MikeC]

Re: topparent.close not closing form

Glad I could help Jeff.

Obviously Stan must have missed it when you said "modal" in your original question as his explanation of what is happening would have been much more elegant than mine! :-) ....and as a novice it is not very often I am able to add to a solution when one of the experts has responded so made my day as well!! LOL

Mike