save pdf report one record at a time

[Cheryl Lemire]

Re: save pdf report one record at a time

a) I took your suggestion earlier in this thread and moved my dim variables outside of the loop as what you stated made a lot of sense to me.

b) I added the parameters you are using and I still get no results. It is strange that it works fine in the test db and not the actual one.

Either way, I guess it is a mute point since your method and script provides me with the results I need, and is far more efficient. It is also another tool that I now have a better understanding of and may be able to make use of again in the future.

Thanks again for everything.

[Tom Cone Jr]

Re: save pdf report one record at a time

Cheryl, the biggest difference here is that in my approach a single query is run against the set. In yours the set is queried once for each separate customer. In the small test database you have 3 customers. In the actual database probably a great many more. If you have 500 customers that's 500 queries....

[Cheryl Lemire]

Re: save pdf report one record at a time

That difference, Tom, is phenominal. The actual db has more than 1300 records in the customer table and the broadcast_raw has more than 53,000.

I am quite glad that my approach did not work in the actual db because it gave me the opportunity to learn something new, gave me a better understanding of arrays, and reinforced that one query is definitely better than thousands of queries :)

This will also make the owner a much happier person as this portion of the process is a very small part of the bigger script, so all the resources and time we can save in the process, the better.

[Cheryl Lemire]

Re: save pdf report one record at a time

I am just now getting back to this issue. I got everything working as I wanted to until I tried to convert the script to a function. I have been having difficulty getting the proper parameter values as I need them. I finally managed to get all the parameter values passed as I need them in the function up until the report filter.

I have two test buttons on the only form. The difference between the two buttons is the field used to run the filter on and in the filename that gets saved. The difference between these two fields is that the first one: Cust_no is a numeric field. It works correctly. The second one is Acctno which is a character field. It works up until it gets to the report filter.

I have no idea where the filter value is coming from in the error box received. The first part of the filter in the error message is the 'correct' filter, but it adds to that the between(dates) broken out separately and my filename for the acctno as cust_no with var->which.

I am soooooooooo confused. Please help.

The final result of the 2nd button should be exactly the same as the first button only with a different filename for the pdf, that being showing the acctno instead of cust_no.

Example: 203_cc_20080313.pdf for the cust_no
AND 5300_cc_20080313.pdf for the acctno

[Tim Kiebert]

Re: save pdf report one record at a time

Cheryl,

The reason the second button did not work is that when the 'which' value was added to the end of the filter it needed to be quoted because the field being tested is character. The numeric worked because even though it is stored as character in the array and then aded to the filter the value was not quoted and therefore at run time the filter interpreted it as numeric.

In order to get things working I put in an 'If' test based on your function's 'field_type' paramater that quoted if character and not if numeric. (around line 125) Also just above that I had to remove the eval function from the 'which' assignment. It just wasn't needed there and should not have worked at all. For some reason it was letting values through that were all digits but any alpha values it interpreted (correctly) that the 'which' value was the name of a variable containing the value. (which is what eval() is supposed to do.)

That extra filter that was showing up in the error is the filter that was in place in the actual report properties. I removed it as it was the same as the filter being assigned by the function.

Attached is your sample with the changes. There is also now a second form that uses a second function. The second function I modified a bit. :) It is using the technique from a few days a go in one of your other threads to get unique values. Basically running the filter with Unique_key_Value() added to it. Then there is no need for the array. (Good for you as you don't seem to like them. :) ) I also included a test for the field type so you don't need that paramater in the function.

Have fun

PS How's that kitchen reno coming along?

[Cheryl Lemire]

Re: save pdf report one record at a time

Thanks so much Tim, I would look at it in another hour or so and let you know what I end up with. I don't remember how long it took me to even realize that I was dealing with different field types to begin with. Since I never use numeric fields except for calculations, I never even looked at the table structure assuming both fields were character.

I wrote the original code based on character values. When I realized my problem was the field type I started playing around with the .type_get() without much luck so I added the parameter and started adding if statements.

I also looked at the code you did for my other issue with the unique value and was going to start playing around with that to fix my problem, but for some reason I was stuck on the idea that I needed the array. I am looking forward to see how you worked it into what I am trying to accomplish.

Thanks again for your help :)

EDIT: As far as the kitchen, we keep postponing it due to relatives coming in for visits. Fred seems to think if he postpones it long enough we will save money on the demo side of things because I will have done most of the demo work by the time we start.

[Cheryl Lemire]

Re: save pdf report one record at a time

Tim,

I have had a chance to test what you have done for me. Your 2nd function is by far more efficient. The unique value makes a huge difference when there are a ton of records involved. I can't thank you enough for your help. I am going to put your use of unique values into my head in place of the array as I have a feeling I am going to run across similar needs with my current project in the future. Now all I have to do is clean up my code and add a few other items that I need and I will be good to go. Thanks again :D

[Tim Kiebert]

Re: save pdf report one record at a time

Cheryl,

Your welcome. I'm glad it is working for you. As far as arrays go, don't discard them completely. They can be a handy tool in the right place.

Happy demolitioning.