Help with writing a Function

[WaltMorgan]

The following code works as intended:


dim StickReading as n
dim StickWhole as n
dim StickPart as n
dim Results as n

StickReading = 38.5 ' 38 inches + 5/8ths of one inch

'This extract the whole inch part of the stickreading
StickWhole= int(stickreading)

'This extracts the decimal part of the stickreading
StickPart = (stickreading - stickwhole)

'This converts the decimal part of the stickreading to a whole number
stickpart = stickpart*10

'This converts the major portion of the stickreading to eighths of inches
stickwhole = stickwhole * 8

'This is the result of the conversion to be used in a chart lookup
Results = stickwhole + stickpart

? results = 309

==========================================

This function does not work:

FUNCTION StickToEighths AS N (StickReading AS N )

dim StickWhole as n
dim StickPart as n

StickWhole = int(stickreading)
StickPart = (stickreading - stickwhole)
stickpart = stickpart*10
stickwhole = stickwhole * 8

END FUNCTION

===================================
If I run the following code in the interactive window

StickToEighths(38.5)

I get the following results:

? StickToEighths(38.5)= 0

[csda1]

Re: Help with writing a Function

Hi Walt,

You need to assign the final value to a variable with the same name as the function. I.e.,

FUNCTION StickToEighths AS N (StickReading AS N )

dim StickWhole as n
dim StickPart as n

StickWhole = int(stickreading)
StickPart = (stickreading - stickwhole)
stickpart = stickpart*10
stickwhole = stickwhole * 8

StickToEighths=stickwhole + stickpart
END FUNCTION

[WaltMorgan]

Re: Help with writing a Function

Ira,

Thanks very much for your prompt response.

I did as you suggested as here is what was returned:

? sticktoeighths(38.5)
ERROR: command: StickToEighths()=StickWhole + StickPart
Not an executable file

Again, Thanks!

walt

[csda1]

Re: Help with writing a Function

Hi Walt,

Works fine here.

?sticktoeighths(38.5)
= 309

Did you create a function entry or did you just type the code into the interactive window? The following code works fine for me.

FUNCTION StickToEighths AS N (StickReading AS N )

dim StickWhole as n
dim StickPart as n

StickWhole = int(stickreading)
StickPart = (stickreading - stickwhole)
stickpart = stickpart*10
stickwhole = stickwhole * 8

StickToEighths=stickwhole + stickpart

END FUNCTION

To create a new function, select, File, New, Function from the menu

[Al Buchholz]

Re: Help with writing a Function

I think when Walt entered the code that Ira suggested, the auto-complete added the () to the function name.

Walt, just eliminate the () so you have:

StickToEighths=stickwhole + stickpart
instead of
StickToEighths()=stickwhole + stickpart

[G Gabriel]

Re: Help with writing a Function

dim StickReading as n
StickReading = 38.5 ' 38 inches + 5/8ths of one inch

No point in dimming a variable to assign it a constant value, use the constant value to start with.

You don't need a UDF:

dim stickreading as n=38.5

?int(stickreading)*8+(stickreading-int(stickreading))*10
= 309

[WaltMorgan]

Re: Help with writing a Function

Al,

That did it. Removing the () enabled the function to work as expected.

Many thanks,


Walt
PS Thanks to all who offered their suggestions. Perhaps in time I will be able to reciprocate.

[Al Buchholz]

Re: Help with writing a Function

Walt

Glad that you have it working. The auto-complete is a great friend, but alas not a perfect one.

That issue bit me few times too.