struggling with using a variable

[richard2007]

i am trying to automaticaly add records to a child table, based upon values of the parent table and some variables.

there are some calculations to be done.

i hope this code makes sense. the problem is - the variables are not being used by my code.

i am collecting two variables 'crop_yield' and 'vmkt_price' by means of a xdialog.

most of the fields are being populated but the fields which require a calculation, wont return a value.

thanks for any help.

dim tbl as P
dim vha as n
dim vcrop_yield as n
dim vmkt_price as n
dim vCashCrop as n
dim vyear as d
dim vyear1_value as n

vha=products->prod_plant_ha
vCashCrop=(vha*vCrop_yield)*vMkt_price
vyear1_value=vCashCrop*products->prod_units



tbl = table.open("product return")

tbl.enter_begin(.T.)
tbl.Prod_units= products->prod_units
tbl.Prod_percent= products->prod_percent
tbl.Prod_plant_name= products->prod_plant_name
tbl.Prod_plant_ha= vha
tbl.Prod_year= "2011"
tbl.Crop_yield= vcrop_yield
tbl.Prod_mkt_price= vmkt_price
tbl.Prod_crop_value= vCashCrop

tbl.Prod_year= vCashCrop*vCrop_yield
tbl.Prod_year_return= vyear1_value
tbl.Prod_id= products->prod_id

tbl.enter_end(.T.)

tbl.close()

[Tom Henkel]

Re: struggling with using a variable

There may be an issue with the scope of the variables. How are hey declared in the x-dialog? If they aren't in the same scope (local, shared, global), then your script won't see them.


Tom

[richard2007]

Re: struggling with using a variable

hi tom,

they were initially declared as shared

i then changed the variables on the xdialog to global but still nothing.

[Tom Cone Jr]

Re: struggling with using a variable

Rule #1 Unless declared differently IN YOUR SCRIPT all variables are local to the script.

So...

If your xdialog populates GLOBAL vars and you want to use them in your script you need to declare them as GLOBAL in your script. Otherwise, see Rule #1

[Stan Mathews]

Re: struggling with using a variable

I'm unclear of the context. Is this script run from a button on a form based on the set? If so it might be better to change to ....

tbl2 = table.current(1)
'tbl = table.open("product return")
tbl = table.current(2)
dim tbl as P
dim global vha as n
dim global vcrop_yield as n
dim global vmkt_price as n
dim vCashCrop as n
dim global vyear as d
dim vyear1_value as n

vha=tbl2.prod_plant_ha
vCashCrop=(var->vha*var->vCrop_yield)*var->vMkt_price
vyear1_value=var->vCashCrop*tbl2.prod_units


tbl.enter_begin(.T.)
tbl.Prod_units= tbl2.prod_units
tbl.Prod_percent= tbl2.prod_percent
tbl.Prod_plant_name= tbl2.prod_plant_name
tbl.Prod_plant_ha= var->vha
tbl.Prod_year= "2011"
tbl.Crop_yield= var->vcrop_yield
tbl.Prod_mkt_price= var->vmkt_price
tbl.Prod_crop_value= var->vCashCrop

tbl.Prod_year= var->vCashCrop*var->vCrop_yield
tbl.Prod_year_return= var->vyear1_value
tbl.Prod_id= tbl2.prod_id

tbl.enter_end(.T.)

It is not forbidden but the mixing of the tbl pointer and tablename-> syntax is generally avoided.

[Tom Henkel]

Re: struggling with using a variable

You NEED to declare them the same way in both scripts. We found that declaring GLOBAL all the way around was easiest.

Tom

[richard2007]

Re: struggling with using a variable

thanks again, i declared all global and worked fine.

i had initially declared as shared (seeing as the script was running in the same session, but is just wouldnt work).

stan, thanks for your comments, i have been using my method quite a lot in another program and i do get some issues (mainly unhandled exceptions) in the actions where these scripts are, so maybe this is the reason.

ill change some and see if it makes a difference.