what's the wrong logic in this code that has worked for years but now doesn't?

[Mike Wilson]

I have been using this code for years through many versions of A5 successfully. Now, as of version a5v10_5_3420_3606, it doesn't work. Selwyn says the logic is wrong, should never have worked, and I should study it carefully to discover the "wrong logic". OK, I'm an idiot, because this has been working for years and now it doesn't, and the experiencial knowledge I have derived comes from the experience that this code worked. So I guess I'm just screwed now because what did work that "solidified" my belief of understanding is now being told to me is not correct. It becomes pretty much a rat chasing it's tail. It makes me want to raise a finger.

dim vshow as C
dim vReply as C
vReply = ui_dlg_box("Control Panel Access",<<%dlg%
{background=#165,175,165}
{lf};
{region}
{lf};
{region}
{font=arial,8,i}{frame=1,1:Control Panel}{font=arial,12,b}
  (vshow:show!cpt_*)  (vshow:hide!cpt_*)
{lf}
{lf};
{endregion};
%dlg%,<<%code%

	IF left( a_dlg_button, 4 ) = "cpt_"
	 IF a_dlg_button = "cpt_change"
	      a_dlg_button = "end"
	 END IF
	END IF
	%code%)
	
	if vshow = "show"
		:controlpanel.show()
	else if vshow = "hide"
		:controlpanel.hide()
	end if

[G Gabriel]

Re: what's the wrong logic in this code that has worked for years but now doesn't?

Something is screwed up.. but it is not you. It's the code.
Something idiotic, not you, the code and the idiotic part is that it will work.

How?

Something like what Rick Santilli would say: "the private sector created jobs INSPITE of the governement not BECAUSE of the government."

I differ with Selwyn here.. it will work.. in an idiotic way.. I think Selwyn took a quick look at it and figured: this is crazy! It can't possibly work!

I am tempted to tell... but I know if you chill out a bit you will figure it out yourself!
Or should I?

[fddizon]

Re: what's the wrong logic in this code that has worked for years but now doesn't?

take a good sleep...

and return afterwards and have a good look...

[Mike Wilson]

Re: what's the wrong logic in this code that has worked for years but now doesn't?

Your presumption that I haven't looked at this code carefully is more than annoying. If your not going to help me, fine. I guess I really don't care enough anymore. I'll just add the OK button and get rid of the dialog event and move on.

[MikeC]

Re: what's the wrong logic in this code that has worked for years but now doesn't?

Mike,
You've done more xdialogs than I, but when I go to the help file and look at the syntax it looks like you are using a combination of directives--my take is that the following would be "normal" and the original under it commented out is yours....

   (vshow={show}!cpt_*)  (vshow={hide}!cpt_*)
{comment (vshow:show!cpt_*)  (vshow:hide!cpt_*)}

But as I said, maybe I am not even close! And like you, I get something to work and then assume I must have done it correctly!

[Tim Kiebert]

Re: what's the wrong logic in this code that has worked for years but now doesn't?

Mike (W)

Since this is a Modal dialog it will close if any value is left in a_dlg_button after running through the code section. (I know you know this) You have placed a control on the dialog which produces events that give a_dlg_button a value. You have not, however, taken into account any and/or all events that might result from this.

After testing I have found that there is a difference between v9 and v10. Place the following line as the first line in the dialog code section. This will give you a list of events in the trace window.

trace.WriteLn(a_dlg_button)

In v10 I get an event called 'cpt_setfocus'. And I don't get that in v9. That is why it did work and now doesn't. ( I haven't tested previous versions of 10).

The set focus event happens right away because the radio button is the first control on the dialog and receives focus on startup. (If you were to put another control with no events before the button to take the initial focus the dialog would stay open but as soon as the button gets focus the dialog would close before the variable could get a chance to change value) So at dialog startup you get an event, cpt_setfocus, and thereby a_dlg_button with a value of cpt_setfocus.

The logic of your code first checks for "cpt_" and gets a yes answer. Then it drops into the next level and looks for "cpt_change". The answer is no so you don't drop into the second IF but continue on with the first level. There is no more to do there so you exit the first level and you are still left with a value in a_dlg_button which closes the dialog.

As already mentioned, it is the introduction (either a new event or fixing the fact that it wasn't happening in v9) of the setfocus event as a change from v9 that is causing your code to no longer function as it did.

Ok so how should you do this. Depends on the dialog and what it needs to do.

In this case since there are really only two options, leave it open or close if any choice is made, I would test only for cpt_change as in the following.

<<%code%
    IF a_dlg_button <> "cpt_change"
          a_dlg_button = ""
    END IF
    %code%

If you have developed a methodology where you specifically set a_dlg_button to "end" then something like this will also work

<<%code%
    IF left( a_dlg_button, 4 ) = "cpt_"
     IF a_dlg_button = "cpt_change"
          a_dlg_button = "end"
     END IF
    END IF
    If a_dlg_button <> "end" then
        a_dlg_button = ""
    end if
    %code%

Hope this helps and apologies if I rambled.

EDIT: and here is your original code with a couple extra lines

<<%code%
trace.WriteLn(a_dlg_button)
	IF left( a_dlg_button, 4 ) = "cpt_"
	 IF a_dlg_button = "cpt_change"
	      a_dlg_button = "end"
	  Else    
	      a_dlg_button = ""
	 END IF
	END IF
	%code%

[G Gabriel]

Re: what's the wrong logic in this code that has worked for years but now doesn't?

Your presumption that I haven't looked at this code carefully is more than annoying. If your not going to help me, fine. I guess I really don't care enough anymore. I'll just add the OK button and get rid of the dialog event and move on.

Mike:
You know I am more than happy to help.. it's just something that's so redicullously simple I feel you are in a pretty PO'd mode you must have overlooked it again.. and again.. and again.. and evidently others did too!

So before we see your picture on TV, here it goes:

Your code is pretty darn simple. It shows an xdlg with a radio button. Click show and the CP will show, hide and it will hide and that's it. But the code part of your xdlg is what Selwyn probably looked at and said: What?!

Before we get to that code there is a little trivia that may or may not have any bearing on the outcome and that you put a base event in the radio and later tried to trigger it with "change" which is fine ..but.. what else do you do with a radio?
I tell you what else later..

Now to your code. It says:

IF left( a_dlg_button, 4 ) = "cpt_"
	 IF a_dlg_button = "cpt_change"
	      a_dlg_button = "end"
	 END IF
	END IF
	%code%)

You could easily replace that code with:

<<%code%
.. I bought a new puppy..
..he is cute and fluffy..
..I named my puppy Joe Kamel..
%code%

And it will do exactly the same thing your code does.. which is NOTHING. I am not trying to be cute or sarcastic, I am only trying to illustrate the point..
your code says:
If a_dlg_button="something" ' the name event in this case,
call it (i.e. the a_dlg_button) "something else"
and that's all it does..
You assigned a_dlg_button (which is a system varaible) the value "end".. you could have named it "Joe Kamel" and had the same result.
Then, OUTSIDE the xdlg, you took the value you got from vshow and used it to execute the rest (show CP or hide CP) and that part will work.

So now back to the initial trivia of the base event in the radio. What else can you do with a radio? besides "change"?
Setfocus..killfocus..
That might answer the last question, why did it work before v10?
My guess is because there were some bugs with setffocus/killfocus and they fixed those and now once you jump into the radio the setfocus event is triggered but there is nothing to do so it most likely will close the xdlg. I can't swear to that since I don't have v10 but I pretty sure that's what will happen.
So, here is how your code should look like:

dim vshow as C
dim vReply as C
ui_dlg_box("Control Panel Access",<<%dlg%
{background=#165,175,165}
{lf};
{region}
{lf};
{region}
{font=arial,8,i}{frame=1,1:Control Panel}{font=arial,12,b}
  (vshow:show)  (vshow:hide)
{lf}
{lf};
{endregion};<OK>
%dlg%,<<%code%
IF a_dlg_button = "OK"
 END IF
if vshow = "show"
		:controlpanel.show()
	else if vshow = "hide"
		:controlpanel.hide()
	end if
%code%

In the future, if you use an event in a radio control and unless you have any use for set/killfocus.. just use a regular event.

[Mike Wilson]

Re: what's the wrong logic in this code that has worked for years but now doesn't?

OK, OK,
I love you guys, have I told you that before!!!

A bit of tube Tube 1 and Tube 2 make green, so when you squeeze some from each tube that will make green..... until they change what's in Tube 2 and you squeeze and mix and it is turns out purple.

So time to reset the matrix, a bit. Thanks you guys,

[Tim Kiebert]

Re: what's the wrong logic in this code that has worked for years but now doesn't?

:D Warm and fuzzy moment.

PS I guess you didn't get the memo. Purple is the new green. ;)

[Mike Wilson]

Re: what's the wrong logic in this code that has worked for years but now doesn't?

This thread was never really completed.

dim vshow as C=""
ui_dlg_box("Control Panel Access",<<%dlg%
{background=#165,175,165}
{lf};
{region}
{lf};
{region}
{font=arial,8,i}{frame=1,1:Control Panel}{font=arial,12,b}
  (vshow:show!evrb_*)  (vshow:hide!evrb_*)
{lf}
{lf};
{endregion};
%dlg%,<<%code%
IF left(a_dlg_button,5) = "evrb_"
	if a_dlg_button="evrb_change"
		if vshow = "show"
			:controlpanel.show()
		else if vshow = "hide"
			:controlpanel.hide()
		end if
	[COLOR="#FF0000"]else
	 a_dlg_button=""[/COLOR]
	end if
END IF
%code%)

[Ray in Capetown]

Re: what's the wrong logic in this code that has worked for years but now doesn't?

What a brilliant learning experience this has provided. thank you all.
Much more educational (and more fun) than any number of dialog examples.

I might suggest using a simple formula in your question to avoid accidents;-

FQ = NT x YE

where
FQ = Frustration Quotient equals
{NT = Number of Times re-read and reworked the code multiplied by
YE = Years Experience with A5}
So Mike W's FQ could have been somewhere around 40*6 = 240.
Take a 240 VERY seriously.
Tell a <25 to go back and do some work and <5 come back with a real problem