fetching through records doing something weird??

[reynolditpi]

I have a script attached to a button on a form. When run, the script "duplicates" the active record (parent and its children).

The chunk of code below copies the records to the child table.

while .not. fromtbl.fetch_eof()
	totbl.enter_begin(.t.)
		totbl.assess_pro_id=new_pro_id 
		totbl.assess_id=fromtbl.assess_id
		totbl.assess_name=fromtbl.assess_name
		totbl.order=fromtbl.order
	totbl.enter_end(.t.)
	
	fromtbl.fetch_next()
end while

The strange thing is that this code copies over all of the records as it should, then adds the first record again. Additionally, I added a msgbox() before the fetch_next() so I could see what record it was on and it caused the loop to repeat endlessly. I moved the msgbox() to after the fetch_next() and it did the same thing.

My main issues is with copying the first record twice more so than the endless looping issue. However, I thought the latter may be of interest.

Any ideas as to what I am doing wrong?

Thanks
Tony

[Tom Cone Jr]

Re: fetching through records doing something weird??

Tony the trouble lies elsewhere. Code not shown.

Nothing in the snippet you've posted would duplicate both the parent table record and also the child table record of a set.

I think we'll need the tables and the form to debug this.

[reynolditpi]

Re: fetching through records doing something weird??

Tom,
I have tried to attach the things you requested/need. Please let me know if I have not included something.

I have also included the entire script below.

Thanks again
Tony

'get assess_pro_id-Will need this to filter the assessments to this protocol
	dim vassess_pro_id as c
	vassess_pro_id=assess_pro_hdr->assess_pro_id

'create a new protocol
	'get new protocol name
		'Prompt for text and store result in a variable called 'vprotcol_name'.
			dim prmpt_title as c 
			dim prmpt_prompt as c 
			dim prmpt_default as c 
			prmpt_title = "New Protocol"
			prmpt_prompt = "Protocol Name"
			prmpt_default = a5_eval_expression("=rtrim(Protocol_Name)+\" Copy\"",local_variables())
			DIM SHARED vprotcol_name AS C
			vprotcol_name = ui_get_text(prmpt_title,prmpt_prompt,prmpt_default)
	'write new protocol to tbl
			dim tbl as p 
			tbl=table.open("assess_pro_hdr")
				tbl.enter_begin(.t.)
					tbl.protocol_name=vprotcol_name
					tbl.protocol_notes=assess_pro_hdr->protocol_notes
				tbl.enter_end(.t.)
		
'get the new assess_pro_id
		dim new_pro_id as c
		new_pro_id=tbl.assess_pro_id
		
'open assess_pro-bdy tbl to get assessments and filter to old assess_pro_id
		dim fromtbl as p
		fromtbl=table.open("assess_pro_bdy")
		
		query.description = "Query Assessments"
		query.order = ""
		query.filter = "assess_pro_id="+s_quote(vassess_pro_id)
		query.options = ""
		fromtbl.query_create()
		fromtbl.fetch_first()

'open another assess-pro-bdy tbl to write the protocol to
		dim totbl as p
		totbl=table.open("assess_pro_bdy")
	
'start looping through the table and copy over the records
	while .not. fromtbl.fetch_eof()
		totbl.enter_begin(.t.)
			totbl.assess_pro_id=new_pro_id
			totbl.assess_id=fromtbl.assess_id
			totbl.assess_name=fromtbl.assess_name
			totbl.order=fromtbl.order
		totbl.enter_end(.t.)
		XBASIC_WAIT_FOR_IDLE()
		fromtbl.fetch_next()
	end while
	
	
'close all open tables
tbl.close()
totbl.close()
fromtbl.close()

query.description = ""
query.order = ""
query.filter = ""
query.options = ""

[reynolditpi]

Re: fetching through records doing something weird??

I still cannot get this to work properly. I would greatly appreciate any suggestions anybody might have.

Thanks for your help.

Tony

[Stan Mathews]

Re: fetching through records doing something weird??

Not sure I understand why but try changing
while .not. fromtbl.fetch_eof()
to
while (.not. fromtbl.fetch_eof()) .and. fromtbl.assess_pro_id = vassess_pro_id

[reynolditpi]

Re: fetching through records doing something weird??

yep...never would have figured that one out on my own:) I cannot thank you enough Stan!


Tony