JSON to store results of a complex search.

[Michael1954]

I have a UX that allows the user to perform a complex search. Sometimes the user may want to save the search choices.

I have tried saving strings and I get a problem with Choice1, Choice2. The comma is being removed and not getting saved in MySQL.

So I am trying to save the choices as JSON but I can't build the children.

The result I am getting is


{"name":"Raj","age":32,"married":false,"child":[{"name":"Brian"},{"name":"Brian"},{"name":"Brian"}]}

I want it to read the name: Sid and Sue and only one Brian.


The code I am using is

function build(){
var kids = ["Sid", "Sue", "Brian"];
//alert(kids[0]);
var child = [];
var res = {};
var str = {};

for (i = 0; i < kids.length; i++) {
res.name = kids[i];
child.push(res)
var str1 = JSON.stringify(child);
}
var who = "Raj";
var obj = new Object();
obj.name = who;
obj.age = 32;
obj.married = false;
obj.child = child;
var jsonString= JSON.stringify(obj);

document.getElementById("json").innerHTML = jsonString;

}

I can see the correct results as I loop through but I always get the last value in the array kids. It is repeated kids.length times.

I cannot work out how to loop a second time "Slicing" the value I want.

[Davidk]

Re: JSON to store results of a complex search.

You're doing too much work... and not enough work... all at the same time. And... you don't need to slice anything.

1. You're re-using the res object you create... and so you're just re-assigning it's value each loop... so it's changing the prior array values which are based on that variable... and then you're pushing that re-assigned value into the array.
2. You're stringifying withing the loop... which you don't need to do. Just do it once when you're done building.

Create a new res object for each loop. Then it's new and you won't be changing prior iterations. Then... when all done... stringify

	var kids = ["Sid", "Sue", "Brian"];
	//alert(kids[0]);
	var child = [];
	var str = {};
	
	for (i = 0; i < kids.length; i++) { 
		var res = {};
		res.name = kids[i]; 
		child.push(res)
	}

	var who = "Raj";
	var obj = new Object();
	obj.name = who;
	obj.age = 32;
	obj.married = false;
	obj.child = child;
	var jsonString= JSON.stringify(obj);

[Michael1954]

Re: JSON to store results of a complex search.

Thank you so much.

The explanation was clear and is a step forward for my understanding. The code of course works.


Thanks again.

[GGandhi]

Re: JSON to store results of a complex search.

not to take away anything from the fine contribution by david,
the code can be written as follows:

var kids = ["sue", "sid", "brian"];
var obj = {};
obj.name = "raj";
obj.age = 66;
obj.sex = "male";
obj.child = [];
for( var i = 0; i < kids.length; i++) {
obj.child.push({"name":kids[i]});
}
alert(JSON.stringify(obj));

the variable "i" is dimmed as "var i", that is better than just "i", which will work fine, but it will pollute the global variable namespace. when you declare "var i" it will be discarded at the end of this script code. many people believe it is a better practice.

[Michael1954]

Re: JSON to store results of a complex search.

Thanks Gandhi I have amended the code