Query options??

[peterg000]

Re: Query options??

I would agree that it might be slower ... but not slow. Even in a loop, it doesn't seem to be that bad. To me, using lookup() when you can just cuts down on alot of moving parts. I use it a lot in calc fields on my forms and in my reports and have had little issues. I don't mind taking the path of least resistance every once in a while .. :)

[Al Buchholz]

Re: Query options??

Tom speaks from experience and offers sound advice.

Choose wisely, grasshopper...

[peterg000]

Re: Query options??

Al .... I would never discount Toms experience ... but there are always 2 sides of the coin ... :)

[martinwcole]

Re: Query options??

I'm not sure it is a bug either, only that it did work in V8 and doesn't in V10. When I finally figured out where my script was bombing, I did what Tom suggested, and made a note not to use lookup() in a script anymore, although it sounds like it still works, but has new behavior regarding slots.

[peterg000]

Re: Query options??

Martin .... did you toss the lookup() and decide not to turn in as a bug because you where unsure of whether or not it was a bug? can you re-create? maybe if we both send something in?? What do you think?

[martinwcole]

Re: Query options??

mine was in a few places, where I am looping through records, and as I find each one, was using lookup() within the loop. I was converting from 8 to 10, and because I was under pressure to get it to work, I just redid the scripts to work as Tom describes.

will see if I can reproduce and send - but I am no longer using lookup() in any loops and being generally very cautious about using it at all in V10.

[peterg000]

Re: Query options??

Ok .... I sent in as bug. I just dont feel comfortable saying 'just dont use lookup()' ... its there, it should work ... lets get it fixed or at least explained why its behavior has changed in V10. I will update post with response ....

Glenn

[martinwcole]

Re: Query options??

Peter, here is a script I just tried, with release 6. The query filds about 125 patients records, and thus uses lookup() 125 times, and the query.filter does not get changed
does this script look like it is an adequate test?

'this is a dummy script meant to reproduce a 
'possible bug or issue where query slots are used by lookup() in recent patches, whereas they were not in early releases, and/or in V8
t1=table.open("patients")
query.filter=""; query.order=""; query.options=""
query.filter="left(lastname,1)='a' .or. left(lastname,1)='w' .or. left(lastname,1)='s' "
query.order="lastname"
dim shared uid as c
idx=t1.query_create()
msgbox("","" + idx.records_get())
t1.fetch_first()
while .not. t1.fetch_eof()
 uid=t1.Uniqueid
 temp=lookup("dailyentries","uniqueid=" + quote(var->uid),"uniqueid")
 t1.fetch_next()
end while
msgbox("","" + query.filter)
t1.close()

[jkletrovets]

Re: Query options??

Hi Gents,

I thought I would throw out a piece of info that Ira passed along in the course of a conversation at the Alpha Conference a couple of years ago.

If you open the LOOKUP table BEFORE your loop - then the lookup command will not open and close the table 125 times as in this code above. Ira said the "lookup" commands are smart enough to know that the table was just opened and will use that pointer. While I prefer the method Tom Cone describes.....I do use the lookup commands on occassion in loops with the methodolgy Ira pointed out....with no problems.

So...in this case....just put t2=table.open("dailyentries") before the loop starts. Also, be sure to close it after the loop finishes.

Regards,

JK

[martinwcole]

Re: Query options??

excellent info!!

[MikeC]

Re: Query options??

Thanks Jeff (and Ira) for this nice tidbit of info....spreading knowledge such as this amongst us will undoubtedly enable us to more easily help others (and each other when we forget these jewels if not used for a while!).

[Tom Cone Jr]

Re: Query options??

martin, I think your test (example) code in post #38 is different from Glenn's in this particular. His lookups were targeted to the same table that he was looping through. Your lookups are to a different table.

[martinwcole]

Re: Query options??

thanks Tom,

I just retested, given that condition, but the query still remains ok in release 6

[Tom Cone Jr]

Re: Query options??

Great!

[Tbaker]

Re: Query options??

Martin

Have you tried your sample with "query.options="T".

That was the problem that Glenn was addressing - he did get his app to work with query.options="X".

I tested his app with all the other query.options and it did not drop the query. When you add query.options="T", the query gets dropped after the 7th iterations through the loop.

Just as information

Tom Baker