Script executes improperly

[shapse]

I have the following code:
---------------
dim quit as n
dim bckup as n
'Backup
bckup = ui_msg_box("Backup Program & Data","Press YES to backup your files.",3)
IF bckup = 6
script_play_local("Backup")
END IF
'end

'Quit
quit = ui_msg_box("QUIT!","Do you really want to quit PBS?",3)
IF quit <> 6
:Form.view("Main Menu")
ELSE
a5_close_all_windows()
parentform.Close()
a5.Close()
END IF
--------------
The script "backup" does not execute when followed by the Quit code. HOWEVER, if I END the code before the Quit section, the backup code executes just fine. I've tried using XBASIC_WAIT_FOR_IDLE() but that doesn't do a thing in terms of code execution.

What am I doing wrong??? Thanks.

[Tbaker]

Re: Script executes improperly

Steve

What is the code behind the script "Backup"

It may be a timing issue

Tom Baker

[Clunes]

Re: Script executes improperly

try adding a 'then' to the end of the if statements. eg;

IF bckup = 6 then
script_play_local("Backup")
END IF

[Tom Cone Jr]

Re: Script executes improperly

What am I doing wrong???

Steven, I'm no mind reader, but think maybe you're making an incorrect assumption about how Alpha processes your script.

You may be assuming that the script will stop processing statements (i.e. pause) while your "BACKUP" script is run. You may be thinking that the script will "resume" after "BACKUP" is over.

Because of the way Windows multi-tasks I suspect that what's happening instead is that your BACKUP script is running (or at least starts) but your main script does NOT PAUSE. As soon as you elect to QUIT Alpha shuts down, without waiting for the BACKUP sequence to conclude.

I suggest you move your "Backup" script into a custom UDF that returns a logical result. Then "play" it like this:

L_result =  Backup_my_data()

Alpha will wait for the "L_result" before resuming its march through the main script.

[G Gabriel]

Re: Script executes improperly

Try:

dim quit as n
dim bckup as n
bckup = ui_msg_box("Backup Program & Data","Press YES to backup your files.",3)
IF bckup = 6
script_play_local("Backup")
else
quit = ui_msg_box("QUIT!","Do you really want to quit PBS?",3)
IF quit <> 6
:Form.view("Main Menu")
ELSE
a5_close_all_windows()
parentform.Close()
a5.Close()
END IF
END IF

[CALocklin]

Re: Script executes improperly

Steven, I'm very curious to know how long you've been using A5? And, if a new user, what prompted you to use the numbers in the message box codes?

I was surprised to see you using numbers for the message box codes. Most new users seem to use the built-in variable names instead.

There's nothing wrong with using the numbers. It was just a surprise to see someone with so few posts and a Dec. '09 date using them. In fact, I started using the variables only because I was afraid any newer user that might some day have to edit my code would be completely confused if I continued using the numbers.

[shapse]

Re: Script executes improperly

I suggest you move your "Backup" script into a custom UDF that returns a logical result. Then "play" it like this:

L_result =  Backup_my_data()

Alpha will wait for the "L_result" before resuming its march through the main script.

Tom,
Yes, timing is the problem. I was assuming code executing sequentially, waiting until one thing is done before continuing.

I'm not sure where to put the "L_result" and how this would slow things down. I'v created two functions: Bckup() and Quit() which execute sequentially when the Quit button is clicked. This doesn't (probably obvious to you why) solve the problem. A little more code detail would be greatly appreciated. Thanks!

[G Gabriel]

Re: Script executes improperly

You say the backup script runs when the quit one is removed.
For the backup script to run, the variable "backup" has to be 6.
Who sets its value to 6?
When?
Where?

[Tom Cone Jr]

Re: Script executes improperly

dim quit as n
dim bckup as n
[COLOR="Red"]dim L_result as L[/COLOR]
'Backup
bckup = ui_msg_box("Backup Program & Data","Press YES to backup your files.",3)
IF bckup = 6
    'script_play_local("Backup")
[COLOR="red"]    L_result = bckup()  'NOTE:  I'd rename the function.  Why use same
                               'name as the variable you dimmed?  Use diff names
                               'for everything.  You'll keep your hair longer.
    If L_result then 
         msgbox("Status","Backup was successful")
    else
         msgbox("Status","Backup failed")
    end if[/COLOR]
END IF
'end

'Quit
quit = ui_msg_box("QUIT!","Do you really want to quit PBS?",3)
IF quit <> 6
    :Form.view("Main Menu")
ELSE
    a5_close_all_windows()
    parentform.Close()
    a5.Close()
END IF

Not sure what's in your functions since you're keeping your code a secret, but this is what I had in mind.

[shapse]

Re: Script executes improperly

Tom,

It works when executed directly from the Code tab in the control panel, but it does not work properly when executed from a menu button with the code script_play("Quit")
Interestingly, the backup only occurs after the quitall code executes. If I say "No", then files are backed up. If "Yes" the program exits (as directed by the code).

I'm not trying to keep my code secret. I didn't want to burden anyone with looking at unnecessary code. I've attached the relevant code and will be happy to share any other code. Thanks for your help!!!

[Tom Cone Jr]

Re: Script executes improperly

Steven, the Bckup() function does not return a logical value. It should be setup like this (pseudo code follows) :

Function Bckup as[COLOR="Red"] L [/COLOR]()
    dim result_flag as L
    result_flag = .f.
    'now do your processing
    'more processing
    'if successful do this
    result_flag = .t.
    'else
    result_flag = .f.
    'end if
   [COLOR="red"] Bckup = result_flag[/COLOR]
End Function

Does this make sense?

[shapse]

Re: Script executes improperly

No really. I tried implementing, but the same timing program seems to occur. What I don't understand is that the code works when executed from the Code panel, but not from a form button. I can't seem to get the program to wait for the execution of the backup to complete.

[Tom Cone Jr]

Re: Script executes improperly

ok, zip the whole shebang together and email it here with sample data.

[email protected]

we'll take a looksee this evening.

-- tom

[Mike Wilson]

Re: Script executes improperly

OK Cal,
Since you brought it up, for those that want to know what they are, here is a chart I picked up from the message board years ago.

1st Button Default       No Symbol  Stop  Question Attention  Information    Response
Ui_ok                       0        16     32      48          64            1 = Ok
Ui_ok_cancel                1	     17	    33      49          65            2 = Cancel
Ui_abort_retry_ignore       2        18     34      50          66            3 = Abort
Ui_yes_no_cancel            3        19     35      51          67            4 = Retry
I_yes_no                    4        20     36      52          68            5 = Ignore
Ui_retry_cancel             5        21     37      53          69            6 = Yes
                                                                              7 = No
2nd Button Default		
Ui_ok_cancel               257       273    289     305	        321		
Ui_abort_retry_ignore      258       274    290     306         322		
Ui_yes_no_cancel           259       275    291     307         323		
Ui_yes_no                  260       276    292     308         324
Ui_retry_cancel            261       277    293     309         325		
							
3rd Button Default	
Ui_abort_retry_ignore      514       530    546     562         578	
Ui_yes_no_cancel           515       531    547     563         579

[CALocklin]

Re: Script executes improperly

That's a pretty neat chart once I figured out how to use it. I'm going to copy it somewhere for future reference.

For "newbies" to these numbers, the attached screenshot shows the basics - which are also in Mike's chart once you understand how to use it. (The basic numbers were in the [much] older Help files but aren't shown anymore.) His chart shows the combined totals of the various button/symbol combinations.

My recommendation was always to enter each option separately such as:
2+64+256
so the next guy (usually yourself after a few months away from it) doesn't have to waste time figuring out what 322 really means. Of course, the chart makes "decompiling it" much easier.

On the other hand, the variables are even easier to understand and not bad to type IF you use a keyboard macro program: (Have I ever mentioned keyboard macros before?)

ui_abort_retry_ignore+ui_information_symbol+ui_second_button_default

(That took me a total of 14 keystrokes including the two "+" signs - uiar+uisi+uisb. That's more than typing the numbers but a lot less than typing the whole thing out.)

Sorry, I had no good way to turn that page into a text file so all I could do was attach the screenshot.