Announcement

**Stan Mathews** · 09-23-2011, 12:05 PM

Re: Help with code

VSecAftMid will seldom be exactly vCounter times either 1800 or 3600. You need some sort of between values test.

Code:

VSecAftMid = toseconds(time())
? VSecAftMid
= 39621.000000
vCounter = 0
? between(VSecAftMid,1800*vCounter,1800*(vCounter+1))
= .F.

vCounter = 20
? between(VSecAftMid,1800*vCounter,1800*(vCounter+1))
= .F.

vCounter = 21
? between(VSecAftMid,1800*vCounter,1800*(vCounter+1))
= .F.

vCounter = 22
? between(VSecAftMid,1800*vCounter,1800*(vCounter+1))
= .T.

**Dean W. Charron** · 09-23-2011, 12:10 PM

Re: Help with code

So that's why it's not trapping it huh? I had a feeling it was in the math...

**Dean W. Charron** · 09-23-2011, 12:23 PM

Re: Help with code

Yes but I am trapping for specific time events, i.e., on the hour and on the half hour--not just random times. If the Vcounter times 1800 = seconds past midnight, it's supposed to trap the Trigger_Tripped variable and change it to .T. It's not doing that...

**Stan Mathews** · 09-23-2011, 12:27 PM

Re: Help with code

It's more the logic than the math. Minor adjustments. (same for the hours test)

Code:

while VCounter<48 [COLOR="#0000FF"]'note now just less than --- vcounter+1 tests the upper limit[/COLOR]
VCounter = VCounter + 1
If Between(VSecAftMid,VCounter*1800,(VCounter+1)*1800)
Trigger_Tripped = .T.
AAA_Ack = .F.
exit while
end if
wend

**Dean W. Charron** · 09-23-2011, 01:04 PM

Re: Help with code

Stan, I appreciate your help but are we atlking about the same issue? If my OnTimer is polling every second, I wouldn't have a value "range" would I? My applicaation is a security log with a built in feature to trigger a required response event every 30 or 60 minutes on the hour and half hour. The OnTimer polls every second and reads the seconds after minute value into the variable VSecAftMid. The loop tests for whether the value (VCounter*1800 for every half hour or VCounter*3600 if polling for every occurance on the hour) to see if it's an exact match for VSecAftMid. For some reason, and it may be what you are referring to, it's not seeing the match-up of VCounter result and the value of VSecAftMid--I am stumped because this is programming 101. I won't bug you if you've had enough of this issue--I'll figure it out in a couple days I hope. Thanks again--BTW, I discovered/learned a new function today (Between()) thanks to your help! Best, Dean

**Stan Mathews** · 09-23-2011, 01:35 PM

Re: Help with code

By the time I finished examining the code I apparently forgot about the ontimer.

I just tested an abbreviated version and it fired for me at 12:30 local. (Fired again at 1 PM local)

Perhaps there's an issue with

Code:

DIM Global V_Aaa_Interval_Factor AS C
'V_Aaa_Interval_Factor = tbl.eval("Aaa_Interval_Factor")

??

My test code.

Code:

'Set Trigger_Tripped variable to .F. and AAA_Ack to .T.
AAA_Ack = a5_eval_expression("=.T.")
Trigger_Tripped = a5_eval_expression("=.F.")

'Define VSecAftMid as N
DIM GLOBAL VSecAftMid AS N
VSecAftMid = a5_eval_expression("=TOSECONDS(TIME())")

'Create a new variable called 'AAA_DOW' and set its value to '=ALLTRIM(STR(DOW(Date()),1))
dim Global AAA_DOW AS C
AAA_DOW = convert_type(a5_eval_expression("=ALLTRIM(STR(DOW(Date()),1))",local_variables()),"C") 

DIM VCounter as N = -1
V_Aaa_Interval_Factor = "30" 'no table to supply value, try hard coding it

'Check for Time event every 30 minutes on the hour and half hour

if V_Aaa_Interval_Factor = "30"
while VCounter<=48
VCounter = VCounter + 1
If VCounter*1800 = VSecAftMid
	ui_msg_box("Note:","vCounter is "+alltrim(str(vCounter))+crlf()+"vSecaftmid is "+alltrim(str(vSecaftmid)))
'Trigger_Tripped = .T.
'AAA_Ack = .F.
exit while
end if
wend
elseif V_Aaa_Interval_Factor = "60"

'Check for time event overry hour on the hour
while VCounter<=24
VCounter = VCounter + 1
If VCounter*3600 = VSecAftMid
	ui_msg_box("Note:","vCounter is "+alltrim(str(vCounter))+crlf()+"vSecaftmid is "+alltrim(str(vSecaftmid)))
'Trigger_Tripped = .T.
'AAA_Ack = .F.
exit while
else
exit while
end if
wend
end if

**Dean W. Charron** · 09-23-2011, 02:45 PM

Re: Help with code

Hey Stan, Looks like you nailed it! I am burnt out for today and will modify your code with fresh and rested eyes tomorrow to try it out. I REALLY appreciate your help! Thanks, Dean

**Mike Wilson** · 09-23-2011, 02:57 PM

Re: Help with code

Dean,
The equation being tested is vcounter*1800. This will yield only 48 exact values. The VSecAftMid will have to be exactly one of those 48 values or a match is not made. Your cutting it too close with the exactness of the number being 1 second and a time of firing every second. I think the span idea is correct to establish a little tolerance so the exact match is not required. I would make it be a 2 second tolerance range with the following:

Code:

while VCounter<48            'note now just less than --- vcounter+1 tests the upper limit
       VCounter = VCounter + 1
       If between(VSecAftMid,(vcounter*1800)-1,(vcounter*1800)+1)
            Trigger_Tripped = .T.
            AAA_Ack = .F.
            sleep(3)            'delay so next timer event won't possibly produce a match
            exit while
       end if
wend

I also could not get it to work without changing the filter to

Code:

query.filter = "dow_num = "+quote(AAA_DOW) + " .and. time_block="+Var->VTB

**Dean W. Charron** · 09-24-2011, 05:26 AM

Re: Help with code

Okay, now I'm really stumped. I used info from the two replies to create the attached code. The V_Aaa_Interval_Factor seems to be reading properly from the table (I globalized the value and pasted it onto the runtime screen), however, it only evaluates the "30" loop not the "60" loop. I just don't understand why this isn't working...I must be having a major brain fart or something! The hardcoded V_Aaa_Interval_Factor variable seemed to work fine...I am using the Quote() feature to evaluate the table field.

'Set Trigger_Tripped variable to .F. and AAA_Ack to .T.
AAA_Ack = a5_eval_expression("=.T.")
Trigger_Tripped = a5_eval_expression("=.F.")

'Define VSecAftMid as N
DIM GLOBAL VSecAftMid AS N
VSecAftMid = a5_eval_expression("=TOSECONDS(TIME())")

'Check for Time event every 30 minutes on the hour and half hour
DIM VCounter as N = -1
while VCounter<=48 .and. V_Aaa_Interval_Factor = "30"
VCounter = VCounter + 1
If VCounter*1800 = VSecAftMid then
Trigger_Tripped = .T.
AAA_Ack = .F.
ui_msg_box("Note:","vCounter is "+alltrim(str(vCounter))+crlf()+"vSecaftmid is "+alltrim(str(vSecaftmid)))
exit while
end if
wend

'Check for time event every hour on the hour
while VCounter<=24 .and. V_Aaa_Interval_Factor = "60"
VCounter = VCounter + 1
If VCounter*3600 = VSecAftMid then
Trigger_Tripped = .T.
AAA_Ack = .F.
ui_msg_box("Note:","vCounter is "+alltrim(str(vCounter))+crlf()+"vSecaftmid is "+alltrim(str(vSecaftmid)))
exit while
else
exit while
end if
wend

**Dean W. Charron** · 09-24-2011, 05:28 AM

Re: Help with code

'Store Interval_Factor field to V_AAA_Interval_Factor
dim tbl as p
tbl = table.open("aaa_intervals")
query.filter = "dow_num = "+quote(AAA_DOW) + " .and. time_block="+Var->VTB
query.order = ""
query.flags = ""
dim i_tbl as p
i_tbl = tbl.query_create()
dim recs as n
recs = i_tbl.records_get()
if recs = 0 then
ui_msg_box("Error","No records satisfy the query '" + query.filter + "'.",UI_STOP_SYMBOL)
end
end if
tbl.fetch_first()

DIM Shared V_Aaa_Interval_Factor AS C
V_Aaa_Interval_Factor = tbl.eval("Aaa_Interval_Factor")
tbl.close()

**Dean W. Charron** · 09-24-2011, 10:18 AM

Re: Help with code

Thanks for the help--I found the culprit!

exit while
else
exit while
end if
wend

It was a simple loop error--the "else" and "exit while" were not only not needed, they were causing the program not to execute properly. Problem solved!

Announcement

The Alpha Software Forum Participation Guidelines

Help with code

Help with code

Comment

Comment

Comment

Comment

Comment

Comment

Comment

Comment

Comment

Comment

Comment