Check for Field Changes

[Terry Morgan]

I have the following scripts attached to the field & form actions as decribed. You may be able to see from this I am trying to write to a log table when the operator has beed changed. However if the operator field is changed but not departed the log is not written. Where am I going wrong - heres the scripts:-

Onarrive Operator field
dim shared oldoperator as c
tbl=table.current()
var->oldoperator=tbl.operator


Ondepart Operator field
dim shared newoperator as c
tbl=table.current()
var->newoperator=tbl.operator


Onsave form actions
tbl=table.current()
IF var->oldoperatorvar->newoperator
tbl2 = table.open("qoperatorlog") 'Open the operatorlog table
tbl2.enter_begin() 'Enter a new record
tbl2.Oldinitials = var->oldoperator
tbl2.Newinitials = var->newoperator
tbl2.Qno = "BGQ"+ut(str(tbl.qno))
tbl2.Enq_date = tbl.enq_date
tbl2.Changedate = DATE()
tbl2.Changetime = TIME()
tbl2.enter_end(.t.) 'Save the record
tbl2.close() 'Close the table
END IF

TIA
Terry

[Terry Morgan]

RE: Check for Field Changes

I now think their may be more wrong with these scripts than first thought I.E. if you move records whilst staying in the operator field & then depart the field without having made a change the log is written to in error perhaps the first script shoul be to Onchange not Onarrive??
Thanks
Terry

[JohnZaleski]

RE: Check for Field Changes

Terry,
If you have a5v4.5 you can use this:

fld = tbl.field_get("Lastname")
Original_value = fld.initial_value_get()

I think this will give you the initial value anytime before a change.

John

[Terry Morgan]

RE: Check for Field Changes

I am testing 4.5 at the moment so do not wish to use that new feature, apart from which i am trying to ensure that the operator field cannot be changed without the log being updated. I therefore need help to make sure my scripts which are fundamentally correct are attached the the right events field or form.
I hope someone can help.
Thanks
Terry

[JohnZaleski]

RE: Check for Field Changes

Terry,
If you can't use Alpha's new intial value function (absolutely the best way - that's why they gave this to us), try getting the initial field value in the on fetch event of the form. This may not work for the first record showing when you open the form, but you can possibly get this using the oninit or on activate.
John

[Peter.Wayne]

RE: Check for Field Changes

terry,

in your case, i would use the table's
CanChangeRecord and OnSaveRecord events.

e.g. for the CanChangeRecord event:

dim shared oldoperator as c
tbl=table.current()
oldoperator=tbl.operator


and for the OnSaveRecord event:

dim shared oldoperator as c
tbl=table.current()
if oldoperatortbl.operator
tbl2 = table.open("qoperatorlog") 'Open the operatorlog table
tbl2.enter_begin() 'Enter a new record
tbl2.Oldinitials = oldoperator
tbl2.Newinitials = tbl.operator
tbl2.Qno = "BGQ"+ut(str(tbl.qno))
tbl2.Enq_date = tbl.enq_date
tbl2.Changedate = DATE()
tbl2.Changetime = TIME()
tbl2.enter_end(.t.) 'Save the record
tbl2.close() 'Close the table
END IF


also, for the OnEnterRecord event, you need

dim shared oldoperator as c
oldoperator=""


to see the oldoperator variable to a null value for new records

[Terry Morgan]

RE: Check for Field Changes

Thanks Peter, I discovered the use of onsave and have set up the following:-
Onfetch Form actions
dim shared oldoperator as c
dim shared newoperator as c
var->oldoperator=tbl.operator
var->newoperator=tbl.operator

Onchange Operator field
tbl=table.current()
var->newoperator=tbl.operator


Onsave form actions
tbl=table.current()
IF var->oldoperatorvar->newoperator
tbl2 = table.open("qoperatorlog") 'Open the operatorlog table
tbl2.enter_begin() 'Enter a new record
tbl2.Oldoperator = var->oldoperator
tbl2.Newoperator = var->newoperator
tbl2.Qno = "BGQ"+ut(str(tbl.qno))
tbl2.Enq_date = tbl.enq_date
tbl2.Changedate = DATE()
tbl2.Changetime = TIME()
tbl2.enter_end(.t.) 'Save the record
tbl2.close() 'Close the table
END IF

Thabks again
Terry

[Pat Bremkamp]

RE: Check for Field Changes

Terry,

One other thought... I found it helped my operators to put a "cancel" button on the form that would return the value to the original value...Sometimes they catch themselves updating the wrong record, and if they would move to another record it would save their changes.

Pat

[JohnZaleski]

RE: Check for Field Changes

Terry,
It not only is not necessary to capture the new operator on the on change field event, there are a few scenarios that it might not work on. One scenario might be if they changed the operator value which establishes your new operator value, escaped to cancel their changes and stayed on the same record and changed another field ( not the operator ). I don't think a fetch is enacted because you are not moving to another record so your new operator value is probably not reset. I havn't tested this, but it seems logical. Just like Peter Wayne suggested, if on the "On Save Record" event you use

"if oldoperatortbl.operator"

to test whether or not the value has been changed I think you will eliminate potential problems. "tb1.operator" is the new operator at that point and you do not need a variable for it.

John