ui_get_list_array

[Nicholas Lawson]

Hello
I am trying to create a list array of a field value for the purpose of filtering records on a form. The code I have written returns the correct values to the trace window, but does not populate the array
Code is as follows
tbl = table.current() 'bankouts.dbf
tbl.fetch_first()
count = tbl.records_get()
FOR i = 1 TO count
vSearch_for = (dtoc(tbl.date)+" "+tbl.name)
trace.writeln(vSearch_for) 'test result correctly
tbl.fetch_next()
choice = ui_get_list_array("Choose a Bankout",1, "vSearch_for")
IF choice = "" THEN
END
END IF
'code here
NEXT i

I know I can embed a browse of the records and filter by date but the form is very full already and I dont want the end user to type in a value to search by.

Help me Mister Wizard


Nick

[Pat Bremkamp]

RE: ui_get_list_array

Nick,

You need to dim the array first and then assign the values. Here's an example:
dim namearray(15) as C
dim i as n
i=1
tbl=table.open("menus",file_ro_shared)
tbl.index_primary_put("field1")
tbl.fetch_first()
while .not.tbl.fetch_EOF()
namearray(i)=tbl.username
i=i+1
tbl.fetch_next()
end while
tbl.close()
thisws=ui_get_list_array("WORKSTATION NAME",1,"namearray")

In my case I know that 15 is enough, you may need more or less.

[Nicholas Lawson]

RE: ui_get_list_array

Hello Pat

Thanks for your help

Nick

[Nicholas Lawson]

RE: ui_get_list_array

Hi Pat

Well I tried and now I get "array index out of range"
Here are the changes based on your suggestion
dim vSearch_for (30) AS C
dim i AS N
i = 1
tbl = table.current()
tbl.index_primary_put("Search_by")
tbl.fetch_first()
While .not. tbl.fetch_EOF()
vSearch_for(i) = dtoc(tbl.date)
i = i+1
tbl.fetch_next()
End While
choice = ui_get_list_array("Choose Bankout",1,"vSearch_for")
IF choice = "" THEN
END
'code here
END IF

If you have any more suggestions they would be appreciated.

thanks
Nick

[Pat Bremkamp]

RE: ui_get_list_array

Nick,
In the script you posted, it looks like there is an extra space in your array dim statement:
is
dim vSearch_for (30) AS C
should be
dim vSearch_for(30) AS C

That could be the problem.

[Nicholas Lawson]

RE: ui_get_list_array

Sorry about the typo but it is written without the space. The xbasic manual displays this error if the variable is declared incorrectly. It's not also I checked the table to insure there are no busted records or incorrect date values.

Nick

[Stan Mathews]

RE: ui_get_list_array

"array index out of range" could also mean that in your
vSearch_for(i) = dtoc(tbl.date), "i" passed the original dim statement value of 30, I think.

Did the error return a line number? If it wasn't line number 1, then it was probably later in the script.
Are you sure 30 is enough?

Try using the debugger and seeing if the script bombs on the dim statement or only when it is processing the assignment loop.

[JohnZaleski]

RE: ui_get_list_array

You might try changing:
dim vSearch_for (30) AS C
dim i AS N
i = 1
tbl = table.current()
tbl.index_primary_put("Search_by")

to:
dim i AS N
i = 1
tbl = table.current()
tbl.index_primary_put("Search_by")
records = tb1.records_get()
dim vSearch_for(records) AS C

[CraigSchumacker]

RE: ui_get_list_array



Nick:
Let Alpha count how many records exist in the lookup database. I think
it's safe to say that you should probably not limit the dimension of the array
since the lookup database can conceivably grow beyond the size of the
array. This may not be exactly what you need, but it should get you
going...
tbl = table.current()
tbl.index_primary_put("Search_by")
count = tbl.records_get()

dim vSearch_for(count) AS C
dim i AS N

i = 1

tbl.fetch_first()

While .not. tbl.fetch_EOF()
vSearch_for(i) = dtoc(tbl.date)
i = i+1
tbl.fetch_next()
End While

choice = ui_get_list_array("Choose Bankout",1,"vSearch_for")
IF choice = "" THEN
END
end if
'place code here
end
Craig

[Nicholas Lawson]

RE: ui_get_list_array

Thanks Everyone
We will give them a try.

Nick

[JerryBrightbill]

RE: ui_get_list_array

Craig,

Just a small suggestion. Set count = count +1. For some reason I have seen array out of bounds errors pop up when the array is dimensioned to the exact number of possible records. This has happened on an irregular basis, but just enough to cause me to pull out the remaining gray hair.

Jerry

[Nicholas Lawson]

RE: ui_get_list_array

Hello once again

Craig your change to read the entire table works perfect. thanks again to all of you

Nick

[CraigSchumacker]

RE: ui_get_list_array

Jerry:

Your point is well taken, but probably falls short of resolving why you have the array-out-of-bounds errors.

The reason for your error is likely that between when you get a record count, and when you load the array, some other user has added a record.

In Nick's case, his script will allow only a fraction of a second for this to occur. Other scripts may have a larger window within which records can be added to the lookup, disrupting the array.

So I guess it should be count = (count) + (maximum number of users)!

Interesting point, Jerry!

Good food for thought...

Craig