Not an Executable/Bad Object Handle

[scottly]

Grrr - another productivity killer.

A5V5 Latest Version

I have a Modal Maintenance Form that is called from another Form - the below happens whether I open it from another form (or just run it off the Forms menu).

If I place this code in the OnInit event of the called Form:

topparent:Field1.value = ws_athleteid
t3=table.open("athletes")
t3.fetch_first()
query.filter = "At_id=var->ws_athleteid"
qry_meetings = t3.query_create()
nrecs=qry_meetings.records_get()
topparent:ws_athlete.value=t3.At_surname+t3.At_firstname
t3.close()

Then I get a "bad object handle" message and then the Form opens (with my athlete name loaded). If I comment out the Oninit code:

'topparent:Field1.value = ws_athleteid
't3=table.open("athletes")
't3.fetch_first()
'query.filter = "At_id=var->ws_athleteid"
'qry_meetings = t3.query_create()
'nrecs=qry_meetings.records_get()
'topparent:ws_athlete.value=t3.At_surname+t3.At_firstname
't3.close()

I get a "not an executable file" - but then opens my Form - go figure...

ws_athleteid is a global variable set in my calling Form. ws_athlete is a variable defined in the called Form using the A5 variable define facility in the Form/variable pop-down menu.

If I remove all code completly from the OnInit event then the Form opens fine from menu and from my calling Form.

Now here's the catch, I have another Form that I call from the same Form, I have the same Init event code and it works a treat - the only difference being that I open the called Form in new record mode (this.new_record()).

this.new_record()
topparent:Field1.value = ws_athleteid
t3=table.open("athletes")
t3.fetch_first()
query.filter = "At_id=var->ws_athleteid"
qry_meetings = t3.query_create()
nrecs=qry_meetings.records_get()
topparent:ws_athlete.value=t3.At_surname+t3.At_firstname
t3.close()

Both called Forms are Modal, both called Forms maintain the same data (in fact one Form was duplicated form the other).

A5 offers no useful error info - nor does debug help solve the issue. Is it a problem with my code or an A5 issue? Has anyone come across the same issue - and found a solution..

I have noticed prior postings regarding similar errors - but I find the above inexplicable..

Regards,
Scott

Ps

Here's the code that decides which Form to call:

DIM GLOBAL ws_athleteid AS n
DIM nrecs as n
DIM Shared varP_Mnt_athleteprofilenew as P
DIM Shared varP_Mnt_athleteprofile as P
DIM layout_name as c
'Get 'Value' property of 'Athleteid' in Form 'mnt_athletes' .
DIM GLOBAL ws_athleteid AS n
ws_athleteid = topparent:Athleteid.value
t3=table.open("athleteprofile")
t3.fetch_first()
query.filter = "Ap_athleteid=var->ws_athleteid"
qry_meetings = t3.query_create()
nrecs=qry_meetings.records_get()
t3.close()
If nrecs=0 then
layout_name = "Mnt_athleteprofilenew"
varP_Mnt_athleteprofilenew = :Form.view(layout_name,"dialog")
if is_object(varP_Mnt_athleteprofilenew) = .t. then
varP_Mnt_athleteprofilenew.close()
end if
end if
If nrecs>0 then
layout_name = "Mnt_athleteprofile"
varP_Mnt_athleteprofile = :Form.view(layout_name,"dialog")
if is_object(varP_Mnt_athleteprofile) = .t. then varP_Mnt_athleteprofile.close()
end if
end if

[scottly]

RE: Not an Executable/Bad Object Handle

I have now copied the called Form that does work to a new Form, added the this.new_record() line in the OnInit code and it works. Then I noticed an additonal difference - the version that won't work has a Filter defined (via the Form Properties and devised using the pick and click routine provided in A5) - Ap_athleteid = Var->ws_athleteid

As you will see, ws_athleteid is a GLOBAL variable defined in the calling Form. Is the filter not valid, did A5 allow the injection of code via it's tools that was not correct?, or is it not executing the code correctly when running it, or have I stuffed up somewhere else?

If I remove the Filter, the Form can be called without error and for some reason it loads the correct record that I am looking for - but no filter is defined to ask for that record to be found.. The calling Form maintains an Athlete Record and the Called form maintains an athlete profile record - not defined in a set. I must be missing something here.. can anyone shed some light before I pull all of my hair out?

Regards,
Scott

[scottly]

RE: Not an Executable/Bad Object Handle

Oop's- I mean removed the this.new_record() line - not added.

[Ohlen Cartmell]

RE: Not an Executable/Bad Object Handle

Scott,
I can't spot the difficulty in your script, but have you traced the action with the debugger. Using debugger you could track the assignment of variables and action of the script one step at a time and possibly find the spot where it fails.

[Tom Cone Jr]

RE: Not an Executable/Bad Object Handle

Scott,

Two things I'd try:

topparent:Field1.value = ws_athleteid
could be changed to
this:Field1.value = var->ws_athleteid

The onInit event is running at the form level. You're
trying to modify an object value on the current form,
right ? What does 'topparent' mean to the current form ?

The 'Var->' prefix may be surplusage, but I think it's a
good practice.


topparent:ws_athlete.value=t3.At_surname+t3.At_firstname
could be changed to
this:ws_athlete.value=t3.At_surname+t3.At_firstname

For the same reasons.

-- tom

[drgarytraub]

RE: Not an Executable/Bad Object Handle



Also, when you comment out an entire script with the apostraphe before each line, you will get that error message every time. If you want to stop an event code from running, so that you can see if it causes whatever wrror, then use an 'end' statement at the top of your script.

Gary

[scottly]

RE: Not an Executable/Bad Object Handle

thanks - hopefully one day that 'bug' will be fixed.

[scottly]

RE: Not an Executable/Bad Object Handle

Hi Tom

Thanks for your input - you seem to be a tireless contributor to this forum!

Using 'this' instead of 'topparent' fixes the issue. I used the script Genie to get the code which is where the topparent came from - being fairly new at A5 I did not know any better than what it generated for me. May be I selected an incorrect option in the script Genie or maybe it did not return the best practise code - I will have to investigate some more.

Regards,
Scott

[Tom Cone Jr]

RE: Not an Executable/Bad Object Handle

Scott, review the 'object addressing' sections of the Xbasic Reference Manual. You'll find an orderly system for referencing objects absolutely (by name), or indirectly by reference to the 'current' context.

topparent
parent
parentform

these are all examples of indirect references, and often used in scripts run from buttons. The button's OnPush event is the 'current' context. If your button's OnPush event used the term 'this' it would reference the button itself. See the diff ?

-- tom

[scottly]

RE: Not an Executable/Bad Object Handle

k - I get it now - thanks. Importantly, it would seem that I must also remember not to take the Genie created code for granted - it will not neccessarily 'throw up' the correct code - a trap for young players..

[Kellen Furness]

RE: Not an Executable/Bad Object Handle

I'm so glad you had this thread here! I've been struggling for hours with this same ____ problem and your banter moved my thinking in a new direction. I was already searching on my called form's OnInit, but it turns out one tiny piece of my genie-generated code doesn't work correctly in my form's OnInit, but it DOES work just fine in the same form's OnActivate with no other changes. Maybe I will sleep tonight :-) Bless the message groups and all who contribute (I promise to contribute more when I know what I'm talking about!)

[Tom Cone Jr]

RE: Not an Executable/Bad Object Handle

Kellen,

It would be helpful to the 'next guy' if you would post the details describing which piece of the genie based script wouldn't work in the OnInit of your form.

-- tom

[Kellen Furness]

RE: Not an Executable/Bad Object Handle

Good idea Tom...FYI to anyone interested in this topic...

I have a form to enter misc daily notes for a gas station (ie weather; competitor prices, etc). Only ONE record is wanted per day, so I want a NEW record if there isn't one yet for the day, or to EDIT the record if one exists already. I do this by setting a global C variable "entry_type" in the launching form to "new" or "edit" depending on whether a record exists in the target table for the appropriate effective_date. The actual data entry form is then initialed based on the value in var->extry_type.

The genie code that did NOT work in the OnInit event when var->entry_type="edit" is "Set Field Values", changing the value in Emp_id (employee_id field) to the value in var->login_id (which holds the emp_id of the currently logged in user). Interestingly, this same code works fine since I moved it (unchanged) to the onActivate event.

FYI, a conversion to inline xbasic code shows the genie code as generating "topparent:Emp_id.value=login_id". Looks fine to me, but I still have a lot to learn).