help in terminating a "while" routine

[fddizon]

Re: help in terminating a "while" routine

guys,

i will make explain more and will attach a screen shot.

i have products table w/h u can see above portion of the form.
2 grids, 1 for sales and 1 for purchases.
i made 2 calculated fields to total all purchases and sales respectively to get total of all sales and all purchases per item.
i then post these values to the primary table w/c is products on fields purchases and sales field. then i subtract sales from purchases to get the qty_oh.

im doing this in form level just to save me from creating codes for the total() of transactions per item and also some filtering...

hopes this clarifies things

[fddizon]

Re: help in terminating a "while" routine

martin and gabriel,

i thought of a workaround... i dont know if this will work and also dont know how to get the value of the record number.

what i have in mind is fetch the last record and store the recno to a variable which we can test if it reaches this number and will end the while routine...

the this i dont know how to get the current recno...

dim txtable as p
dim vLast as n

txtable = table.current()
txtable.fetch_last()
vLast = recno() ' is recno returns numeric?
txtable.fetch_first()

while .not. txtable.recno() = vLast
	PURCHASES.value = PURCHASED_TOT.value
	SALES.value = SALES_TOT.value
	QTY_OH.value = PURCHASES.value - SALES.value
	
	topparent.commit()
	
	:process_data.Fetch_Next()

end while

ui_msg_box("TLCSYS", "Processing comleted...",UI_INFORMATION_SYMBOL+UI_OK)

will this work?

[fddizon]

Re: help in terminating a "while" routine

If you use my original script, then yes, you would use tablesum()

but just for the fun of it try my line where I put

while .not. parentform:tables.parent table name here.fetch_eof()
(note:this presumes the calculated fields are all up-to-date)

otherwise, I think my original script with tablesum() would be necessary

martin,

i tried using :process_date.fetch_eof() '<--it doesnt show on the auto complete list
the form doesnt support to go eof

[MikeC]

Re: help in terminating a &quot;while&quot; routine

Francis,
There is a reason not to mix table and form levels when writing code....it is problematic at best. Keep them separate and try some of the suggestions.

EOF is a table method and would be totally surprised if it worked at a form level.

[fddizon]

Re: help in terminating a &quot;while&quot; routine

mike,

i wish i could do them all in table level. i dont know how to use tablesum(). my apology to all.

this code did worked.

'Date Created: 11-Jul-2010 04:43:15 PM
'Last Updated: 11-Jul-2010 11:29:31 PM
'Created By  : RT Angeles
'Updated By  : fdd

dim txtable as p
txtable = table.current()
txtable.fetch_last()
vLast = txtable.recno()

txtable.fetch_first()

while .not. txtable.fetch_eof()
	
	PURCHASES.value = PURCHASED_TOT.value
	SALES.value = SALES_TOT.value
	QTY_OH.value = PURCHASES.value - SALES.value
	
	topparent.commit()
	
	:process_data.Fetch_Next()
	if txtable.recno() = vLast then
	    exit while
	end if

end while

ui_msg_box("TLCSYS", "Processing completed...",UI_INFORMATION_SYMBOL+UI_OK)

thanks

[G Gabriel]

Re: help in terminating a &quot;while&quot; routine

As I suspected:
1-You are trying to do alpha's work (calcuating values from the child)
2-You are trying to calculate values from the child and post to the parent


First off: table.current() will send a pointer to the topparent in the set. If you want to point to a child, use the proper number, e.g. table.current(2) or 3 or whatever the rank is. Your script as it is only shuffles through the topparent.

Second, all you need is calc field for each one of these calculations using dbsum(). You don't need any scripts, a calc field is much better in this scenario.

[fddizon]

Re: help in terminating a &quot;while&quot; routine

Gabriel,

my apology of not making it clear. im not that good in explaining of what i have in mind.

the reason why i made this is to fix the qty on hand in my products table. i dont why the posting failed to get the accurate qty.

data on my report shows like this example.

code prod description purchased sold qty_oh
0001 item description 10 2 6

the owner wants to see the report in accurate output thats why i did this routine. but the thing is, after the last record, it creates a blank record on and on that i have to end task alpha.

i was about to compare a while ago that in vfp, you can go eof at form level. (forgot to add this line when i told you i was doing this in alpha)

regards

[G Gabriel]

Re: help in terminating a &quot;while&quot; routine

Francis:
Let me see if I could walk you through your code and try to explain why it doesn't work:

dim txtable as p
txtable = table.current() [COLOR="Blue"]this sends a pointer to the parent table, not the child[/COLOR]
txtable.fetch_first()

while .not. txtable.fetch_eof()
	PURCHASES.value = PURCHASED_TOT.value[COLOR="Blue"]'this and the next 2 lines assign values to either fields in your table or variables. I don't know if these are fields in the parent or the child table.[/COLOR]
	SALES.value = SALES_TOT.value
	QTY_OH.value = PURCHASES.value - SALES.value
	
	topparent.commit()
	
	:process_data.Fetch_Next()[COLOR="Blue"]'this fetch the next record in the parent. After the very last loop, it will create a new record and then save it and that's exactly what you see, flashing (looping through all parent's records) then a new blank record[/COLOR]

end while

To make things easier, post a zip file and indicate what you wish to do.

[MikeC]

Re: help in terminating a &quot;while&quot; routine

If you are "stuck" doing it the way you are....as there is no function I know of to prevent going past the end of a browse/form record and creating a new record (as G has explained), there is a way to do this. Prior to any of the code, Fetch_Last() in your browse/form, set a variable to that record and then Fetch_First(). Then in your code, test for when the record equals the variable right before the Fetch_Next() and if it is the same, break out of the loop.

OR, and maybe the best idea, is to do as G last indicated....provide the sample.... :)

[fddizon]

Re: help in terminating a &quot;while&quot; routine

mike and gabriel,

thank you so much in helping me.
my #20 post fixed my problem.

will post another issue... please read

[G Gabriel]

Re: help in terminating a &quot;while&quot; routine

You could avoid adding a new record by many different means, e.g. check the table mode, recno exceeded, certain values being blank etc. but that's not the issue. The issue is 1-Francis is shuffling the wrong table 2-with the object of summing up values 3-to post to the parent. None of that is happening here.